Lava generation problem in forge #651-652

[ProgrammerHero]

I noticed the lava at the bottom of the world when using forge 651-652 is not generating properly.  It creates some of the source blocks for the pools but not all of them (usually only a couple of blocks in the corners).  The result is all the lava pools at the bottom of the world generate as a couple of separate lava flows instead of a single lake - which can manifest as small caves at bedrock with lava walls (since they didn't fill in properly).

 

I disabled all of my mods thinking one of them caused it but the problem persisted.  I also noticed that forge 650 generates fine, and I passed a surface lava lake that also appeared fine.

[LexManos]

Got a seed and location I can test, I noticed tat the world gen create flowing lava blocks, but thats how vanilla does it.

We did make a small change to this recently, but the logic itself is doing the same thing as before out change:

https://github.com/MinecraftForge/MinecraftForge/commit/3818ffdf5692a36451c59efabb8af54cca10bb17

Note that both the segment we remove and add use Block.lavaMoving

[ProgrammerHero]

I found the bug, I submitted a pull request that fixes it.

https://github.com/MinecraftForge/MinecraftForge/pull/521

 

It includes a seed and location to test with.

seed = -2954127421728660883

x,z = -5,141

y = 11