Jump to content

Help with game crash on custom block placement


majicmaj

Recommended Posts

Hey all. I'm following this tutorial below to create a mod for my final project in school. When I'm placing my block (artisan station) the game is crashing for me. No one else seems to be having this problem. Can someone give it a look and help? here is my code on github, i think its this particular file that might have the issue but feel free to look around the repo.
https://github.com/majicmaj/majcraft/blob/master/src/main/java/com/majicmaj/majcraft/blocks/ArtisianStationTile.java

Spoiler

 

Here is the code I have for it:

ArtisianStation:

Spoiler

package com.majicmaj.majcraft.blocks;

import javax.annotation.Nullable;

import net.minecraft.block.Block;
import net.minecraft.block.BlockState;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.entity.LivingEntity;
import net.minecraft.item.BlockItemUseContext;
import net.minecraft.item.ItemStack;
import net.minecraft.state.StateContainer;
import net.minecraft.state.properties.BlockStateProperties;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.Direction;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.IBlockReader;
import net.minecraft.world.World;
import net.minecraftforge.common.ToolType;

public class ArtisianStation extends Block{
	
	public ArtisianStation() {
		super(Properties.create(Material.WOOD)
				.sound(SoundType.WOOD)
				.hardnessAndResistance(2.5f)
				//.lightValue(14)
				.harvestLevel(1)
				.harvestTool(ToolType.PICKAXE)
		);
		setRegistryName("artisian_station");
	}
	
	@Override
	public boolean hasTileEntity(BlockState state) {
		return true;
	}
	
	@Nullable
	@Override
	public TileEntity createTileEntity(BlockState state, IBlockReader world) {
		return new ArtisianStationTile();
	}
	
	@Nullable
    @Override
    public BlockState getStateForPlacement(BlockItemUseContext context) {
        BlockState blockstate = super.getStateForPlacement(context);
        if (blockstate != null) {
            blockstate = blockstate.with(BlockStateProperties.FACING, context.getNearestLookingDirection());
        }
        return blockstate;
    }
	
	@Override
	protected void fillStateContainer(StateContainer.Builder<Block, BlockState> builder) {
		builder.add(BlockStateProperties.FACING);
	}
}

 

ArtisianStationTile:

Spoiler

package com.majicmaj.majcraft.blocks;

import net.minecraft.nbt.CompoundNBT;
import net.minecraft.tileentity.ITickableTileEntity;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.Direction;
import net.minecraftforge.common.capabilities.Capability;
import net.minecraftforge.common.util.LazyOptional;
import net.minecraftforge.items.CapabilityItemHandler;
import net.minecraftforge.items.ItemStackHandler;

import static com.majicmaj.majcraft.blocks.ModBlocks.ARTISIANSTATIONTILE;

import javax.annotation.Nonnull;
import javax.annotation.Nullable;

public class ArtisianStationTile extends TileEntity implements ITickableTileEntity {

	private ItemStackHandler handler;
	
	public ArtisianStationTile() {
		super(ARTISIANSTATIONTILE);
	}

	@Override
	public void tick() {
	}
	
	@Override
	public void read(CompoundNBT tag) {
		CompoundNBT invTag = tag.getCompound("inv");
		getHandler().deserializeNBT(invTag);
		super.read(tag);
	}
	
	@Override
	public CompoundNBT write(CompoundNBT tag) {
		CompoundNBT compound = getHandler().serializeNBT();
		tag.put("inv", compound);
		return super.write(tag);
	}
	
	private ItemStackHandler getHandler() {
		if (handler == null) {
			handler = new ItemStackHandler(1);
		}
		return handler;
	}
	
	   @Nonnull
	   @Override
	   public <T> LazyOptional<T> getCapability(@Nonnull Capability<T> cap, @Nullable Direction side) {
	        if (cap == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY) {
	            return LazyOptional.of(() -> (T) getHandler());
	        }
	        return super.getCapability(cap, side);
	}
}

 

 

Link to comment
Share on other sites

https://github.com/majicmaj/majcraft/blob/master/src/main/java/com/majicmaj/majcraft/blocks/ArtisianStationTile.java#L54

Create LazyOptionals once.

Is unlikely related to your issue, but it is still worth pointing out.

See this as to why:

 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Thank you, I traced it back to a misspelled registry. How would I implement LazyOptional once? would you mind showing me in a pull request?

Edit: also would anyone know how to implement smelting recipes? I've tried adding it but it doesnt have a method "addSmelting".

Edited by majicmaj
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.