Search the Forums BEFORE making a new post.

1.12.2 fluid registry issues

Start new topic

Posted September 21, 20195 yr

I was working on my minecraft mod, however I ran into a roadblock when attempting to create a new liquid called magic water. Here is my code:

//Registry handler

import com.Epic_ModZz.Magically_Magic.init.EntityInit;
import com.Epic_ModZz.Magically_Magic.init.FluidInit;
import com.Epic_ModZz.Magically_Magic.init.ModBlocks;
import com.Epic_ModZz.Magically_Magic.init.ModItems;
import com.Epic_ModZz.Magically_Magic.util.IHasModel;

import net.minecraft.block.Block;
import net.minecraft.item.Item;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

@EventBusSubscriber
public class RegistryHandler {
	@SubscribeEvent
	public static void onItemRegister(RegistryEvent.Register<Item> event)
	{
		event.getRegistry().registerAll(ModItems.ITEMS.toArray(new Item[0]));
	}
	
	@SubscribeEvent
	public static void onBlockRegister(RegistryEvent.Register<Block> event)
	{
		event.getRegistry().registerAll(ModBlocks.BLOCKS.toArray(new Block[0]));
	} 
	
	
	@SubscribeEvent
	public static void onModelRegister(ModelRegistryEvent event)
	{
		for(Item item : ModItems.ITEMS)
		{
			if(item instanceof IHasModel)
			{
				((IHasModel)item).registerModels();
			}
		}
		
		
		for(Block block : ModBlocks.BLOCKS)
		{
			if(block instanceof IHasModel)
			{
				((IHasModel)block).registerModels();
			} 
		}		
		
	}
	
	public static void preInitRegistries() {
		FluidInit.registerFluids();
		EntityInit.registerEntities();
		RenderHandlers .registerCustomMeshesAndStates();
	}
}

//FluidInit

import com.Epic_ModZz.Magically_Magic.fluids.FluidLiquid;

import net.minecraft.util.ResourceLocation;
import net.minecraftforge.fluids.Fluid;
import net.minecraftforge.fluids.FluidRegistry;

public class FluidInit {
	public static final Fluid MAGIC_WATER = new FluidLiquid("magical_solution", new ResourceLocation("magi:blocks/magical_solution_still"), new ResourceLocation("magi:blocks/magical_solution_flowing"));
	
	
	
	public static void registerFluids() {
		registerFluid(MAGIC_WATER);
	}
	public static void registerFluid(Fluid fluid) {
		FluidRegistry.registerFluid(fluid);
		FluidRegistry.addBucketForFluid(fluid);
	}
}

//FluidLiquid

import net.minecraft.util.ResourceLocation;
import net.minecraftforge.fluids.Fluid;

public class FluidLiquid extends Fluid{

	public FluidLiquid(String name, ResourceLocation still, ResourceLocation flow) {
		super(name, still, flow);
		this.setUnlocalizedName(name);
	}
}

The person who fixes my error may suggest something to be added into the mod. This must be within reason however.

Edit: The error that this code causes is a crash when loading. In the console it said "Cannot create a fluidstack from an unregistered fluid"

Edited September 21, 20195 yr by Epic_ModZz

September 21, 20195 yr

Author

bump

September 21, 20195 yr

11 hours ago, Epic_ModZz said:

public static void preInitRegistries() {

Do you ever call this method? And if you do where?

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

September 21, 20195 yr

Author

21 minutes ago, Animefan8888 said:

Do you ever call this method? And if you do where?

I do in my main file

//Main

import com.Epic_ModZz.Magically_Magic.init.EntityInit;
import com.Epic_ModZz.Magically_Magic.proxy.CommonProxy;
import com.Epic_ModZz.Magically_Magic.util.Reference;
import com.Epic_ModZz.Magically_Magic.util.handlers.RegistryHandler;
import com.Epic_ModZz.Magically_Magic.util.handlers.RenderHandlers;

import net.minecraftforge.fluids.FluidRegistry;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.Mod.Instance;
import net.minecraftforge.fml.common.SidedProxy;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPostInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;

@Mod(modid = Reference.MOD_ID, name = Reference.NAME, version = Reference.VERSION)
public class Main {
	
	@Instance
	public static Main instance;
	
	@SidedProxy(clientSide = Reference.CLIENT_PROXY_CLASS, serverSide = Reference.COMMON_PROXY_CLASS)
	public static CommonProxy proxy;
	
	
	static { FluidRegistry.enableUniversalBucket(); }
	
	@EventHandler
	public static void PreInit(FMLPreInitializationEvent event)
	{

		RenderHandlers.registerEntityRenders();	
	}
	
	@EventHandler
	public static void Init(FMLInitializationEvent event)
	{
		RegistryHandler.preInitRegistries();
	}
	
	@EventHandler
	public static void PostInit(FMLPostInitializationEvent event)
	{
		
	}	

}

Edited September 21, 20195 yr by Epic_ModZz

September 21, 20195 yr

10 minutes ago, Epic_ModZz said:

RegistryHandler.preInitRegistries();

Does this get called try putting a println here. Also it's called preInitRegistries why is it in init? Secondly anything to do with rendering can't be done in the main mod class/common code use your ClientProxy.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

September 21, 20195 yr

Author

36 minutes ago, Animefan8888 said:

Does this get called try putting a println here. Also it's called preInitRegistries why is it in init? Secondly anything to do with rendering can't be done in the main mod class/common code use your ClientProxy.

I put a print statement here

	@EventHandler
	public static void PreInit(FMLPreInitializationEvent event)
	{
		System.out.print("ERRROOROROROROROROR");
		RenderHandlers.registerEntityRenders();	
	}

It printed that statement right before the error occured

11:31:18] [Client thread/INFO] [FML]: Found 0 ItemStackHolder annotations
[11:31:20] [Client thread/INFO] [FML]: Configured a dormant chunk cache size of 0
[11:31:20] [Forge Version Check/INFO] [forge.VersionCheck]: [forge] Starting version check at http://files.minecraftforge.net/maven/net/minecraftforge/forge/promotions_slim.json
ERRROOROROROROROROR[11:31:21] [Forge Version Check/INFO] [forge.VersionCheck]: [forge] Found status: OUTDATED Target: 14.23.5.2847
[11:31:28] [Client thread/WARN] [FML]: ****************************************
[11:31:28] [Client thread/WARN] [FML]: * Failed attempt to create a FluidStack for an unregistered Fluid magical_solution (type com.Epic_ModZz.Magically_Magic.fluids.FluidLiquid)

As for your second question, I was just following a mod tutorial. If I need to change the structure of my mod's files please let me know how to do that.

This is what is in my client proxy btw:

import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraftforge.client.model.ModelLoader;

public class ClientProxy extends CommonProxy {
	public void registerItemRenderer(Item item, int meta, String id)
	{
		ModelLoader.setCustomModelResourceLocation(item, meta, new ModelResourceLocation(item.getRegistryName(), id));
	}
}

Edited September 21, 20195 yr by Epic_ModZz

September 21, 20195 yr

23 minutes ago, Epic_ModZz said:

System.out.print("ERRROOROROROROROROR"); RenderHandlers.registerEntityRenders();

That's not where I asked you to put it...

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

September 21, 20195 yr

Author

Just now, Animefan8888 said:

That's not where I asked you to put it...

sry my bad

September 21, 20195 yr

Author

6 minutes ago, Animefan8888 said:

That's not where I asked you to put it...

I put it here and it didn't show up in console

	public static void preInitRegistries() {
		System.out.print("Testing Error");
		FluidInit.registerFluids();
		EntityInit.registerEntities();
		RenderHandlers .registerCustomMeshesAndStates();
	}

Edited September 21, 20195 yr by Epic_ModZz

September 21, 20195 yr

Author

bump

September 21, 20195 yr

4 hours ago, Epic_ModZz said:

I put it here and it didn't show up in console

It's not printing because the game crashes during preInit. You're calling that method during init. That's probably also why your Fluid is unregistered when the FluidStack is being made.

Fancy 3D Graphing Calculator mod, with many different coordinate systems.

Lightweight 3D/2D position/vector transformations library, also with support for different coordinate systems.

September 21, 20195 yr

Author

15 minutes ago, SerpentDagger said:

It's not printing because the game crashes during preInit. You're calling that method during init. That's probably also why your Fluid is unregistered when the FluidStack is being made.

Where should I put it then?

Edit: thx I just fixed it is there anything u want in the mod (within reason)

Edited September 21, 20195 yr by Epic_ModZz

1 year later...

August 22, 20214 yr

Alors, commentez faites-vous pour résoudre le problème ? Merci d'avance

This topic is now closed to further replies.

https://forums.minecraftforge.net/topic/76297-1122-fluid-registry-issues/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

New Forum Design/Update: Issues and Suggestions

Hiho,

first of all I want to say that the new forum design looks really good.

However, there are currently two issues:

In the "Unread" section, the "Mark all as Read" feature seems to be missing - or am I just overlooking it somewhere?
Some threads don’t automatically get marked as read when you open them. So the post still shows up in "Unread," even though you’ve already viewed it.
Example Thread: https://forums.minecraftforge.net/topic/159415-cannot-find-client-log-entries/

Then I have a smaller suggestion, referring to the Text Editor:

It is possible to move out the "Inline Code"-Feature from the "More Formatting Options" and add it directly to the Text Editor Tool Bar?
Same for "Quote"-Feature inside the Create Section

These two features are used quite often (at least by me) - as far as I remember, they were also available in the old forum design.

@Paint_Ninja @LexManos

By TileEntity · Posted 57 minutes ago57 min
Trying to boot MC Eternal 2 Server, works on linux not on Windows 11: Jvm args error

That fixed it! it's still being weird and not actually printing anything to CMD but the logs look fine and eventually the gui generated looking normal. Thanks for your help I've done that on linux before but windows servers have always just worked with one click for some reason for me

By Linksapprentice · 3 hours ago3 hr
Trying to boot MC Eternal 2 Server, works on linux not on Windows 11: Jvm args error

Make sure you are using Java 17 JDK

In the start script, replace the word "java" with the java 17 path (javaw.exe) and put it into quotation marks

By TileEntity · 6 hours ago6 hr
NEED HELP ASAP - Failed to load datapacks, can't proceed with server load. You can either fix your datapacks or reset to vanilla

There are client-side-only mods in your server - start with removing justenoughbreeding

By TileEntity · 6 hours ago6 hr
NEED HELP ASAP - Failed to load datapacks, can't proceed with server load. You can either fix your datapacks or reset to vanilla

Hey there, I have a big modpack I'm trying to run that I've put together with two other rather large communities- we have a grand opening scheduled for next week so it's really important that this gets solved ASAP.

The game runs fine in singleplayer, but when trying to run as a server using a hosting website, I've run into quite a massive error log. I've whittled it down to this point- I'm currently not sure what to do, as I believe the main error is relating to the datapack message, but I don't know for sure. Removing the datapack folder doesn't change the message either.

https://mclo.gs/2aTdXII

If the fix is something very simple, I apologize. I'm not too experienced with hosting websites and running large modpacks like this on a server.
I'm also not completely sure of which mods are client-only- a large handful of which are already disabled but I could be missing some. I just don't know which ones they would be, if that's causing the issue.

By nyxxiea · Posted 11 hours ago11 hr

Sign In

1.12.2 fluid registry issues

Featured Replies

Posts

New Forum Design/Update: Issues and Suggestions

Trying to boot MC Eternal 2 Server, works on linux not on Windows 11: Jvm args error

Trying to boot MC Eternal 2 Server, works on linux not on Windows 11: Jvm args error

NEED HELP ASAP - Failed to load datapacks, can't proceed with server load. You can either fix your datapacks or reset to vanilla

NEED HELP ASAP - Failed to load datapacks, can't proceed with server load. You can either fix your datapacks or reset to vanilla

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)