Jump to content

Recommended Posts

Posted

Hello, I'm trying to cancel a death event if player has the item in his inventory however the event is not cancelled even if using

System.out.println(e.isCancelable() + " < cancellabe | cancelled > " + e.isCanceled());

After "e.setCancelled(true);" gives me true for both I keep dying without have the item removed from the inventory.

Here's my DeathEvent:

@EventBusSubscriber
public class EntityDeath {

	@SubscribeEvent(priority = EventPriority.HIGHEST)
	@Mod.EventHandler
	public void onEntityDeath(LivingDeathEvent e) {
		World world = e.getEntity().getEntityWorld();
		if (world.isRemote) {
			return;
		}
		if (!world.isRemote) {
			if (e.getEntityLiving() instanceof EntityPlayer) {
				EntityPlayerMP mp = (EntityPlayerMP) e.getEntity();
				ItemStack pixie = new ItemStack(InitItems.PIXIE);
				FoodStats food = mp.getFoodStats();
				if (mp.inventory.hasItemStack(pixie)) {
					System.out.println(e.isCancelable() + " < cancellabe | cancelled > " + e.isCanceled());
					e.setCanceled(true);
					System.out.println(e.isCancelable() + " < cancellabe | cancelled > " + e.isCanceled());
					mp.heal(20F);
					food.setFoodLevel(20);
					food.setFoodSaturationLevel(20);
					world.playSound(mp, mp.getPosition(), SoundEvents.BLOCK_ANVIL_BREAK, SoundCategory.BLOCKS, 1, 1);
					pixie.setCount(pixie.getCount() - 1);
				}
			}
		}
	}
}
Posted
7 minutes ago, X_Khan_X said:

After "e.setCancelled(true);" gives me true for both I keep dying without have the item removed from the inventory.

Here's my DeathEvent:

If I understand correctly your problem is that the Item isn't removed from your inventory.

7 minutes ago, X_Khan_X said:

ItemStack pixie = new ItemStack(InitItems.PIXIE);

This ItemStack does not equal the ItemStack in the inventory. SO

10 minutes ago, X_Khan_X said:

pixie.setCount(pixie.getCount() - 1);

This does nothing. You should use one of the removal methods.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted
Just now, Animefan8888 said:

If I understand correctly your problem is that the Item isn't removed from your inventory.

This ItemStack does not equal the ItemStack in the inventory. SO

This does nothing. You should use one of the removal methods.

The code above pass the "if player has the item in the inventory" check, I mean after

if (mp.inventory.hasItemStack(pixie)) {

I added a System.out.println with random text and it is printed.

 

Posted
Just now, X_Khan_X said:

The code above pass the "if player has the item in the inventory" check, I mean after


if (mp.inventory.hasItemStack(pixie)) {

I added a System.out.println with random text and it is printed.

Yes I understand that. The problem is that it isn't removed from the player's inventory right? The problem is

16 minutes ago, X_Khan_X said:

ItemStack pixie = new ItemStack(InitItems.PIXIE);

This ItemStack does not equal the ItemStack in the inventory. SO 

16 minutes ago, X_Khan_X said:

pixie.setCount(pixie.getCount() - 1);

This does nothing. You should use one of the removal methods in the players inventory.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • "I want to understand how complex mods with ASM transformation and coremods work, such as Xray or AntiXray. Why do they break when you simply rename packages? What features of their architecture make refactoring difficult? And what techniques are used to protect these mods? I am interested in technical aspects in order to better understand the bytecode and Forge loader system."
    • I can't figure out if you're looking for help trying to steal someone elses work, or cheat at the game....
    • Title: Why Is It So Hard to Rename and Restructure Mods Like Xray or AntiXray? 🤔 Post text: Hey everyone! I’ve been digging into Minecraft modding for a while and have one big question that I can’t figure out on my own. Maybe someone with more experience could help or give me some advice. Here’s the issue: When I take a “normal” Minecraft mod — for example, one that just adds some blocks or new items — I can easily change its structure, package names, or even rebrand it entirely. It’s straightforward. But as soon as I try this with cheat-type mods like XrayMod or AntiXray, everything falls apart. Even if I just rename the classes, refactor the packages, or hide its identity somehow, the mod either breaks or stops working properly. XrayMod in particular is proving to be a nightmare to modify without losing its core function. So my question is — why is this so much harder with cheat mods like Xray? Is there something fundamentally different about how they’re coded, loaded, or protected that prevents simple renaming or restructuring? And if so, how can I actually learn to understand someone else’s cheat mod enough to safely refactor it without breaking the core features? I’ve already been spending over two months trying to figure this out and haven’t gotten anywhere. It feels like there must be some trick or knowledge I’m missing. Would really appreciate any thoughts, tips, or references — maybe there are guides or techniques for understanding cheat-mod internals? Or if you’ve successfully “disguised” a cheat mod like Xray before, I’d love to hear how you did it. Thanks in advance for any help or discussion. ✌️
    • just started making cinamatic contect check it out on my channel or check out my facebook page    Humbug City Minecraft Youtube https://www.youtube.com/watch?v=v2N6OveKwno https://www.facebook.com/profile.php?id=61575866982337  
    • Where did you get the schematic? Source/Link? And do use an own modpack or a pre-configured from curseforge? If yes, which one On a later time, I can make some tests on my own - but I need the schematic and the modpack name
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.