Jump to content

Recommended Posts

Posted (edited)

I am currently having an issue with my custom dimension. In my dimension, i would really like having some fog which would allow you to see about 7 blocks far. My issue is that it does not want to work.

@SubscribeEvent(priority = EventPriority.NORMAL, receiveCanceled = true)
	public static void onFogDensityEvent(EntityViewRenderEvent.FogDensity event) {
		System.out.println("Event succesfully fired");
	    event.setDensity(1F);
	    event.setCanceled(true);
	}

I added the code above to the world provider of my dimension but it doesn't change anything. Is it just supposed to go somewhere else then the world provider or is something wrong with the code itself. BTW, the code is properly formatted on eclipsis, just not above for some reason.

 

 

Edit: This is for 1.12.2, just incase.

Edited by nachsor
Posted

I am not sure what you mean by i am mixing tabs and spaces but to answer your question, the event is not being fired. I am unable to see any sort of text being show in the log other then what eclipse usually says.

Posted
  On 9/30/2019 at 10:06 PM, nachsor said:

I am not sure what you mean by i am mixing tabs and spaces

Expand  

He means your indentation is a mix of pressing tab and using spaces. Pick one and love it like a wife or husband.

 

  On 9/30/2019 at 10:06 PM, nachsor said:

the event is not being fired.

Expand  

How are you registering it?

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted

Ok, so. I made an event handler for it. Although, when i register it in my main class(i tried the PreInit, Init and postInit) it crashes. Where would i need to register it for it to work. What i used to register it BTW is

MinecraftForge.EVENT_BUS.register(FogEventHandler.instance);

FogEventHandler being my event handler as the name suggests.

Posted
  On 9/30/2019 at 10:40 PM, nachsor said:

it crashes

Expand  

What type of crash? Could it be that you never assign a value to FogEventHandler.instance?

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted

Yeah woops, it is the case. I actualy forgot to add the@Instance tag to the instance variable. Although i think that might be part of the issue(which now that i think about it, what actually is the purpose of the Instance tag?), it does still crash. Should i include my code, maybe that would help?

Posted
  On 9/30/2019 at 11:23 PM, nachsor said:

Should i include my code, maybe that would help?

Expand  

Yes 100% more.

 

  On 9/30/2019 at 11:23 PM, nachsor said:

which now that i think about it, what actually is the purpose of the Instance tag?

Expand  

It provides an instance of the @Mod class it refers to. 

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted
  On 9/30/2019 at 11:28 PM, Animefan8888 said:

It provides an instance of the @Mod class it refers to. 

Expand  

Ok so essentially, it creates an instance. Good to know, thank you for the clarrification :D

 

As for the files, i will have to include them as code because i do not have a github repo yet. I will make sure to create one ASAP.

 

For now, Here is my Main class.

package skely.mod;

import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.item.ItemStack;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.Mod.Instance;
import net.minecraftforge.fml.common.SidedProxy;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPostInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;
import skely.mod.init.BlockInit;
import skely.mod.init.ItemInit;
import skely.mod.init.RUCreativeTabs;
import skely.mod.init.Smelting;
import skely.mod.proxy.CommonProxy;
import skely.mod.util.References;
import skely.mod.util.handlers.FogEventHandler;
import skely.mod.util.handlers.RegistryHandler;

@Mod(modid = References.MODID, name = References.NAME, version = References.VERSION)
public class Main {
	public static CreativeTabs RUTab = new RUCreativeTabs("RUTab");
	
	@Instance
	public static Main instance;
	
	@SidedProxy(clientSide = References.CLIENT, serverSide = References.COMMON)
	public static CommonProxy proxy;
	
	@EventHandler
	public static void preInit(FMLPreInitializationEvent event) {
		RegistryHandler.otherRegistries();
		MinecraftForge.EVENT_BUS.register(FogEventHandler.instance);
	}
	
	@EventHandler
	public static void init(FMLInitializationEvent event) {
		Smelting.init();
	}
	
	@EventHandler
	public static void postInit(FMLPostInitializationEvent event) {
	}
}

 

 

The Dimension.

 

package skely.mod.world.dimmension.abyss;

import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraft.util.math.Vec3d;
import net.minecraft.world.DimensionType;
import net.minecraft.world.WorldProvider;
import net.minecraft.world.biome.BiomeProviderSingle;
import net.minecraft.world.gen.IChunkGenerator;
import net.minecraftforge.client.event.EntityViewRenderEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.eventhandler.EventPriority;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;
import skely.mod.init.BiomeInit;
import skely.mod.init.DimmensionInit;

public class DimmensionTheAbyss extends WorldProvider{
	public DimmensionTheAbyss() {
		this.biomeProvider = new BiomeProviderSingle(BiomeInit.ABYSSAL_VOID_DIMENSION);
	}

	@Override
	public DimensionType getDimensionType() {
		return DimmensionInit.ABYSS;
	}
	
	@Override
	public IChunkGenerator createChunkGenerator() {
		return new ChunkGeneratorAbyss(world, true, world.getSeed());
	}
	
	@Override
	public boolean canRespawnHere() {
		return true;
	}
	
	@Override
	public boolean isSurfaceWorld() {
		return false;
	}
	
	@Override
	public Vec3d getFogColor(float a, float b) {
		return new Vec3d((long)0,(long)0,(long)0);
	}
	
	@Override
	@SideOnly(Side.CLIENT)
    public boolean doesXZShowFog(int x, int z)
    {
        return true;
    }
	
	@Override
	public void onPlayerAdded(EntityPlayerMP player){
		
	}
	
	@SubscribeEvent(priority = EventPriority.NORMAL, receiveCanceled = true)
	public static void onFogDensityEvent(EntityViewRenderEvent.FogDensity event) {
		System.out.println("Event succesfully fired");
	    event.setDensity(1F);
	    event.setCanceled(true);
	}

}

 

And the event handler.

 

package skely.mod.util.handlers;

import net.minecraftforge.client.event.EntityViewRenderEvent;
import net.minecraftforge.fml.common.Mod.Instance;
import net.minecraftforge.fml.common.eventhandler.EventPriority;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

public class FogEventHandler {
	
	@Instance
	public static FogEventHandler instance;
	
	@SubscribeEvent(priority = EventPriority.NORMAL, receiveCanceled = true)
	public static void onFogDensityEvent(EntityViewRenderEvent.FogDensity event) {
		System.out.println("Event succesfully fired");
	    event.setDensity(1F);
	    event.setCanceled(true);
	}
}

 

Posted
  On 9/30/2019 at 11:33 PM, nachsor said:

Ok so essentially, it creates an instance. Good to know, thank you for the clarrification :D

Expand  

No it does not create an instance. It provides the mod developer with the instance of there @Mod class.

  On 9/30/2019 at 11:33 PM, nachsor said:

@Instance public static FogEventHandler instance;

Expand  

This won't work for reasons I've stated above you might as well make it a final field and do new ClassName()

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted

Ok, sorry for the delayed response, i had to go for a while but anyways. I have changed it to

 

public static final FogEventHandler instance = new FogEventHandler()

 

The game does not crash anymore but it still doesn't get called sadly.

Posted
  On 10/1/2019 at 12:37 AM, nachsor said:

The game does not crash anymore but it still doesn't get called sadly.

Expand  

Your method is also static it needs to not be. 

  • Like 1

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted

I have resolved the issue. When registering the event bus with my instance variable, it said that it needed to be static. So i searched a bit more on the forge docs and found that i had missed something, I did not need the variable. I could just call the class directly and there we go, fog. :D

 

Thank you so much for your help, i could have searched for ages and not have found the answer. Thank you once again :D.

Posted

Well woops. I still have an issue actually. I thought i was done but i forgot to check the overworld, now that i did. I see that the overworld also has the fog. Is there a way  to make it appear only in my custom dimension? I did also notice that the event repeatedly fires, i know it is normal but is there a way to make it fire once and it fires when the player changes dimension? Because, the event repeatedly firing does cause quite a lot of lag. :|

Posted
  On 10/1/2019 at 7:48 PM, nachsor said:

Because, the event repeatedly firing does cause quite a lot of lag. 

Expand  

I doubt that it does, but it fires every frame as it needs to. Because the fog is rendered every frame. If it is lagging it's because the value you set the density to.

  On 10/1/2019 at 7:48 PM, nachsor said:

Is there a way  to make it appear only in my custom dimension?

Expand  

The event gives you access to an Entity the Entity knows what World it is in. The World knows what Dimension it represents. Think you can solve it from there.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted

Ok, so. I got the entity, i check the players current dimension and it works. Although, when you go to the overworld and back to the custom dimension, the fog is gone. I am confused by that.

 

@SubscribeEvent(priority = EventPriority.NORMAL, receiveCanceled = true)
	public static void onFogDensityEvent(EntityViewRenderEvent.FogDensity event) {
		if(event.getEntity().dimension == TheBalanceIDS.getAbyssID()) {
		    event.setDensity(0.4F);
		    event.setCanceled(true);
		    System.out.println(event.isCanceled());
		}else {
			event.setCanceled(false);
		}
		
	}

Is there anything i need to add the event?

Posted
  On 10/1/2019 at 10:00 PM, diesieben07 said:

Minecraft by default does not set the fog density. If you do set it, you basically have to undo the effects later. Look at where the event is fired in EntityRenderer#setupFog. It's pretty janky, but it can be worked around.

Expand  

I am not sure to understand what you mean.

 

  On 10/1/2019 at 10:00 PM, Animefan8888 said:

Triggers to what point?

Expand  

It just triggers the println. Made one say the density of the fog and another one say if the event is cancelled or not.

Posted
  On 10/1/2019 at 10:16 PM, diesieben07 said:

Have you looked at the method?

Do you understand basic OpenGL? If you tell OpenGL to use Fog Density X it will use that, until the end of time.

Since if you do not cancel that event, Minecraft's default logic will be applied, which does not set the fog density, your density will stick.

Expand  

Yes, I have looked at the method, although i do not understand anything within said method. And no, i do not understand basic OpenGL. Also, i do want the fog to only apply to my dimension specifically.

Posted
  On 10/1/2019 at 10:28 PM, nachsor said:

Yes, I have looked at the method, although i do not understand anything within said method. And no, i do not understand basic OpenGL. Also, i do want the fog to only apply to my dimension specifically.

Expand  

try experimenting with:

            GlStateManager.fogStart();
            GlStateManager.fogEnd();
            GlStateManager.fogDensity();

instead of:

		    event.setDensity(0.4F);
		    event.setCanceled(true);

inside your " if " checking if entity is in your dimension.
 

Posted
  On 10/2/2019 at 6:14 AM, Krevik said:

try experimenting with:

            GlStateManager.fogStart();
            GlStateManager.fogEnd();
            GlStateManager.fogDensity();

 

 

Expand  

Hmm... It doesn't seem to work. It says they are undefined in GlStateManager. There are a couple others but i do not think they do the same thing.

GlStateManager.enableFog();
GlStateManager.disableFog();
GlStateManager.setFogDensity(1F);

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Okay so I went to a different version of that mod and it booted right up, thank you
    • C:\Users\bruiser\curseforge\minecraft\Instances\Fazbear Remnants\essential\loader\stage1\launchwrapper\stage2.forge_1.12.2.jar: The process cannot access the file because it is being used by another process. Restart your system and test it again If there is no change, delete the mentioned essential folder or remove the mod essential
    • Does it work with newer versions? For 1.16.5 also make a test with Embeddium + Oculus as Optifine replacement
    • Looking for the best Temu coupon code $100 off? You’re in the right place! We’ve got the ultimate deal that helps you save big on your favorite items. Our exclusive ACS670886 Temu coupon code is perfect for shoppers in the USA, Canada, and Europe. Whether you're a new or existing customer, this code ensures you get maximum benefits. By using the Temu coupon $100 off, you can unlock exciting savings on Temu’s vast collection. Don’t miss this chance to claim your Temu 100 off coupon code today! What Is The Coupon Code For Temu $100 Off? Both new and existing customers can enjoy incredible benefits with our Temu coupon $100 off on the Temu app and website. This $100 off Temu coupon ensures huge savings for everyone! ACS670886 – Get a flat $100 off on selected purchases. ACS670886 – Unlock a $100 coupon pack for multiple uses. ACS670886 – Enjoy a $100 flat discount if you're a new customer. ACS670886 – Existing customers can claim an extra $100 promo code. ACS670886 – This $100 coupon is valid for shoppers in the USA and Canada. Temu Coupon Code $100 Off For New Users In 2025 New users can maximize their savings by applying our Temu coupon $100 off on the Temu app. This Temu coupon code $100 off unlocks amazing deals for first-time shoppers. ACS670886 – Get a flat $100 discount for new users. ACS670886 – Receive a $100 coupon bundle as a welcome offer. ACS670886 – Unlock up to $100 in coupons for multiple uses. ACS670886 – Enjoy free shipping to 68 countries. ACS670886 – Get an extra 30% off on any purchase as a first-time user. How To Redeem The Temu Coupon $100 Off For New Customers? Using the Temu $100 coupon is easy! Follow these steps to redeem your Temu $100 off coupon code for new users: Sign up on the Temu app or website. Browse and add your favorite items to the cart. Enter ACS670886 at checkout. See the $100 discount applied instantly. Complete your purchase and enjoy your savings! Temu Coupon $100 Off For Existing Customers Existing customers can also benefit from our exclusive Temu $100 coupon codes for existing users. Use this Temu coupon $100 off for existing customers free shipping deal and save more! ACS670886 – Get an extra $100 discount for existing users. ACS670886 – Enjoy a $100 coupon bundle for multiple purchases. ACS670886 – Receive a free gift with express shipping across the USA/Canada. ACS670886 – Grab an extra 30% off on top of existing discounts. ACS670886 – Avail free shipping to 68 countries. How To Use The Temu Coupon Code $100 Off For Existing Customers? Redeeming your Temu coupon code $100 off as an existing user is simple. Just follow these steps: Log in to your Temu account. Select your desired products and add them to your cart. Apply ACS670886 at checkout. Your Temu coupon $100 off code will be applied automatically. Confirm your order and enjoy massive savings! Latest Temu Coupon $100 Off First Order First-time buyers get the best deals with our Temu coupon code $100 off first order. This Temu coupon code first order ensures maximum savings. ACS670886 – Flat $100 discount for the first order. ACS670886 – Special $100 Temu coupon code for new customers. ACS670886 – Get up to $100 in coupons for multiple uses. ACS670886 – Free shipping to 68 countries. ACS670886 – Extra 30% off on any first-time purchase. How To Find The Temu Coupon Code $100 Off? Finding a Temu coupon $100 off is easy! Check out the Temu coupon $100 off Reddit section or follow these tips: Subscribe to the Temu newsletter for exclusive deals. Follow Temu’s official social media pages for the latest updates. Visit trusted coupon sites for verified and working codes. Is Temu $100 Off Coupon Legit? Yes, our Temu $100 Off Coupon Legit and verified! Wondering if the Temu 100 off coupon legit? Here’s why: The ACS670886 code is officially tested and confirmed. Valid for all customers in the USA, Canada, and Europe. No expiration date—use it anytime! How Does Temu $100 Off Coupon Work? The Temu coupon code $100 off first-time user works instantly upon applying at checkout. Simply enter the Temu coupon codes 100 off, and the discount is automatically deducted. How To Earn Temu $100 Coupons As A New Customer? To earn a Temu coupon code $100 off, sign up on Temu, make your first purchase, and refer friends. This 100 off Temu coupon code can be unlocked through special promotions. What Are The Advantages Of Using The Temu Coupon $100 Off? $100 discount on the first order $100 coupon bundle for multiple uses 70% discount on popular items Extra 30% off for existing customers Up to 90% off on selected products Free gifts for new users Free delivery to 68 countries Temu $100 Discount Code And Free Gift For New And Existing Customers Enjoy the Temu $100 off coupon code and get amazing benefits! Our $100 off Temu coupon code ensures huge savings. ACS670886 – $100 discount for the first order. ACS670886 – Extra 30% off on any item. ACS670886 – Free gift for new Temu users. ACS670886 – Up to 70% discount on all Temu items. ACS670886 – Free shipping in 68 countries including the USA and UK. Final Note: Use The Latest Temu Coupon Code $100 Off Using the Temu coupon code $100 off is the smartest way to save on Temu! Don’t wait—grab your discount now. Our Temu coupon $100 off is available for all customers, ensuring maximum savings. Get yours today! FAQs Of Temu $100 Off Coupon Q: How can I get the Temu $100 off coupon? A: Use code ACS670886 at checkout to claim your $100 discount. Q: Is the Temu $100 coupon valid for existing customers? A: Yes! Existing users can also apply ACS670886 and enjoy savings. Q: Does the Temu $100 off coupon have an expiration date? A: No, ACS670886 is valid indefinitely. Q: Can I use the Temu coupon on multiple orders? A: Yes! ACS670886 allows multiple redemptions. Q: Is the Temu $100 coupon applicable worldwide? A: Yes, it’s valid in the USA, Canada, Europe, and 68 other countries.
    • I tried both Vanilla and Optfine like you said, and both gave the same result. So I believe the issue is most likely with Minecraft in general and not Forge
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.