[Solved][1.14.4] Best way to modify blocks in vanilla trees ?

[LeBonCharlie]

I've added a custom trunk block to my mod and I'd like to replace all log blocks used in vanilla trees with that block. What would be the easiest way to achieve that ?

 

I've seen that some tree features, for example TreeFeature, have a constructor where you can input the blocks to use to generate the tree, so I can register custom trees quite easily, but then I would have to remove all the vanilla trees to all biomes (if that is even possible) and add the custom ones. Is that a good solution ?

Edited October 18, 2019 by LeBonCharlie

[jeffryfisher]

Some houses are built as if they have tree trunks laying horizontally. Do you want those logs replaced too (for appearances), or just living trees (for some behavior)?

[LeBonCharlie]

Oh I hadn't thought about that ! Exactly the second option

[Draco18s]

20 minutes ago, LeBonCharlie said:

Oh I hadn't thought about that ! Exactly the second option

Oof, good luck. I did work that tried to detect "living" trees and there are so many edge-cases its insane.

 

Does a tree that has the ground under it replaced by a lake count as "living"?

Does a tree growing on gravel count as "living"?

Do those 1-tall "bushes" in jungles count as "trees"?

Are dark oak trees 1 tree or 4?

Edited October 17, 2019 by Draco18s

[LeBonCharlie]

I don't actually want to "detect" the trees but make them generate with my custom blocks. But maybe you're suggesting that it's possible to let the Vanilla trees generate as so and then detect them and replace the blocks ?

[LeBonCharlie]

for my post to make more sense, my custom TrunkBlock propagates the destruction vertically, so that you'd only need to break one block to cut down a tree. With that conception the 2x2 trees are 4 trees. For that reason, and the fact that some trees (jungle, oak) have branches, i'll add a horizontal propagation

Edited October 17, 2019 by LeBonCharlie
error

[Draco18s]

1 hour ago, LeBonCharlie said:

and the fact that some trees (jungle, oak) have branches, i'll add a horizontal propagation

That horizontal propagation will also work for dark oak (but you'd probably still want all four base blocks "tree" root blocks).

 

Here's how I handled it:

https://github.com/Draco18s/HarderStuff/blob/master/src/main/java/com/draco18s/wildlife/util/TreeDataHooks.java#L338

[LeBonCharlie]

31 minutes ago, Draco18s said:

Here's how I handled it:

https://github.com/Draco18s/HarderStuff/blob/master/src/main/java/com/draco18s/wildlife/util/TreeDataHooks.java#L338

Thanks for the help, but this seems really complex for my needs... I'll keep looking. Really cool feature these aging trees though !

[Draco18s]

37 minutes ago, LeBonCharlie said:

Thanks for the help, but this seems really complex for my needs... I'll keep looking. Really cool feature these aging trees though !

Oh yeah, a lot of it isn't relevant, I just meant the one-or-two functions (down to line 395) for propagating upwards from the "root" and making sure to catch every log. That's also old 1.10 code, but basically all it does is look at blocks above and blocks adjacent (as well as 1-above the 8 adjacent positions). That code absolutely catches every log in all the vanilla tree types.

 

This function did the chunk scanning for generated trees (the task you've stated as still needing).

https://github.com/Draco18s/HarderStuff/blob/master/src/main/java/com/draco18s/wildlife/util/TreeCountGenerator.java#L55

But it's not perfect. There's all kinds of weird edge cases that are hard to detect correctly (like the aforementioned floating trees).

[LeBonCharlie]

Yeah I'll definitely take another look at it. I want to implement the fact that when you try to chop down a 5 blocks high tree, it takes 5 * log hardness. Right now, I implemented it as so in the TrunkBlock class:

 

@Override
  public float getBlockHardness(BlockState blockState, IBlockReader worldIn, BlockPos blockPos) {
  return localTreeHeight(worldIn, blockPos) * super.blockHardness;
}

When the destruction propagation *is vertical*, the tree size is easy to compute, but if I add horizontal/diagonal propagation, I have to make sure that I don't count any log twice, and I think that one of your methods could solve that problem !

 

But anyway, my main issue right now is to have the vanilla trees use my TrunkBlock instead of vanilla <wood>_LOG Block. I think I could manage it by creating a custom Feature tree for each occurring tree in the calls to Biome#addFeature and somehow replace all of these occurrences but I don't know how yet

Edited October 17, 2019 by LeBonCharlie
missing words lel

[Draco18s]

52 minutes ago, LeBonCharlie said:

but if I add horizontal/diagonal propagation, I have to make sure that I don't count any log twice, and I think that one of your methods could solve that problem !

That's mostly just creating a list or other Set that contains unique blockpos locations for each tree.

[LeBonCharlie]

41 minutes ago, Draco18s said:

That's mostly just creating a list or other Set that contains unique blockpos locations for each tree. 

Oh yeah right, I'll definitely do that, thanks !

 

1 hour ago, LeBonCharlie said:

I think I could manage it by creating a custom Feature tree for each occurring tree in the calls to Biome#addFeature and somehow replace all of these occurrences but I don't know how yet

Also, that worked ! It's pretty ugly but by exploring Biome#createDecoratedFeature, I managed to add the feature trees that I wanted.

 

Finally, the thing I had not taken into account was that vanilla leaves would not recognize my TrunkBlocks as block it can attach to and hence despawn! I guess it's the normal process to find a new problem each time one is solved

[LeBonCharlie]

12 hours ago, LeBonCharlie said:

Finally, the thing I had not taken into account was that vanilla leaves would not recognize my TrunkBlocks as block it can attach to and hence despawn!

For anyone interested, I fixed this by extending the data/minecraft/tags/blocks/logs.json file in my mod with my blocks ids.