Jump to content

[1.12] setting lightmaps for entities and blocks [Solved]


nil

Recommended Posts

The context depends on the context, naturally, but I think what you're looking for is generally going to be the BufferBuilder#lightmap() method, if you're using the Tessellator. Otherwise, more specific questioning would be appreciated.

Fancy 3D Graphing Calculator mod, with many different coordinate systems.

Lightweight 3D/2D position/vector transformations library, also with support for different coordinate systems.

Link to comment
Share on other sites

I have also been trying to figure this out to no avail. I had code that worked back in 1.7.10 but I don't know when it broke because I took a long hiatus from modding with only a few short returns in that time. I hope you can find something that would work for you. I have some code that could work, but is very inefficient and actually breaks lighting within 16 blocks of the entity.

Link to comment
Share on other sites

I'm trying to set lighting for a custom projectile entity.

18 hours ago, SerpentDagger said:

but I think what you're looking for is generally going to be the BufferBuilder#lightmap()

Is there somewhere i can check the correct usage of this? I can't decifer what int p_187314_1_ and int p_187314_2_ do / how i have to set them.

 

5 hours ago, saxon564 said:

I have some code that could work

Does this contain BufferBuilder#lightmap()?

Link to comment
Share on other sites

1 hour ago, nil said:

Is there somewhere i can check the correct usage of this? I can't decifer what int p_187314_1_ and int p_187314_2_ do / how i have to set them.

It's used within Minecraft's rendering code, one example being located within BlockFluidRenderer#renderFluid().

I personally haven't used it extensively, so I'm not the best one to try and explain this, but the two ints seem to correspond to brightness, and range from 0 to ~220. I think they're (u, v) coordinates on Minecraft's lightmap texture.

In the fluid class I pointed to earlier, though, they result from the manipulation of the value returned from IBlockProperties#getPackedLightmapCoords().

What I've done with them is contour 3D graphs, which is independent of the world's lighting, so I'm not sure how to do that myself. In my work, I used the first as a sort of "base" brightness, and manipulated the second to alter it from there. I don't know if that's the generally used method, though.

 

It's worth noting, in case you're unfamiliar with the Tessellator, that this method should be used in accordance with the vertex format at hand, which is something you should learn a little about if you haven't already.

Edited by SerpentDagger

Fancy 3D Graphing Calculator mod, with many different coordinate systems.

Lightweight 3D/2D position/vector transformations library, also with support for different coordinate systems.

Link to comment
Share on other sites

On 11/28/2019 at 9:30 PM, saxon564 said:

I did notice my last working code was actually in 1.12.2 and included entity lighting.

The method you use works almost perfectly, however, the lighting effect doesn't get removed even after the entity is long dead. Do you use any methods to clear the created lighting?

On 11/28/2019 at 1:12 AM, SerpentDagger said:

It's worth noting, in case you're unfamiliar with the Tessellator, that this method should be used in accordance with the vertex format at hand

I have never used a tessellator, are there any examples i can look at to get a better understanding of this? Also what do you mean by vertex format?

Link to comment
Share on other sites

7 minutes ago, nil said:

The method you use works almost perfectly, however, the lighting effect doesn't get removed even after the entity is long dead. Do you use any methods to clear the created lighting?

You need to call a block update for the block the chicken occupies when it dies. I handle that in the livingUpdate method at the end of the method by having a check for if the chicken is dead and running the code.

Link to comment
Share on other sites

1 hour ago, nil said:

The method you use works almost perfectly

Ah, in that case you need not worry about the Tessellator or BufferBuilder#lightmap(), they're applicable in different scenarios than the one you seem to be dealing with. Sorry about that.

 

1 hour ago, nil said:

I have never used a tessellator, are there any examples i can look at to get a better understanding of this? Also what do you mean by vertex format?

The Tessellator is a commonly used method of rendering things directly in the world. In using it, you first apply various settings using the GlStateManager, then add vertices into the Tessellator's buffer, draw the buffer with Tessellator#draw(), and then reset the necessary settings with the GlStateManager.

A VertexFormat is applied when beginning to add vertices to the buffer, and it dictates what information each vertex requires. For example: you might use DefaultVertexFormats#POSITION_COLOR, in which case you would need to add position information, followed immediately by color information, to the vertex you're building.

Some general information about how the Tessellator works can be found here, but it's a bit outdated, so you should refer to my answer here for exact steps. Here's a simple example, but that was back when I was just learning about this stuff, so I got the translation wrong (as explained in the answer I followed up with). The rest's fine.

 

Like I said, though, it seems you've got a different situation here, so that's mostly just in case you have an insatiable thirst for MInecraft rendering knowledge.

Fancy 3D Graphing Calculator mod, with many different coordinate systems.

Lightweight 3D/2D position/vector transformations library, also with support for different coordinate systems.

Link to comment
Share on other sites

On 12/3/2019 at 12:37 AM, saxon564 said:

You need to call a block update for the block the chicken occupies when it dies

I assume you mean  this.world.checkLightFor(EnumSkyBlock.BLOCK,new BlockPos((int) x, (int) y, (int) z));

 

The issue is that my entity is a projectile, which means that it creates light at loads of different x,y and z positions. So i tried to remove the light the following way:

        if (this.emitsLight)
        {
        	double x = 0;
        	double y = 0;
        	double z = 0;
        	if(hasPrevLight)
        	{
        		removeLight(x,y,z);
        	}
            	this.addLight(10);
            	x = this.posX;
            	y = this.lastTickPosY;
            	z = this.lastTickPosZ;
            	this.hasPrevLight = true;
        }

with hasPrevLight set to false when the entity is spawned and

	private void removeLight(double x, double y, double z)
	{
		this.world.checkLightFor(EnumSkyBlock.BLOCK,new BlockPos((int) x, (int) y, (int) z));
	}

Sadly this doesn't remove the lighting along the path.

Link to comment
Share on other sites

The lighting updates its previous position as it moves. Unless the entity, or in your case projectile, is moving at over 1 block per tick then you don't need to track the last position. If you really need to, you can check every block in the 3x3 cube centered around the chicken but the need for that would be very rare as that would mean the entity would go perfectly between the corners of 2 blocks and not touch a mutual block. Share your whole class so I can see what you have setup.

Link to comment
Share on other sites

21 minutes ago, nil said:

Since the class is rather large what would be the best way to share it here?

Github is the best way to share code. If you upload it correctly, the it will allow others to fork your code and try to do their own debugging to help you, as well as they won't have to ask you to also share other classes, as all your classes will be available.

Link to comment
Share on other sites

You are setting x y and z back to 0 every tick, so it doesn't matter how many times you set it, you are always going to update the block at 0, 0, 0. I would declare x y and z at the top of the class instead of the method, this way you won't reset them back to 0 every tick.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • As the title say, game suddenly crushed during the loading. I got this error message The game crashed whilst rendering overlay Error: java.lang.RuntimeException: null   And Here's the link of crash log bit.ly/3IcVUQG
    • Do these mods have incompatibles: Dynamic View[Forge] (by someaddon) Server Performance - Smooth Chunk Save[Forge/Fabric] (by someaddon) EdivadLib (by 3divad99) Krypton Reforged (by Anthxny) AttributeFix (by DarkhaxDev) Create Stuff & Additions (by Furti_Two) Cristel Lib (by Cristelknight) Resourceful Config (by ThatGravyBoat) Applied Cooking (by ItsSebastrn) Thermal Cultivation (by TeamCoFH) SuperMartijn642's Config Lib (by SuperMartijn642) Create: Bells & Whistles (by sudolev) Thermal Integration (by TeamCoFH) SebastrnLib (by ItsSebastrn) Farmer's Delight (by vectorwing) Right Click, Get Crops (by TeamCoFH) Observable (by tasgon) FPS optimizer (by The_TCT) Dungeons and Taverns (by Nova_Wostra) Explorify – Dungeons & Structures (by bebebea_loste) Fast Leaf Decay (by olafskiii) Create: Vintage Improvements (by Negodya1) Sophisticated Backpacks (by P3pp3rF1y) SuperMartijn642's Core Lib (by SuperMartijn642) Create Crafts & Additions (by MRHminer) Structory (by botanydev) Oculus (by Asek3) Tectonic (by Apollo) Embeddium (Rubidium) Extra (by dimadencep) Athena (by CodexAdrian) Jade 🔍 (by Snownee) Mekanism Tools (by bradyaidanc) Carry On (by Tschipp) Create: Sweets & Treats (by AstralButOnCurseForge) Extreme Reactors Create Compat (by ZeroNoRyouki) AI Improvements (by QueenOfMissiles) AE2 QoL Recipes (by Christofmeg) Create: ComputerCraft (CC: Tweaked) (by EndRage) Create Enchantment Industry (by DragonsPlus) Macaw's Fences and Walls (by sketch_macaw) Better Villages - Forge (by jtl_elisa) Puzzles Lib [Forge & Fabric] (by Fuzs) Mekanism (by bradyaidanc) Create Recycle Everything (by nocubeyt) Searchables (by Jaredlll08) Immersive Paintings [Fabric/Forge] (by Conczin) Create Deco (by talrey) Thermal Foundation (by TeamCoFH) Controlling (by Jaredlll08) Kotlin for Forge (by thedarkcolour) Lithostitched (by Apollo) Let Me Despawn (by frikinjay) MCEF (Minecraft Chromium Embedded Framework) (by ds58) FPS Boost (by The_TCT) Ad Astra (by AlexNijjar) TerraBlender (Forge) (by TheAdubbz) Falling Leaves (Forge) (by Cheaterpaul) CC:C Bridge (by Sammy_echt) Xaero's Minimap (by xaero96) CoFH Core (by TeamCoFH) Create: Applied Kinetics (by Forsteri123) AE Additions - ExtraCells2 Fork (by MasterYodAT9G) Just Enough Items (JEI) (by mezz) Biomes O' Plenty (by Forstride) Curios API (Forge/NeoForge) (by TheIllusiveC4) AE2 Network Analyser (by GlodBlock) Resourceful Lib (by ThatGravyBoat) ChoiceTheorem's Overhauled Village (by ChoiceTheorem) Clockwork: Create x Valkyrien Skies (by triode_) Architectury API (Fabric/Forge/NeoForge) (by shedaniel) Canary (by AbdElAziz333) Structure Essentials[Forge/Fabric] (by someaddon) Library Ferret - Forge (by jtl_elisa) Create Confectionery (by Furti_Two) Leaky - Farm leak detection[Forge/Fabric] (by someaddon) Game Menu Mod Option [Forge] (by morimori0317) Macaw's Bridges (by sketch_macaw) FramedBlocks (by XFactHD) Cherished Worlds (Fabric/Forge/NeoForge/Quilt) (by TheIllusiveC4) Entangled (by SuperMartijn642) Refined Storage: Requestify (by Buuz135) ME Requester (by Relentless) Inventory Sorter (by cpw) Xaero's World Map (by xaero96) William Wythers' Expanded Ecosphere (by Cristelknight) Cloth Config API (Fabric/Forge/NeoForge) (by shedaniel) FTB Library (Forge) (by FTB) Cupboard (by someaddon) Thermal Dynamics (by TeamCoFH) Patchouli (by Vazkii) Entity Culling Fabric/Forge (by tr7zw) Chipped (by terrariumearth) FTB XMod Compat (by FTB) FerriteCore ((Neo)Forge) (by malte0811) Extra Disks (by MelanX) Nature's Compass (by Chaosyr) Thermal Locomotion (by TeamCoFH) TexTrue's Embeddium Options (by TexTrue) Traveler's Backpack (by Tiviacz1337) Geophilic – Vanilla Biome Overhauls (by bebebea_loste) Create: Power Loader (by Lysine) Polymorph (Fabric/Forge/Quilt) (by TheIllusiveC4) Enlightend (by lixir) Create Central Kitchen (by DragonsPlus) Energy Meter (by Relentless) Botarium (by CodexAdrian) FTB Teams (Forge) (by FTB) Storage Drawers (by Texelsaur) Create: Extended Cogwheels (by Rabbitminers) Embeddium/Rubidium Dynamic Lights (by Anthxny) Biome Makeover (Forge) (by Lemonszz) Create Guardian Beam Defense (by ibarnstormer_) Create: The Factory Must Grow (by Dr_Mango_Tea) Create Chunkloading (by embeddedt) Balm (Forge Edition) (by BlayTheNinth) Glodium (by GlodBlock) Thermal Expansion (by TeamCoFH) Chunk-Pregenerator (by Speiger) Advanced Peripherals (by srrendi) Create: Garnished (by DakotaPrideModding) Tidal Towns (by joshieman) Easy Magic [Forge & Fabric] (by Fuzs) Extreme Reactors (by ZeroNoRyouki) Applied Energistics 2 Wireless Terminals (by Mari_023) Redstone Arsenal (by TeamCoFH) ExtraStorage (by 3divad99) Thermal Innovation (by TeamCoFH) Collective (by Serilum) Wizard's Reborn (by MaxBogomol) GraveStone Mod (by henkelmax) Mekanism Additions (by bradyaidanc) Create: New Age (by nilBlade) Refined Storage (by raoulvdberge) Embeddium/Rubidium Extras (by Anthxny) ZeroCore 2 (by ZeroNoRyouki) Mekanism Generators (by bradyaidanc) WebDisplays (by ds58) Clumps (by Jaredlll08) Vein Mining (Fabric/Forge/Quilt) (by TheIllusiveC4) Villager Names (by Serilum) Create Slice & Dice (by possible_triangle) Embeddium (by embeddedt) Create: Steam 'n' Rails (by mattentosh) Get It Together, Drops! (by bl4ckscor3) Sophisticated Core (by P3pp3rF1y) Supplementaries (by MehVahdJukaar) Jade Addons (Forge) (by Snownee) Create: Design n' Decor (by MilkyFur) Construction Wand (by ThetaDev) Create: Diesel Generators (by george8188262) Create : Misc & Things (by to0pa_fr) Valkyrien Skies (Forge/Fabric) (by triode_) Refined Storage Addons (by raoulvdberge) FTB Chunks (Forge) (by FTB) FTB Ranks (Forge) (by FTB) Moonlight Lib (by MehVahdJukaar) CC: Tweaked (by SquidDev) Waystones (by BlayTheNinth) Applied Energistics 2 (by thetechnici4n) Trowels fork (by Luciano_cz) Cooking for Blockheads (by BlayTheNinth) Create (by simibubi) Towns and Towers (by Biban_Auriu)
    • Hi, you guys are probably all tired of having to deal with the same topic everytimes. I want to play mods, but forge doesn't want me to. And after days of videos and forum, i have no choices to ask before giving up.. The classic Error code 1 ( here's my debug.log : https://paste.ee/p/0WMSP). I tryed everything. The Forge version fit the mod version. I have java jdk 17 and the path to java is set. My mods folder is empty. My Minecraft luncher path has been changed. Java, Minecraft and Forged has been reinstalled 3 times. I tryed with the curseforge luncher. The only thing i didn't do, and I think it might be the problem, is updating my graphic card drivers. For the only reason that my computer is an Ace Magician ( Tiny pc) that don't have a graphic card. But then I went with Fabric. And it works just fine.  Anyway I can't find anything so thank you for your help. Sorry for my english if there's any mistake. Razziel.  
    • I am trying to make my own modpack and at the moment it crashes before I can get to the main menu. I have been trying to google and figure it out myself but would really appreciate some help. I've been using CurseForge to install mod and think I've gotten all the dependencies but I'm not 100% sure. I hope I got the paste.ee thing right Thanks in advance! https://paste.ee/p/NXdSO
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.