[FIXED] [1.14.4] How to make item stay in the crafting grid?

[Xander402]

I know what a containerItem is, but can this field be somehow utilized in order to make the item stay in the crafting grid? It's not about returning some empty bottle from recipe that requires a bottled substance. It's about a knife staying untouched after crafting something with it.

I tried two things:

package ...

import ...

public class UtilityItem extends Item {

    public UtilityItem(Properties p_i48487_1_) {
        super(p_i48487_1_);
    }

    @Override
    public ItemStack getContainerItem(ItemStack itemStack) {
        return new ItemStack(this);
    }
}

with regular initialization, and

    // In item init
    public static Item knife = new Item(new Item.Properties().group(SushiMod.TOOLS_GROUP)).setRegistryName(rloc("knife"));
    static {
        knife = new Item(new Item.Properties()
                .containerItem(knife)
                .group(SushiMod.TOOLS_GROUP)).setRegistryName(rloc("knife"));
    }

...which I actually didn't think through. The first had no effect and the second made the knife turn into a purple-black-checked block.minecraft.air item after crafting.

Edited November 29, 2019 by Xander402

[Xander402]

Some mods apply damage to a tool item when it's used to craft something. That suggests me that I'd need to use something different than containerItem. But what?

[Xander402]

3 minutes ago, diesieben07 said:

The 2nd makes zero sense:

• Don't create items in a static initializer.
• You assign a value to the knife field, only to immediately overwrite it... with an almost identical value.
• It's unknown if you register this Item anywhere, probably you didn't, which is why it did not work. All Items must be created and registered in the appropriate registry events.

Yes, I know it's stupid. ? I was aware of this when writing that post.

Edited November 29, 2019 by Xander402

[Xander402]

Oh, well,

Quote

That suggests me that I'd need to use something different than containerItem. 

I was wrong.

11 minutes ago, diesieben07 said:

7 hours ago, Xander402 said:

getContainerItem

Overriding this has no effect if you do not also override hasContainerItem.

That makes sense. The item stays in crafting table after overriding hasContainerItem. Thanks!

[Xander402]

2 hours ago, Xander402 said:

Some mods apply damage to a tool item when it's used to craft something.

For somebody who would like to know how to do it, here's my solution:
 

import net.minecraft.item.IItemTier;
import net.minecraft.item.ItemStack;
import net.minecraft.item.SwordItem;

public class KnifeItem extends SwordItem {

    public KnifeItem(IItemTier p_i48460_1_, int p_i48460_2_, float p_i48460_3_, Properties p_i48460_4_) {
        super(p_i48460_1_, p_i48460_2_, p_i48460_3_, p_i48460_4_);
    }

    @Override
    public boolean hasContainerItem(ItemStack stack) {
        return true;
    }

    @Override
    public ItemStack getContainerItem(ItemStack itemStack) {
        ItemStack ret = new ItemStack(this);
        ret.setDamage(itemStack.getDamage() + 1);
        return ret;
    }
}

 

[Draco18s]

3 hours ago, Xander402 said:

ret.setDamage(itemStack.getDamage() + 1);

You should use the tryDamageItem() method(s) instead so that your knife can take (and be affected by) the Unbreaking enchantment.

[Xander402]

Yeah, you're right. I totally didn't think about Unbreaking, because this knife is intended to be just a kitchen tool. Although I'm not gonna take away a possibility to use this item as a full-fledged weapon.
Just it is attemptDamageItem(), not tryDamageItem().

Edited November 29, 2019 by Xander402

[Draco18s]

5 hours ago, Xander402 said:

attemptDamageItem

That's the one. There's a dozen dozen dozen methods that have had their names changed and I can't remember exactly the right thing.

[Xander402]

Yes, I know that. ? I don't blame you. I've been playing around with modding, adding some basic items and blocks ever since 1.9, and I had to deal with all the changes (not only in naming), too.

Quote

Just it is attemptDamageItem(), not tryDamageItem().

That's just for people who would potentially come to this post not willing to do research and expecting everything to be expounded exactly as it is.

Edited November 29, 2019 by Xander402