[Solved for igniting custom TNT] [1.14.4] add Dispense Behavior to vanilla item

[TheOnlyTrueEnte]

Solved for my specific issue! My TNT just needed to override IForgeBlock#catchFire.

 

Hi there,

My mod adds new types of TNT and I would like Dispensers to be able to prime them with vanilla Flint and Steel.

My problem is that DispenserBlock#registerDispenseBehavior(item, behavior) puts the specified behavior in a map with item as the key so if I register a new Behavior for Items.FLINT_AND_STEEL, the old vanilla behavior and/or behavior that another mod might have added gets overridden. Is there another way of doing it? I haven't found any sort of Dispenser event or Redstone event (although a Redstone event probably wouldn't work because I also need the exact slot of the dispenser that is being used).

Cheers,

TheOnlyTrueEnte

Edited November 29, 2019 by TheOnlyTrueEnte
solution for my specific issue

[Xander402]

Have you made your custom TNTs class(es) extend net.minecraft.block.TNTBlock?

Edited November 29, 2019 by Xander402

[TheOnlyTrueEnte]

5 hours ago, Xander402 said:

Have you made your custom TNTs class(es) extend net.minecraft.block.TNTBlock?

No. If my TNT extends TNTBlock, dispensing Flint and Steel onto it will just spawn a vanilla TNTEntity. Here's an excerpt from IDispenseItemBehavior#init, of the OptionalDispenseBehavior for FLINT_AND_STEEL:

if (blockstate.getBlock() instanceof TNTBlock) {
	TNTBlock.explode(world, blockpos);
    world.removeBlock(blockpos, false);
}

TNTBlock#explode is obviously a static method here so I can't do anything to sort of override it.

 

EDIT: as of 1.14.4-28.1.92, this calls blockstate.catchFire which my TNT block can override.

Edited November 29, 2019 by TheOnlyTrueEnte
I had the wrong version

[Choonster]

21 minutes ago, TheOnlyTrueEnte said:

No. If my TNT extends TNTBlock, dispensing Flint and Steel onto it will just spawn a vanilla TNTEntity. Here's an excerpt from IDispenseItemBehavior#init, of the OptionalDispenseBehavior for FLINT_AND_STEEL:

if (blockstate.getBlock() instanceof TNTBlock) {
	TNTBlock.explode(world, blockpos);
    world.removeBlock(blockpos, false);
}

TNTBlock#explode is obviously a static method here so I can't do anything to sort of override it.

 

This should have been fixed by this PR (merged in Forge 1.14.4-28.1.92). The dispense behaviour now checks for any flammable block and calls Block#catchFire instead of calling the static method.

Edited November 29, 2019 by Choonster

[TheOnlyTrueEnte]

3 minutes ago, Choonster said:

 

This should have been fixed by this PR (merged in Forge 1.14.4-28.1.92).

You're right, I should have checked the new version first. Thank you.

Just out of curiosity though and since I might add more Dispense behaviors in the future, is there a way to actually add Dispense functionality to an already registered block?

[Choonster]

2 hours ago, TheOnlyTrueEnte said:

Just out of curiosity though and since I might add more Dispense behaviors in the future, is there a way to actually add Dispense functionality to an already registered block?

 

It should be possible to overwrite the existing behaviour simply by calling DispenserBlock.registerDispenseBehavior with your IDispenseItemBehavior. If you want to delegate to the existing behaviour, you'll need to use reflection to access DispenserBlock.DISPENSE_BEHAVIOR_REGISTRY and fetch the existing behaviour before overwriting it.