Hi

 

I got this item that stores a single stack of something else, and a glass variant of it should render the stack inside, but according to the docs I just need to set the renderer on the item and it should work but as far as I can see nothing happens, not even the console prints anything:

 

ItemSingleStackGlassContainer.java

public class ItemSingleStackGlassContainer extends ItemSingleStackContainer
{
    public ItemSingleStackGlassContainer(String name, float isolation, int tint)
    {
        super(new Item.Properties().setTEISR(() -> SingleStackGlassContainerItemRender::new),name,isolation,tint);
    }
...
}

 

The superclass:

ItemSingleStackContainer.java

public class ItemSingleStackContainer extends Item
{

    public static final ResourceLocation open = new ResourceLocation(Reference.MODID,"open");

    private final float isolation;
    private final int tint;

    private static short failedToOpen = 0;
    private boolean isOpen = false;

    public ItemSingleStackContainer(Item.Properties properties,String name, float isolation, int tint)
    {
        super(properties.maxStackSize(1).group(ItemGroup.TOOLS));

        if (isolation < 0 || isolation > 1) throw new IllegalArgumentException("Can only be between 0 and 1!");

        addPropertyOverride(open,(itemStack, worldIn, entityLivingBase) -> isOpen ? 1 : 0);

        this.isolation = isolation;
        this.tint      = tint;

        setRegistryName(name);
    }
  
    public static ItemStack getContainedItemStack(ItemStack stack)
    {
        IItemHandler handler = stack.getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY).orElseThrow(NullPointerException::new);
        return handler.getStackInSlot(0);
    }
  
...
}

 

The renderer that should just render the stack somewhere visible on the camera for now and print out to the console:

SingleStackGlassContainerItemRender.java

@OnlyIn(Dist.CLIENT)
public class SingleStackGlassContainerItemRender extends ItemStackTileEntityRenderer
{
    @Override
    public void renderByItem(ItemStack itemStackIn)
    {
        System.out.println("Rendering it I guess."); // Doesn't get printed out to the console.

        if (itemStackIn.getItem() instanceof ItemSingleStackGlassContainer) {

            ItemStack itemStack = ItemSingleStackContainer.getContainedItemStack(itemStackIn);


            if (itemStack != ItemStack.EMPTY) {
                GlStateManager.pushMatrix();

                Minecraft.getInstance().getItemRenderer().renderItem(itemStack, ItemCameraTransforms.TransformType.FIXED);

                GlStateManager.popMatrix();
            }
        }
    }
}

 

Edited December 7, 20195 yr by Simon_kungen
Forgot to add the static getContainedItemStack() function.

Looking at the doc it mentions it will not validate the new renderer if it does not have IBakedModel#isBuiltInRenderer set to true.

In order to use a TEISR, the Item must first satisfy the condition that its model returns true for IBakedModel#isBuiltInRenderer.
Once that returns true, the Item’s TEISR will be accessed for rendering. If it does not have one, it will use the default TileEntityItemStackRenderer.instance.

 

Which is most likely why it does not fire. The problem now is that I have no idea how to enable that. I can create a new class implementing IBakedModel but then I do not know how to have it applied on my item, and when to apply it to avoid server crash.

Hmm... nothing seems to be happening here. Is there some vanilla items that use TEISR I can look at? I can't find any which implies TEISR is a Forge addition to the game and not native to vanilla Minecraft.

Other mods I can find add their TEISR directly in the item constructor (which crashes the server). But doing the same I at least expect it to do something while in Single Player.

you can check there how I does it:

https://github.com/yanny7/StoneAge/blob/c9351e8050f6121256d587112a9f6071dbb61b11/src/main/java/com/yanny/age/stone/subscribers/BlockSubscriber.java#L57

it is working also for server side

Edited December 12, 20195 yr by Yanny7

21 hours ago, Yanny7 said:

you can check there how I does it:

https://github.com/yanny7/StoneAge/blob/c9351e8050f6121256d587112a9f6071dbb61b11/src/main/java/com/yanny/age/stone/subscribers/BlockSubscriber.java#L57

it is working also for server side

Umm, looks like you've done exactly as I did. Can you only attach it when you register an item and initializes it in the same line?

LARGE_GLASS_JAR = new ItemSingleStackGlassContainer(new Item.Properties().setTEISR(() -> () -> SingleStackGlassContainerItemRender.INSTANCE),"large_glass_jar",0.01f);

 

I register my items by creating a static variable and then add that variable to a list that registers all the entries when filled.