[1.14.4] [SOLVED] Crop .grow() / BlockState update confusion

[ojb]

I'm new to modding and I figured I'd play around a bit to try and get a handle on the functionality that exists already in the API. I'm implementing a simple TileEntity block that will (~every 20 ticks) apply a bonemeal effect to a crop directly in front of it. I think I have a slight misunderstanding of how BlockStates / Blocks can be updated. To illustrate this problem, I have:

 

• BlockPos cropPos -- the XYZ position of the crop block (e.g. the seeds/carrot/potato/etc)
• BlockState cropState -- the block state of that crop [obtained by world.getBlockState(cropPos)]. (Note: debugging shows it to have one property AGE_0_7 which I'm trying to update)
• CropsBlock crop -- a (verifiably legal/kosher) casting of cropState.getBlock()

 

Now, inside my TileEntity's tick() function (only on the server, not from a client), I attempt to call crop.grow(), which takes parameters (World, BlockPos, BlockState). Looking inside that API call it seems pretty straightforward: it updates the AGE property towards the maximum age allowed for the particular crop with one (randomized) bonemeal-esque update. It does that by calling something like world.setBlockState(... state.with(updatedAge)...).

 

Visually, the crop seems to grow just fine as it looks like the crop is growing over a short period of time in game. My debugging output will show that if I pull the BlockState of that position from the world after the grow() call, it has an AGE property larger than it started. But it's unfortunately not "real" growth and is just a visual lie: the crop is still only on stage one. This can be verified by breaking the crop when it is supposedly mature (it only gives a single seed, not the regular mature products), or right clicking it with an empty hand, which updates it visually to reveal that it is still just on the initial stage of growth. This is definitely a different effect than what bonemealing a seed does, which leads me to believe I'm not updating the right aspects of the crop block.

 

I believe this is me misunderstanding how BlockState updates can occur, so if anyone can enlighten me on what I'm missing it would be most appreciated.

Edited December 27, 2019 by ojb

[Draco18s]

I think your problem is that you've made the crop grow on the client side (and only the client side) while on the sever side of things, nothing's changed.

 

Show your code.

[ojb]

1 hour ago, Draco18s said:

I think your problem is that you've made the crop grow on the client side (and only the client side) while on the sever side of things, nothing's changed.

You're absolutely correct! I was a dummy and had it checking

if (world.isRemote())

instead of

if (!world.isRemote())

inside my tick() function with the grow updates. I guess I didn't read the docs too carefully and just assumed the isRemote flag was reversed. This change fixed my issue, and it works as I would expect. Thank you Draco!

[Draco18s]

1 hour ago, ojb said:

I guess I didn't read the docs too carefully and just assumed the isRemote flag was reversed.

This is why it has been renamed to isClient in 1.13+.

[Choonster]

12 hours ago, Draco18s said:

This is why it has been renamed to isClient in 1.13+.

 

It's still isRemote (and probably always will be), see this issue on the MCPBot issue tracker.

Edited December 28, 2019 by Choonster

[Draco18s]

40 minutes ago, Choonster said:

 

It's still isRemote (and probably always will be), see this issue on the MCPBot issue tracker.

Oh? Huh, thought I'd saw that it changed.

*shrug*