1.15 entity natural world spawn issue

[Hoping1]

This was originally posted in another thread but I think it makes much more sense as its own question. How do you register entity world spawns in 1.15.1? I looked through Cadiboo's tutorial but he hasn't gotten to that bit yet. The code I have is

public static void registerEntityWorldSpawn(EntityType<?> entity, Biome... biomes) {
  for (Biome biome : biomes) {
    if (biome != null) {
      biome.getSpawns(entity.getClassification()).add(new SpawnListEntry(entity, 10, 2, 10));
    }
  }
}

which is called as 

registerEntityWorldSpawn(HOP_MOB, Biomes.FOREST, Biomes.BIRCH_FOREST, Biomes.DARK_FOREST, Biomes.BIRCH_FOREST_HILLS, Biomes.DARK_FOREST_HILLS, Biomes.FLOWER_FOREST, Biomes.TALL_BIRCH_FOREST);

in a

@SubscribeEvent
public static void registerEntities(final RegistryEvent.Register<EntityType<?>> event) {}

which is itself in a 

@Mod.EventBusSubscriber(bus=Mod.EventBusSubscriber.Bus.MOD)
public static class RegistryEvents{}

Within my main mod class. Sorry for the odd format but it felt the cleanest way to share my code. I know enough java to know that it isn't some basic syntax error, and anyway, when I run it I don't get any errors. The issue is the mob doesn't spawn naturally at all. I can spawn it in fine with my custom spawn egg and it works perfectly, so the issue is only with natural world spawns. The method I'm using, as seen above, was taken from a 1.14 tutorial released in July 2019, so the reason it doesn't work definitely has to do with something specific to 1.15. That's all the useful info I have, unfortunately. And if I'm wrong in any of my assumptions please let me know. Thanks!

[Cadiboo]

6 hours ago, Hoping1 said:

if (biome != null) {

You really shouldn’t need this check.

Please show your full code or link a GitHub.

[Hoping1]

That line can't possibly be the reason it's broken unless I'm very confused about java. I got it from a tutorial but it makes sense to me. As for the full code, prepare for a wall of text:

EntitiesList.java

package com.hoping1.hopingmod.lists;

import com.hoping1.hopingmod.HopingMod;
import com.hoping1.hopingmod.entities.HopMob;

import net.minecraft.entity.EntityClassification;
import net.minecraft.entity.EntityType;
import net.minecraft.item.Item;
import net.minecraft.item.ItemGroup;
import net.minecraft.item.SpawnEggItem;
import net.minecraft.util.ResourceLocation;
import net.minecraft.world.biome.Biome;
import net.minecraft.world.biome.Biome.SpawnListEntry;
import net.minecraft.world.biome.Biomes;
import net.minecraftforge.event.RegistryEvent;

public class EntitiesList {
    public static EntityType<?> HOP_MOB = EntityType.Builder.create(HopMob::new, EntityClassification.CREATURE).build(HopingMod.modid+":hop_mob").setRegistryName(new ResourceLocation(HopingMod.modid, "hop_mob"));
    public static Item registerEntitySpawnEgg(EntityType<?> type, int color1, int color2, String name) {
        SpawnEggItem item = new SpawnEggItem(type, color1, color2, new Item.Properties().group(ItemGroup.MISC));
        item.setRegistryName(new ResourceLocation(HopingMod.modid, name));
        return item;
    }
    public static void registerEntitySpawnEggs(final RegistryEvent.Register<Item> event) {
        event.getRegistry().registerAll(
            ItemList.hop_mob_egg = registerEntitySpawnEgg(HOP_MOB, 0x00ffff, 0xaaffaa, "hop_mob_egg")
        );
    }
    public static void registerEntityWorldSpawn(EntityType<?> entity, Biome... biomes) {
        for (Biome biome : biomes) {
            if (biome != null) {
                biome.getSpawns(entity.getClassification()).add(new SpawnListEntry(entity, 1000, 2, 10));
            }
        }
    }
    public static void registerEntityWorldSpawns() {
        registerEntityWorldSpawn(HOP_MOB, Biomes.FOREST, Biomes.BIRCH_FOREST, Biomes.DARK_FOREST, Biomes.BIRCH_FOREST_HILLS, Biomes.DARK_FOREST_HILLS, Biomes.FLOWER_FOREST, Biomes.TALL_BIRCH_FOREST);
    }
}

 

HopingMod.java

package com.hoping1.hopingmod;

import org.apache.logging.log4j.Logger;

import com.hoping1.hopingmod.client.render.HopingRenderRegistry;
import com.hoping1.hopingmod.lists.ArmorMaterialList;
import com.hoping1.hopingmod.lists.BlockList;
import com.hoping1.hopingmod.lists.EntitiesList;
import com.hoping1.hopingmod.lists.ItemList;
import com.hoping1.hopingmod.lists.ToolMaterialList;
import com.hoping1.hopingmod.world.OreGeneration;

import org.apache.logging.log4j.LogManager;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.entity.EntityType;
import net.minecraft.item.ArmorItem;
import net.minecraft.item.BlockItem;
import net.minecraft.item.HoeItem;
import net.minecraft.item.Item;
import net.minecraft.item.ItemGroup;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent;
import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent;
import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext;
import net.minecraft.inventory.EquipmentSlotType;

@Mod("hopingmod")
public class HopingMod {
    public static HopingMod instance;
    public static String modid = "hopingmod";
    private static Logger logger = LogManager.getLogger(modid);
    public HopingMod() {
        instance = this;
        FMLJavaModLoadingContext.get().getModEventBus().addListener(this::setup);
        FMLJavaModLoadingContext.get().getModEventBus().addListener(this::clientRegistries);
        MinecraftForge.EVENT_BUS.register(this);
    };
    private void setup(final FMLCommonSetupEvent event) {
        OreGeneration.setupOreGeneration();
        logger.info("Setup method registered");
    };
    private void clientRegistries(final FMLClientSetupEvent event) {
        HopingRenderRegistry.registryEntityRenders();
        logger.info("clientRegistries method registered");
    }
    @Mod.EventBusSubscriber(bus=Mod.EventBusSubscriber.Bus.MOD)
    public static class RegistryEvents{
        @SubscribeEvent
        public static void registerItems(final RegistryEvent.Register<Item> event) {
            event.getRegistry().registerAll(
                ItemList.hoping_item = new Item(new Item.Properties().group(ItemGroup.MISC)).setRegistryName(location("hoping_item")),
                ItemList.hoping_hoe = new HoeItem(ToolMaterialList.hopingmod, 0.0f, new Item.Properties().group(ItemGroup.MISC)).setRegistryName(location("hoping_hoe")),
                ItemList.hoping_boots = new ArmorItem(ArmorMaterialList.hopingmod, EquipmentSlotType.FEET, new Item.Properties().group(ItemGroup.MISC)).setRegistryName(location("hoping_boots")),
                ItemList.hoping_block = new BlockItem(BlockList.hoping_block, new Item.Properties().group(ItemGroup.MISC)).setRegistryName(BlockList.hoping_block.getRegistryName()),
                ItemList.hoping_ore = new BlockItem(BlockList.hoping_ore, new Item.Properties().group(ItemGroup.MISC)).setRegistryName(BlockList.hoping_ore.getRegistryName()),
                ItemList.hoping_ore_nether = new BlockItem(BlockList.hoping_ore_nether, new Item.Properties().group(ItemGroup.MISC)).setRegistryName(BlockList.hoping_ore_nether.getRegistryName())
            );
            EntitiesList.registerEntitySpawnEggs(event);
            logger.info("Items registered");
        }
        @SubscribeEvent
        public static void registerBlocks(final RegistryEvent.Register<Block> event) {
            event.getRegistry().registerAll(
                BlockList.hoping_block = new Block(Block.Properties.create(Material.IRON).hardnessAndResistance(2.0f, 3.0f).lightValue(5)).setRegistryName(location("hoping_block")),
                BlockList.hoping_ore = new Block(Block.Properties.create(Material.ROCK).hardnessAndResistance(2.0f, 3.0f)).setRegistryName(location("hoping_ore")),
                BlockList.hoping_ore_nether = new Block(Block.Properties.create(Material.ROCK).hardnessAndResistance(2.0f, 3.0f)).setRegistryName(location("hoping_ore_nether"))
            );
            logger.info("blocks registered");
        }
        @SubscribeEvent
        public static void registerEntities(final RegistryEvent.Register<EntityType<?>> event) {
            event.getRegistry().registerAll(EntitiesList.HOP_MOB);
            EntitiesList.registerEntityWorldSpawns();
            logger.info("entities registered");
        }
        private static ResourceLocation location(String name) {
            return new ResourceLocation(modid, name);
        }
    }
}

 

No errors and absolutely everything works perfectly except that the HopMob entities don't spawn naturally. If you want code from other files just ask!

[DragonITA]

4 hours ago, Cadiboo said:

Please show your full code or link a GitHub

I think it would be better if you posted your code from github. Let me guess, you followed a tutorial from HarryTalks, right?

Edited January 21, 2020 by DragonITA

[Hoping1]

40 minutes ago, DragonITA said:

I think it would be better if you posted your code from github. Let me guess, you followed a tutorial from HarryTalks, right?

I don't have a github. And yes, that's the tutorial. Forge documentation is effectively useless and there aren't really any 1.15 tutorials except cadiboo's unfinished one

[Cadiboo]

7 hours ago, Hoping1 said:

That line can't possibly be the reason it's broken unless I'm very confused about java. I got it from a tutorial but it makes sense to me.

It’s not the reason it’s broken, it’s just useless code. This is your own internal method that you’re using - you never pass null into your method (and obviously shouldn’t) so the check is pointless. However, if you accidentally do pass null into this method (because an objectholder failed or you forgot to create a biome) you’re not going to want it to just fail silently - you’re going to want to know about it.

[Hoping1]

15 minutes ago, Cadiboo said:

However, if you accidentally do pass null into this method (because an objectholder failed or you forgot to create a biome) you’re not going to want it to just fail silently - you’re going to want to know about it.

Fair enough, I'll change it. Do you know what's wrong with my natural spawn algorithm?

[Hoping1]

Some console logs that I think might be pertinent, though I'm not a good enough modder to make anything useful out of them. You can see above the line in the HopingMod.java file where I log the logged message. The logs here look the same here as they do elsewhere, except of course for the logged message.

[m[36m[18:11:26] [Render thread/DEBUG] [ne.mi.fm.ModList/LOADING]: Dispatching synchronous event LifecycleEvent:LOAD_REGISTRIES
[m[36m[18:11:26] [Render thread/DEBUG] [ne.mi.fm.ja.FMLModContainer/LOADING]: Firing event for modid forge : RegistryEvent.Register<minecraft:enchantment>
[m[36m[18:11:26] [Render thread/DEBUG] [ne.mi.fm.ja.FMLModContainer/LOADING]: Fired event for modid forge : RegistryEvent.Register<minecraft:enchantment>
[m[36m[18:11:26] [Render thread/DEBUG] [ne.mi.fm.ja.FMLModContainer/LOADING]: Firing event for modid hopingmod : RegistryEvent.Register<minecraft:enchantment>
[m[36m[18:11:26] [Render thread/DEBUG] [ne.mi.fm.ja.FMLModContainer/LOADING]: Fired event for modid hopingmod : RegistryEvent.Register<minecraft:enchantment>
[m[36m[18:11:26] [Render thread/DEBUG] [ne.mi.re.GameData/REGISTRIES]: Applying holder lookups: minecraft:enchantment
[m[36m[18:11:26] [Render thread/DEBUG] [ne.mi.re.GameData/REGISTRIES]: Holder lookups applied: minecraft:enchantment
[m[36m[18:11:26] [Render thread/DEBUG] [ne.mi.fm.ModList/LOADING]: Dispatching synchronous event LifecycleEvent:LOAD_REGISTRIES
[m[36m[18:11:26] [Render thread/DEBUG] [ne.mi.fm.ja.FMLModContainer/LOADING]: Firing event for modid forge : RegistryEvent.Register<minecraft:entity_type>
[m[36m[18:11:26] [Render thread/DEBUG] [ne.mi.fm.ja.FMLModContainer/LOADING]: Fired event for modid forge : RegistryEvent.Register<minecraft:entity_type>
[m[36m[18:11:26] [Render thread/DEBUG] [ne.mi.fm.ja.FMLModContainer/LOADING]: Firing event for modid hopingmod : RegistryEvent.Register<minecraft:entity_type>
[m[32m[18:11:26] [Render thread/INFO] [hopingmod/]: entities registered
[m[36m[18:11:26] [Render thread/DEBUG] [ne.mi.fm.ja.FMLModContainer/LOADING]: Fired event for modid hopingmod : RegistryEvent.Register<minecraft:entity_type>

Can someone please help me?

[Cadiboo]

3 hours ago, Hoping1 said:

Fair enough, I'll change it. Do you know what's wrong with my natural spawn algorithm?

No, but I’m general static initialisers are bad and you shouldn’t use them. It’s unlikely that this is the cause of it, but you should fix it anyway (you’ll need to create your entity entry but not register it in your item registry event to register it’s spawn egg, then register it in the entity registry event). Have you tried looking at vanilla’s code to see how it gets a creature to spawn? Working back from that code should allow you see why yours isn’t working.

 

[Hoping1]

 

 

 

 

2

26 minutes ago, Cadiboo said:

No, but I’m general static initialisers are bad and you shouldn’t use them. It’s unlikely that this is the cause of it, but you should fix it anyway (you’ll need to create your entity entry but not register it in your item registry event to register it’s spawn egg, then register it in the entity registry event)

I'm confused. You mean don't register the spawn egg until the entity registry event?

 

28 minutes ago, Cadiboo said:

Have you tried looking at vanilla’s code to see how it gets a creature to spawn? Working back from that code should allow you see why yours isn’t working.

No, I haven't. Where do I find the vanilla code?

[Cadiboo]

1 hour ago, Hoping1 said:

I'm confused. You mean don't register the spawn egg until the entity registry event?

No.

Item Registry Event:

- Create EntityType
- Create and register Spawn Egg

EntityType Registry Event:
- Register EntityType

1 hour ago, Hoping1 said:

No, I haven't. Where do I find the vanilla code?

In External/Referenced Libraries in your IDE. I assume spawning entities would be in ServerWorld.

[Hoping1]

22 minutes ago, Cadiboo said:

No.

Item Registry Event:

- Create EntityType
- Create and register Spawn Egg

EntityType Registry Event:
- Register EntityType

I don't know if this is what you meant but I changed the code so it only declares the HOP_MOB in EntitiesList but doesn't set it to anything until the items registry event (shown below) and just for the heck of it I decided to run AND IT WORKED!! HopMobs are naturally spawning in my world now. THANK you so much, and I'm surprised that the code I took from a 1.14 tutorial is obsolete in that way, of all the possible ways, lol.

public class EntitiesList {
	public static EntityType<?> HOP_MOB;

and

@SubscribeEvent
public static void registerItems(final RegistryEvent.Register<Item> event) {
	event.getRegistry().registerAll(
		ItemList.hoping_item = new Item(new Item.Properties().group(ItemGroup.MISC)).setRegistryName(location("hoping_item")),
		ItemList.hoping_hoe = new HoeItem(ToolMaterialList.hopingmod, 0.0f, new Item.Properties().group(ItemGroup.MISC)).setRegistryName(location("hoping_hoe")),
		ItemList.hoping_boots = new ArmorItem(ArmorMaterialList.hopingmod, EquipmentSlotType.FEET, new Item.Properties().group(ItemGroup.MISC)).setRegistryName(location("hoping_boots")),
		ItemList.hoping_block = new BlockItem(BlockList.hoping_block, new Item.Properties().group(ItemGroup.MISC)).setRegistryName(BlockList.hoping_block.getRegistryName()),
		ItemList.hoping_ore = new BlockItem(BlockList.hoping_ore, new Item.Properties().group(ItemGroup.MISC)).setRegistryName(BlockList.hoping_ore.getRegistryName()),
		ItemList.hoping_ore_nether = new BlockItem(BlockList.hoping_ore_nether, new Item.Properties().group(ItemGroup.MISC)).setRegistryName(BlockList.hoping_ore_nether.getRegistryName())
	);
	EntitiesList.HOP_MOB = EntityType.Builder.create(HopMob::new, EntityClassification.CREATURE).build(HopingMod.modid+":hop_mob").setRegistryName(new ResourceLocation(HopingMod.modid, "hop_mob"));
	EntitiesList.registerEntitySpawnEggs(event);
	logger.info("Items registered");
}

Hopefully, this helps someone besides me, and again, thank you! You have no idea how long I've been looking for how to fix this lmao