Jump to content

Recommended Posts

Posted

I have an tile with an gui and I do all the calculations on the server side then I want to send the nbt data to the client. In another topic I saw someone using the SUpdateTileEntityPacket. This was an old topic from 1.11 and that doesn't work any more does someone have any idea?

 

PacketHandler.INSTANCE.send(PacketDistributor.ALL, this.getUpdatePacket());

This is what I tried but it can't see the getUpdatePacket as a MSG:
The method send(PacketDistributor.PacketTarget, MSG) in the type SimpleChannel is not applicable for the arguments (PacketDistributor<Void>, SUpdateTileEntityPacket)

Posted (edited)

Don’t send it yourself, vanilla will send the packet for you.

 

Edit: Yeah, if you only need it for the GUI there is a better way of doing it

Edited by Cadiboo

About Me

  Reveal hidden contents

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted
  On 1/28/2020 at 9:16 AM, diesieben07 said:

If the data is only needed in a GUI then that packet is the wrong choice. You would need to create your own packet for that case and only send it when then GUI is opened.

 

If the data is needed on the client in general, check out this:

 

Expand  

So you say that I need to send the notifyBlockUpdate but how would I get the old state and wich flag should I use?

Posted

Or should I use packets then I have the question: how would I get the client world in the handle:
 

private final BlockPos pos;
	private final int completed;
	
	public ResearchTableCompletedUpdatePacket(BlockPos pos, int completed) {
		this.pos = pos;
		this.completed = completed;
	}
	
	public static void encode(ResearchTableCompletedUpdatePacket msg, PacketBuffer buffer) {
		buffer.writeBlockPos(msg.pos);
		buffer.writeByte((byte)msg.completed);
	}
	
	public static ResearchTableCompletedUpdatePacket decode(PacketBuffer buffer) {
		return new ResearchTableCompletedUpdatePacket(buffer.readBlockPos(), buffer.readUnsignedByte());
	}
	
	public static void handle(ResearchTableTile msg, Supplier<NetworkEvent.Context> context) {
		context.get().enqueueWork(() -> {
			TileEntity te = **WORLD**.getTileEntity(msg.pos);
			if(te instanceof ResearchTableTile) {
				ResearchTableTile dtt = (ResearchTableTile) te;
				
			}
		});
		context.get().setPacketHandled(true);
	}

 

Posted (edited)
  On 1/28/2020 at 9:37 AM, diesieben07 said:

For which part of that GUI are you using the update packet? I don't see any reason to use it there.

Expand  
@Override
	public void tick() {
		if(world.isRemote) {//client
			//Fantasy20.LOGGER.info("ResearchTableTile.tick-client");
		} else {//server
			handler.ifPresent(h -> {
				second++;
				if(second > 19) {
					second = 0;
				//Fantasy20.LOGGER.info("ResearchTableTile.tick-server");
				if(currentRecipe == null) {
						if(h.getStackInSlot(INPUT_SLOT).getItem().equals(ModItems.SCRAP)) {
							ResearchTableRecipe recipe = ResearchTable.getRecipe(h.getStackInSlot(INPUT_SLOT_2));
							if(recipe != null) {
								if(h.getStackInSlot(INPUT_SLOT).getCount() >= recipe.getScrap()) {
									second = 0;
									timer = 0;
									completed = 0;
									currentRecipe = recipe.copy();
									markDirty();
									world.notifyBlockUpdate(pos, getBlockState(), getBlockState(), 2);
								}
							}
						}
				} else {
						if(h.getStackInSlot(INPUT_SLOT).getCount() < currentRecipe.getScrap() || !h.getStackInSlot(INPUT_SLOT_2).getItem().equals(currentRecipe.getInputItem())) {
							currentRecipe = null;
							second = 0;
							timer = 0;
							completed = 0;
							markDirty();
							world.notifyBlockUpdate(pos, getBlockState(), getBlockState(), 2);
						} else {
							timer++;
							//System.err.println(timer/100);
						//	System.err.println(timer/currentRecipe.getTime() * 100);
							if(timer > currentRecipe.getTime()) {
								h.extractItem(INPUT_SLOT, currentRecipe.getScrap(), false);
								h.extractItem(INPUT_SLOT_2, 1, false);
								h.insertItem(OUTPUT_SLOT, currentRecipe.getResultBlueprint(), false);
								//System.err.println(" " + currentRecipe.toString());
								
								currentRecipe = null;
								second = 0;
								timer = 0;
								completed = 0;
							}
							if(currentRecipe != null) {
								completed = (int)(((double)((double)timer/(double)currentRecipe.getTime())) * 100);
								//System.err.println(completed);
							}
							//PacketHandler.INSTANCE.send(PacketDistributor.ALL, this.getUpdatePacket());
							markDirty();
							world.notifyBlockUpdate(pos, getBlockState(), getBlockState(), 2);
						}
					}
				}
				});
		}
	}

In the tileentity
 

private ResearchTableTile tileEntity;
	private PlayerEntity playerEntity;
    private IItemHandler playerInventory;

	public ResearchTableContainer(int id, World world, BlockPos pos, PlayerInventory playerInventory, PlayerEntity playerEntity) {
		super(ModBlocks.RESEARCH_TABLE_CONTAINER, id);
		tileEntity = (ResearchTableTile) world.getTileEntity(pos);
		this.playerEntity = playerEntity;
        this.playerInventory = new InvWrapper(playerInventory);
        
		//tileEntity.getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY).ifPresent(h -> {
        tileEntity.getHandler().ifPresent(h -> {
            addSlot(new SlotItemHandler(h, tileEntity.INPUT_SLOT, 19, 33));
            addSlot(new SlotItemHandler(h, tileEntity.INPUT_SLOT_2, 55, 33));
            addSlot(new SlotItemHandler(h, tileEntity.OUTPUT_SLOT, 137, 33));
        });
        //});
        layoutPlayerInventorySlots(8, 83);
	}

	@Override
	public boolean canInteractWith(PlayerEntity player) {
		return isWithinUsableDistance(IWorldPosCallable.of(tileEntity.getWorld(), tileEntity.getPos()), playerEntity, ModBlocks.RESEARCH_TABLE);
	}
	
	 private int addSlotRange(IItemHandler handler, int index, int x, int y, int amount, int dx) {
        for (int i = 0 ; i < amount ; i++) {
            addSlot(new SlotItemHandler(handler, index, x, y));
            x += dx;
            index++;
        }
        return index;
    }

    private int addSlotBox(IItemHandler handler, int index, int x, int y, int horAmount, int dx, int verAmount, int dy) {
        for (int j = 0 ; j < verAmount ; j++) {
            index = addSlotRange(handler, index, x, y, horAmount, dx);
            y += dy;
        }
        return index;
    }

    private void layoutPlayerInventorySlots(int leftCol, int topRow) {
        // Player inventory
        addSlotBox(playerInventory, 9, leftCol, topRow, 9, 18, 3, 18);

        // Hotbar
        topRow += 58;
        addSlotRange(playerInventory, 0, leftCol, topRow, 9, 18);
    }
	
	public ResearchTableTile getTileEntity() {
		return tileEntity;
	}

	public void setTileEntity(ResearchTableTile tileEntity) {
		this.tileEntity = tileEntity;
	}

In the Container
 

private ResearchTableTile tileEntity;
    private ResourceLocation GUI = new ResourceLocation(Fantasy20.MODID, "textures/gui/research_table/gui.png");
	
	public ResearchTableScreen(ResearchTableContainer screenContainer, PlayerInventory inv, ITextComponent titleIn) {
		super(screenContainer, inv, titleIn);
		tileEntity = getContainer().getTileEntity();
	}
	
	@Override
	public boolean mouseDragged(double mouseX, double mouseY, int button,
			double mouseXVel, double mouseYVel) {
		return super.mouseDragged(mouseX, mouseY, button, mouseXVel,
				mouseYVel);
	}
	
	@Override
	public boolean mouseClicked(double mouseX, double mouseY, int button) {
		return super.mouseClicked(mouseX, mouseY, button);
	}
	
	@Override
	public boolean mouseReleased(double mouseX, double mouseY, int button) {
		return super.mouseReleased(mouseX, mouseY, button);
	}
	
	@Override
	public void mouseMoved(double mouseX, double mouseY) {
		super.mouseMoved(mouseX, mouseY);
	}
	
	@Override
	public void render(int mouseX, int mouseY, float partialTicks) {
		this.renderBackground();
		super.render(mouseX, mouseY, partialTicks);
		this.renderHoveredToolTip(mouseX, mouseY);
	}
	
	@Override
	protected void drawGuiContainerForegroundLayer(int mouseX, int mouseY) {
		this.font.drawString(this.title.getFormattedText(), 8.0F, 6.0F, 4210752);
	}

	@Override
	protected void drawGuiContainerBackgroundLayer(float partialTicks, int mouseX, int mouseY) {
		GlStateManager.color4f(1.0F, 1.0F, 1.0F, 1.0F);
		this.minecraft.getTextureManager().bindTexture(GUI);
		int relX = (this.width - this.xSize) / 2;
        int relY = (this.height - this.ySize) / 2;
        this.blit(relX, relY, 0, 0, this.xSize, this.ySize);
       // System.err.println(getContainer().getTileEntity().getCompleted());
        if(tileEntity.getCurrentRecipe() != null) {
        	int k = getCompletedLeft(24);
        	//System.err.println(k);
        	this.blit(relX + 91, relY + 33, 176, 0, k, 17);
        }
	}
	
	private int getCompletedLeft(int pixels) {
		int i = tileEntity.getCompleted();
		return (int)(((double)i / (double)100) * (double)pixels);
	}

In the screen

Edit: Its used for the completed int to see the progressbar in the gui
And I know that my code is a mess sometimes

Edited by DJ1TJOO
Anwser
Posted (edited)
  On 1/28/2020 at 9:54 AM, diesieben07 said:
  • Items do not need to be synchronized, they are synchronized by the Container infrastructure already.
  • Do not use notifyBlockUpdate for stuff that is needed only in the GUI, especially fast-updating things like the progressbar. notifyBlockUpdate is expensive. Use a custom packet or look at how the vanilla furnace synchronizes it's progressbar.
Expand  

Then what is the right way to do it
Edit: And how do I remove the disapearing of my items

Edited by DJ1TJOO
Question
Posted

About Me

  Reveal hidden contents

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Verified user can get a $300 off TℰℳU Coupon code using the code ((“{{ '[''com31844'']}}”)). This TℰℳU $100Off code is specifically for new and existing customers both and can be redeemed to receive a $100discount on your purchase. Our exclusive TℰℳU Coupon code offers a flat $100off your purchase, plus an additional 100% discount on top of that. You can slash prices by up to $100as a new TℰℳU customer using code ((“{{ '[''com31844'']}}”)). Existing users can enjoy $100off their next haul with this code. But that’s not all! With our TℰℳU Coupon codes for 2025, you can get up to 90% discount on select items and clearance sales. Whether you’re a new customer or an existing shopper, our TℰℳU codes provide extra discounts tailored just for you. Save up to 100% with these current TℰℳU Coupons ["^"{{ '[''com31844'']}} "^"] for April 2025. The latest TℰℳU coupon codes at here. New users at TℰℳU receive a $100discount on orders over $100Use the code ((“{{ '[''com31844'']}}”)) during checkout to get TℰℳU Coupon $100Off For New Users. You can save $100Off your first order with the coupon code available for a limited time only. TℰℳU 90% Off promo code ((“{{ '[''com31844'']}}”)) will save you $100on your order. To get a discount, click on the item to purchase and enter the coe. Yes, offers $100Off coupon code “{{ '[''com31844'']}}” for first time users. You can get a $100bonus plus $100Off any purchase at TℰℳU with the $100Coupon Bundle at TℰℳU if you sign up with the referral code ((“{{ '[''com31844'']}}”)) and make a first purchase of $100or more. Free TℰℳU codes $100off — ((“{{ '[''com31844'']}}”)) Get a $100discount on your TℰℳU order with the promo code "{{ '[''com31844'']}}". You can get a discount by clicking on the item to purchase and entering this TℰℳU Coupon code $100off ((“{{ '[''com31844'']}}”)). ŢℰNew User Coupon ((“{{ '[''com31844'']}})): Up To $100OFF For First-Time Users Our TℰℳU first-time user coupon codes are designed just for new customers, offering the biggest discounts and the best deals currently available on TℰℳU To maximize your savings, download the TℰℳU app and apply our TℰℳU new user coupon during checkout. TℰℳU Coupon Codes For Existing Users ((“{{ '[''com31844'']}}”)): $100Price Slash Have you been shopping on TℰℳU or a while? Our TℰℳU Coupon for existing customers is here to reward you for your continued support, offering incredible discounts on your favorite products. TℰℳU Coupon For $100Off ((“{{ '[''com31844'']}}”)): Get A Flat $100Discount On Order Value Get ready to save big with our incredible TℰℳU Coupon for $100off! Our amazing ŢℰM$100off coupon code will give you a flat $100discount on your order value, making your shopping experience even more rewarding. TℰℳU Coupon Code For $100Off ((“{{ '[''com31844'']}}”)): For Both New And Existing Customers Our incredible TℰℳU Coupon code for $100off is here to help you save big on your purchases. Whether you’re a new user or an existing customer, our $100off code for TℰℳU will give you an additional discount! TℰℳU Coupon Bundle ((“{{ '[''com31844'']}}”)): Flat $100Off + Up To $100Discount Get ready for an unbelievable deal with our TℰℳU Coupon bundle for 2025! Our TℰℳU Coupon bundles will give you a flat $100discount and an additional $100off on top of it. Free TℰℳU Coupons ((“{{ '[''com31844'']}}”)): Unlock Unlimited Savings! Get ready to unlock a world of savings with our free TℰℳU Coupons! We’ve got you covered with a wide range of TℰℳU Coupon code options that will help you maximize your shopping experience. 100% Off TℰℳU Coupons, Promo Codes + 25% Cash Back ((“{{ '[''com31844'']}}”)) Redeem TℰℳU Coupon Code ((“{{ '[''com31844'']}}”)) TℰℳU Coupon $100OFF ((“{{ '[''com31844'']}}”)) TℰℳU Coupon $100OFF FOR EXISTING CUSTOMERS ((“{{ '[''com31844'']}}”)) TℰℳU Coupon $100OFF FIRST ORDER ((“{{ '[''com31844'']}}”)) TℰℳU Coupon $100OFF REDDIT ((“{{ '[''com31844'']}}”)) TℰℳU Coupon $100OFF FOR EXISTING CUSTOMERS REDDIT ((“{{ '[''com31844'']}}”)) TℰℳU $100OFF CODE ((“{{ '[''com31844'']}}”)) TℰℳU 70 OFF COUPON 2025 ((“{{ '[''com31844'']}}”)) DOMINOS 70 RS OFF COUPON CODE ((“{{ '[''com31844'']}}”)) WHAT IS A COUPON RATE ((“{{ '[''com31844'']}}”)) TℰℳU $100OFF FOR EXISTING CUSTOMERS ((“{{ '[''com31844'']}}”)) TℰℳU $100OFF FIRST ORDER ((“{{ '[''com31844'']}}”)) TℰℳU $100OFF FREE SHIPPING ((“{{ '[''com31844'']}}”)) You can get an exclusive $100off discount on your TℰℳU purchase with the code [{{ '[''com31844'']}}] Or [{{ '[''com31844'']}}].This code is specially designed for new customers and offers a significant price cut on your shopping. Make your first purchase on TℰℳU more rewarding by using this code to get $100off instantly.   TℰℳU Coupon Code For $100Off [{{ '[''com31844'']}}] Or [{{ '[''com31844'']}}]: Get A Flat $100Discount On Order Value Get ready to save big with our incredible TℰℳU coupon for $100off! Our coupon code will give you a flat $100discount on your order value, making your shopping experience even more rewarding.   Exclusive TℰℳU Discount Code [{{ '[''com31844'']}}] Or [{{ '[''com31844'']}}]: Flat $300 OFF for New and Existing Customers Using our TℰℳU promo code you can get A$ 200 off your order and 100% off using our TℰℳU promo code [{{ '[''com31844'']}}] Or [{{ '[''com31844'']}}]. As a new TℰℳU customer, you can save up to $100using this promo code. For returning users, our TℰℳU promo code offers a $100price slash on your next shopping spree. This is our way of saying thank you for shopping with us! Get ready to save big with our incredible TℰℳU Coupon code for $300 off! Our amazing TℰℳU $300 off coupon code will give you a flat $300 discount on your order value, making your shopping experience even more rewarding.   TℰℳU Coupon Code For 40% Off ["{com31844}"] For Both New And Existing Customers   Our incredible TℰℳU Coupon code for 40% off is here to help you save big on your purchases. Whether you’re a new user or an existing customer, our 40% off code for TℰℳU will give you an additional discount!   TℰℳU Coupon Bundle ["{com31844}"]: Flat $300 Off + Up To 90% Discount   Get ready for an unbelievable deal with our TℰℳU Coupon bundle for 2025! Our TℰℳU Coupon bundles will give you a flat $300 discount and an additional 40% off on top of it.   Free TℰℳU Coupons ["{com31844}"]: Unlock Unlimited Savings!   Get ready to unlock a world of savings with our free TℰℳU Coupons! We’ve got you covered with a wide range of TℰℳU Coupon code options that will help you maximize your shopping experience.   50% Off TℰℳU Coupons, Promo Codes + 25% Cash Back ["{com31844}"]   Redeem TℰℳU Coupon Code ["{com31844}"]   TℰℳU Coupon $300 OFF ["{com31844}"]   TℰℳU Coupon $300 OFF ["{com31844}"]   TℰℳU Coupon $300 OFF FOR EXISTING CUSTOMERS ["{com31844}"]   TℰℳU Coupon $300 OFF FIRST ORDER ["{com31844}"]   TℰℳU Coupon $300 OFF FIRST ORDER ["{com31844}"]   TℰℳU Coupon $300 OFF FOR EXISTING CUSTOMERS FREE SHIPPING USA ["{com31844}"]   TℰℳU Coupon $300 OFF HOW DOES IT WORK ["{com31844}"]   TℰℳU Coupon $300 OFF FOR EXISTING CUSTOMERS CANADA ["{com31844}"]   TℰℳU Coupon $300 OFF 2025 ["{com31844}"]   TℰℳU Coupon $300 OFF FOR NEW CUSTOMERS ["{com31844}"]   TℰℳU Coupon $300 OFF CANADA ["{com31844}"]   TℰℳU Coupon $300 OFF FOR EXISTING CUSTOMERS FIRST ORDER ["{com31844}"]   TℰℳU 300 OFF COUPON BUNDLE ["{com31844}"]   This TℰℳU coupon $300 off is designed to provide substantial savings on your purchases, making shopping for your favorite items easier than ever. With our $300 off TℰℳU coupon, you'll be amazed at how much you can save on your next order. Here are the key benefits you can expect when using our coupon code {com31844} "OR" {com31844}: {com31844} "OR" {com31844}: Flat $300 off on your purchase {com31844} "OR" {com31844}: $300 coupon pack for multiple uses {com31844} "OR" {com31844}: $300 flat discount for new customers {com31844} "OR" {com31844}: Extra $300 promo code for existing customers {com31844} "OR" {com31844}: $300 coupon exclusively for USA/Canada users H2: TℰℳU Coupon Code $300 Off For New Users In 2024 New users can reap the highest benefits by using our coupon code on the TℰℳU app. This TℰℳU coupon $300 off is specifically designed to welcome new customers with incredible savings  
    • Now the serve runs for a bit, then crashes after 20 minutes of running, what's the issue here? apologies if I need to start a new post and didn't https://pastebin.com/uBpp5bCz  
    • I am trying to play on a friend's modded server but have been experiencing a lot of difficulty.  Whenever I try to connect, it gets stuck on "Joining World" for an extremely long time (10-20 minutes) and will often disconnect in the process, showing either a "Timed Out" or "Internal Exception: java.io.IOException: An established connection was aborted by the software in your host machine" error.  On the few occasions that I am able to get in, the FPS is horrifically bad. The issue seems to be related to ScheduledExecutables since viewing the pie graph reveals that 100% of it is occupied by that. Pressing [1] shows that around 99% of ScheduledExecutables is "Unspecified." VERY rarely, this clears up after ~10 minutes, but most frequently I just end up timing out, or I have to kill the Minecraft process because it freezes in excess of 5 minutes. Things I've tried already: Setting render distance much lower (around 6 to 8 ) Lowering a bunch of other settings, including particles, leaf quality, weather, dynamic lighting, smooth lighting, etc. Limiting FPS to 60 or even 30 Turning off Distant Horizons rendering from the in-game config Updating drivers Tried connecting both with and without a VPN Cleared DNS cache through Windows terminal Downloaded and forced Minecraft to use Java 17 through ATLauncher's settings And probably a few other things I'm forgetting.  Minecraft version is 1.20.1, Forge version is 47.3.12. Related log: https://paste.atlauncher.com/view/95c27d52-93f6-4a9e-930e-d91ad61cfe26 Screenshot of Shift+f3 of when I was able to get into the server (NOT the same as the above log): 
    • This worked, thank you so much!
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.