Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

How do i make my own variant of the brewing stand?


Drachenbauer
 Share

Recommended Posts

Hello

 

I noticed, that a brewing-stand fit´s perfectly onto a square-shaped block, if it had four plates for bottles.

I can create souch a block-model and it´s bottle-parts, based on the vanilla-brewing-stand and i can draw it´s inventory-window with four little squares, where the normal one has three.

But how do i tell the game to place item-slots in theese new positions?

And how do i make it use normal brewing recipes and have four bottles of potion as output instead of three?.

 

Link to comment
Share on other sites

13 minutes ago, Drachenbauer said:

But how do i tell the game to place item-slots in theese new positions?

Inside your container. Containers control what slots are where and handle syncing everything.

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

That would depend on how recipes are already implemented. I would start off by finding out how normal brewing stands make 3

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

  • 1 month later...

In the BrewingStandBloch i find "BlockStateProperties.HAS_BOTTLE_0" and the same with 1 and 2.

It seems like BlockStateProperties is a vanilla-class

How do i add one more for the fourth bottle?

 

And for the TileEntity:

I extend LockableTileEntity, because if i extend BrewingStandTileEntity, i cannot pass my TileEntityType to the constructor.

So i copied the whoole code of BrewingStandTileEntity into my one.

But i´m not sure, where i have to do some changes to add one more inventory-slot

 

Edit

I had to change the position of the bubbles and the arrow on the brewingstand-window a bit to fit four slots.

Wich values on my screen-class (copy of the brewingstand´s screen-class) must i change to change the positions for the white overlays?

Edited by Drachenbauer
Link to comment
Share on other sites

If you look at the class, you can tell that blit draws the binded texture to the screen. It would make sense that the first blit renders the entire screen since it is the gui and background layer to be rendered. This would mean that all other blits are used the render the overlays (arrow, bubbles, blaze input). Deconstructing that further, the integer l seems to clamp down a value divided by 20 between 0 and 18. It also has a integer of k which, if you search what it equals to, is the fuel or blaze input. This means that the blit that is handled by integer l is the blaze input. This means that the last two blits handles either the arrow or the bubbles. Since the second blit of the last two clearly handles the bubbles (it says bubblelengths), then the first blit of the last two must handle the arrow overlay.

Link to comment
Share on other sites

I mean, i don´t know, wich numbers instde theese blits are the position for displaying the graphics.

Is the blaze input the little horizontal bar below the bubbles?

If yes, i moved it together with the bubbles.

 

And i wonder, why there is a longer spiral-wire at the right side of the graphic, where the overlays are?

Edited by Drachenbauer
Link to comment
Share on other sites

How do i register the container with DeferredRegister?

 

I have this in my main-calss constructor:

FourBottlesBrewingStandContainers.CONTAINER_TYPES.register(FMLJavaModLoadingContext.get().getModEventBus());

 

and this in my container-register-class:

public static final DeferredRegister<ContainerType<?>> CONTAINER_TYPES = new DeferredRegister<>(ForgeRegistries.CONTAINERS, Reference.MOD_ID);

 

But i cannot find a way to create the RegistryObject without any red errors in the code...

 

In the vanilla ContainerType-class i found this:

public static final ContainerType<BrewingStandContainer> BREWING_STAND = register("brewing_stand", BrewingStandContainer::new);

 

at other stuff (blocks, items, entities,...), i was able to put the part behind the registryname into the RegistryObject behind the id-name.

But here it is "BrewingStandContainer::new" and it does not work...

 

 This:

public static final RegistryObject<ContainerType<FourBottlesBrewingStandContainer>> FOUR_BOTTLES_BREWING_STAND = CONTAINER_TYPES.register("four_bottles_brewing_stand", () -> FourBottlesBrewingStandContainer::new);

 

gives two errors:

Quote

The target type of this expression must be a functional interface


Type mismatch: cannot convert from RegistryObject<ContainerType<?>> to RegistryObject<ContainerType<FourBottlesBrewingStandContainer>>

 

What else must i place behind the arrow-operator in that line to register a container?

Edited by Drachenbauer
Link to comment
Share on other sites

Push

 

I still don´t know, how to register an inventory-container with DeferredRegister.

 

If i try to use IForgeContainerType like this:

public static final RegistryObject<ContainerType<FourBottlesBrewingStandContainer>> FOUR_BOTTLES_BREWING_STAND = CONTAINER_TYPES.register("four_bottles_brewing_stand", () -> IForgeContainerType.create(FourBottlesBrewingStandContainer::new));

 

i get theese three errors:

Quote

The method create(IContainerFactory<T>) in the type IForgeContainerType is not applicable for the arguments (FourBottlesBrewingStandContainer::new)


The method register(String, Supplier<? extends I>) in the type DeferredRegister<ContainerType<?>> is not applicable for the arguments (String, () -> {})


The type FourBottlesBrewingStandContainer does not define FourBottlesBrewingStandContainer(int, PlayerInventory, PacketBuffer) that is applicable here

 

How do i add a PacketBuffer to the constructor of my container?

 

Edit:

Now i added "PacketBuffer buffer" to the constructor input.

The errors disappeared, but no window opens, if i click on my brewingstand and an error appears in the console:

Quote

[m[33m[15:32:57] [Render thread/WARN] [minecraft/ScreenManager]: Failed to create screen for menu type: fourbottlesbrewingstandmod:four_bottles_brewing_stand

Edit:

Now i placed this in my client-setup:

ScreenManager.registerFactory(FourBottlesBrewingStandContainers.FOUR_BOTTLES_BREWING_STAND.get(), FourBottlesBrewingStandScreen::new);

And it works.

Edited by Drachenbauer
Link to comment
Share on other sites

Now my brewing screen appears and i can place matching items into all the slots.

And the model also shows bottles on the matching positions (view from south matches perfect with the slots on the brewing-window).

 

But as i tested a brewing process, the fourth bottle disappeared at the finish.

 

Edit:

i had to increase some InventorySlot values in the TileEntity and the Container by 1.

Now everything works fine.

 

Edit again:

As i used it in the actual game, i noticed, that at placing it, for a short moment a bottle appears on one of the filling arms.

Seams like a boolean for one of them is true for a short moment after placing.

 

Edit fixed:

The constructor of the Block has aline, that sets the states for the filling arms in the model to false at first.

It included only three of theese parts.

So i added

with(HAS_BOTTLE[3], Boolean.valueOf(false))

as the fourth part into that line.

I´m sure, that no more bottle will appear at placing the brewing stand now.

Edited by Drachenbauer
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Thanks everybody! I managed to fix it. I just had some missing attributes in my OilFluid class
    • W10 Pro. Android 11 on my S20+(or is it 12 already?). My two other computers are running on W10 home, all behind G-Data security suite, and a Fritz. I'm supposed to use Linux, no? I hate making things compatible, and Linux has limited access to some games I love, so...Mac is even worth I guess? I'm buying servers btw. It's not I couldn't set one up for Linux, but I lack the skills in online security, and I'm paranoid. So not a good combo I guess?
    • Yeah, the whole registry process can be quite confusing and daunting for how MC is working nowadays, but once you get the grasp of it, it actually saves a whole lot of effort, and quantity of code. I'd spend 3 days+ to actually figure I had to apply the getter(.get())[<-- is this even named getter?], to any of the .class references, because stupid Eclipse refused to de-obfuscate the source of problems. It was just making stupid a** auto fix suggestions, that didn't help at all. Google found the answer quite often though. And don't even get me started when I was trying to implement the Oil to world generation. I was literally tearing my hair out for days. But don't give up. We're not the only ones dealing with the reinvention of MC code wheel. I mean I get it. There's always room for improvements. But a wheel is just a wheel, right?
    • Thank you everybody, I have figured out the cause. I was accidentally passing in the constructor for the Fluids instead of the RegistryObject. I changed: super(new ForgeFlowingFluid.Properties( OilFluid.Source::new, OilFluid.Flowing::new, to: super(new ForgeFlowingFluid.Properties( ModFluids.OIL, ModFluids.FLOWING_OIL, And now the fluid actually works! But it doesn't spread though, I think I'd be able to figured it out from now. Thanks a lot Luis_ST and Cratthorax!
    • Because I was used to doing it like that in the past. Also, a block is very sparse in code quantity. Also, also, I would use the blocks to check against blocks of same type at lower levels, to mark as an indicator to what can be found digging deeper into the ground. Doing that with anything but the same object type is just unnecessarily bloating code. However, I had to use creative ways to get something working. What I did was rendering my block and its voxel shape invisible, make it nonsolid and notBlockMovement, then apply the randomTick() method, and using this: worldIn.destroyBlock(pos, true);...which basically drops the item after the blocks gets randomly destroyed. The good thing about that is, with the new DataPack function, I can do all that stuff with a single block object, and then just use instances of other block registers and their properties. I can also customize the loot tables for any of them, but don't need an actual block.class for any of them. Given how I have more then 60 ore blocks in my old mod, that is a really great thing about newer MC versions. The final solution was actually found in vanilla Block.AIR, after messing around with various methods, none of them doing what was easily done in the past MC versions with onBlockAdded(), and dropBlockAsItem(). I'll just leave the block code, and register code here for reference, which should give you a picture of the many things I was trying without success:
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.