Item disappears after player crafts the item with custom IRecipe implementation.

[AntonBespoiasov]

public class OreFinderBindOre extends IForgeRegistryEntry.Impl<IRecipe> implements IRecipe
{	
	public OreFinderBindOre()
	{
		setRegistryName(References.MOD_ID + ":ore_finder_bind_ore");
	}
	

	@Override
	public boolean matches(InventoryCrafting inv, World worldIn)
	{
		ItemStack oreFinder = null;
		ItemStack ore = null;
		
		for (int i = 0; i < inv.getSizeInventory(); i++)
		{
			ItemStack cur = inv.getStackInSlot(i);
			
			if (cur.getItem() == Main.ORE_FINDER)
			{
				if (oreFinder != null) return false;
				oreFinder = cur;
			} else if (cur.getItem() instanceof ItemBlock)
			{
				if (ore == null) ore = new ItemStack(cur.getItem(), 1, cur.getItemDamage());
				else if (ore.isItemEqual(cur)) ore.grow(1);
				else return false;
			} else 
			{
				return false;
			}
		}
		
		return ore.getCount() == 8 && oreFinder.getTagCompound() == null; 
	}

	@Override
	public ItemStack getCraftingResult(InventoryCrafting inv)
	{
		ItemStack oreFinder = null;
		ItemBlock ore = null;	
		
		Main.LOGGER.info("Executed the line");
		
		for (int i = 0; i < inv.getSizeInventory(); i++) // Fetches ingredients
		{
			ItemStack cur = inv.getStackInSlot(i);
			
			if (cur.getItem() == Main.ORE_FINDER)
			{
				oreFinder = cur;
			} else if (cur.getItem() instanceof ItemBlock)
			{
				ore = (ItemBlock)cur.getItem();
			}
		}
		
		NBTTagCompound nbt = oreFinder.getTagCompound();
		
		if (nbt == null || !nbt.hasKey("Ore"))
		{
			nbt = new NBTTagCompound();
			nbt.setInteger("Ore", Block.getIdFromBlock(ore.getBlock())); // Set the ore in the ore finder
		}
		oreFinder.setTagCompound(nbt);
		
		return oreFinder;
	}

	@Override
	public boolean canFit(int width, int height)
	{
		return width * height >= 9;
	}

	public boolean isDynamic()
    {
        return true;
    }
	
	@Override
	public ItemStack getRecipeOutput()
	{
		return ItemStack.EMPTY;
	}
	
	public NonNullList<ItemStack> getRemainingItems(InventoryCrafting inv)
    {
        NonNullList<ItemStack> nonnulllist = NonNullList.<ItemStack>withSize(inv.getSizeInventory(), ItemStack.EMPTY);

        for (int i = 0; i < nonnulllist.size(); ++i)
        {
            ItemStack itemstack = inv.getStackInSlot(i);
            nonnulllist.set(i, net.minecraftforge.common.ForgeHooks.getContainerItem(itemstack));
        }

        return nonnulllist;
    }
}

The above code is the implementation of IRecipe.

The Ore finder has NBT tag "Ore" that stores ore. The ore finder is like compass but it points to closest block which ID is stored in the "Ore" tag.

The purpose of the implementation of IRecipe is to say which block to find. You put 8 of the blocks and an Ore finder on the crafting grid. It puts ID of the blocks in the "Ore" tag, consumes blocks and gives as result Ore finder with the new NBT tag.

The problem is when the player takes the result from recipe output slot puts it in his inventory and then closes crafting inventory the item disappears. Why does it happen. Maybe server-client async but I checked vanilla implementations of IRecipe and they didn't use any messages and packets. Thanks in advance for solving such a personal problem.

Edited March 12, 2020 by AntonBespoiasov
Updated code

[Draco18s]

Override getRemainingItems.

[AntonBespoiasov]

15 minutes ago, Draco18s said:

Override getRemainingItems.

I overrode getRemainingItems with code from net.minecraft.item.crafting.RecipeRepairItem. The code simply tries to get container from items that lie on the crafting grid. But it didn't help. Also I solved the NBT problem. 

New code is in the first post of the topic with the implementation of getRemainingItems and new NBT setting code.

Edited March 12, 2020 by AntonBespoiasov

[diesieben07]

1.12 is no longer supported on this forum.

Please update to a modern version of Minecraft to receive support.