Custom Furnace 2 inputs

[OwnAgePau]

Hi all

 

I'm currently working on my Custom Furnace which actually is named Gemcutter and will be used to cut gems using a uncut gem and a polisher towel as input and a polisher bucket as a fuel. Now i have been looking thourgh the code and looking at some other threads about this thing.

But i can't get it work just yet.

My gui and container both work.

 

So i hope you guys can help out a little, these are my files:

 

TileEntityGemcutter : http://pastebin.com/0vE6PKv6

GemcutterRecipes : http://pastebin.com/eNyww5p1

 

Thanks for your time.

[Mazetar]

It does'nt work tells me nothing

What is it that ain't working as it should?

What do you expect to happen?

What happen's instead?

[OwnAgePau]

Well, nothing happens. I open the gui and i can put items in the slots.

So i would like it to have these 2 inputs to work as 1 normally would. so i put in my custom fuel and it starts "cooking". Then after a few seconds the uncut and 1 polisher towerl will be removed.

[Mazetar]

Okay a few questions:

 

1. What is the purpose and reasons for these variables?

- field_102010_d

- field_102011_e

- field_102009_f

- field_94130_e

( You should consider renaming them to something relevant to their purpose )

 

2. Line 421 "return GameRegistry.getFuelValue(par0ItemStack);" Will make it return values for other things than you're polish thingy, if that's not intended make it return 0;

 

3. You should rename the flag & flag1 variables of the updateEntity() method, the names are meaningless.

 

4. Looking into your update call, step by step it goes like this:

- Calls canSmelt()

  |- Checks that slot 0 & slot 3 are not empty.

    |- Gets the ItemStack from smelting the items inn slots 0(input) & 3(input).

    |- Checks that slot 2 can contain the resulting item if there was one.

- If it's burning, then reduce gemcutterBurnTime.

- Check to make sure it's server side.

 

- If it's not burning but canSmelt() still returns true

- Get the burn time of item inn slot 1(fuel) and set currentItemBurn time to that.

- Check that we are now burning.

- Set flag1 to true;

- Check if there are fuel left, and decrease the itemstack size.

 

Does your code function upto this point? does it to as expected? how is the canSMelt() working?

does it give the correct result? does the getItemBurnTime() return the expected values?

 

 

[OwnAgePau]

Before i say anything i want to thank you for the detailed reply, i have not much time to look in to it anywhere soon so i will go look at the tileentity a lot closer this weekend, i will let you know more when i run into some serious issues.

 

For now i think i have enough to start my search, you will see another reply from me once i'm out of ideas

[OwnAgePau]

I am trying to now add the recipes in but and i followed someones idea which did the following in addGemcutterSmelting():

public void addGemcutterSmelting(int par1, int par2, ItemStack par2ItemStack, float par3)
    {
    	StringBuffer sb = new StringBuffer(32);
    	sb.append(Math.min(par1, par2)).append("_").append(Math.max(par1, par2));
        this.gemcutterList.put(Integer.valueOf(sb.toString()), par2ItemStack);
        this.experienceList.put(Integer.valueOf(par2ItemStack.itemID), Float.valueOf(par3));
    }
// now ofcourse i am getting an error on the line : "this.gemcutterList.put" because its trying to read this string : "26557_26732" and put it as an int. Ofcourse that string cannot be converted to an int. Or am i completely wrong?

 

I also found the method transferStackInSlot a bit confusing (in containerGemcutter) i see how it only occurs when you shiftclick an item and i basically wouldn't have to change it at all, but only

if (GemcutterRecipes.smelting().getSmeltingResult(itemstack1, itemstack2) != null)
{
if (!this.mergeItemStack(itemstack1, 0, 1, false))
   {
    return null;
   }
}
// only that remains (not i added itemstack 2 there) but i am not sure what to do in this method

 

Another question is, in the container class should i or shouldn't i add these lines of code to detectAndSendChanges():

if (this.lastGemBurnTime != this.gemcutter.gemcutterCookTime2)
{
    icrafting.sendProgressBarUpdate(this, 3, this.gemcutter.gemcutterBurnTime);
}

 

I think my smeltItem() and canSmelt() are pretty much sorted.

 

canSmelt():

private boolean canSmelt()
    {
        if (this.gemcutterItemStacks[0] == null)
        {
            return false;
        }
        if (this.gemcutterItemStacks[3] == null)
        {
            return false;
        }
        else
        {
            ItemStack itemstack = GemcutterRecipes.smelting().getSmeltingResult(this.gemcutterItemStacks[0], this.gemcutterItemStacks[3]);
            if (itemstack == null) return false;
            if (this.gemcutterItemStacks[2] == null) return true;
            if (!this.gemcutterItemStacks[2].isItemEqual(itemstack)) return false;
            int result = gemcutterItemStacks[2].stackSize + itemstack.stackSize;
            return (result <= getInventoryStackLimit() && result <= itemstack.getMaxStackSize());
        }
    }

 

smeltItem:

 

 

public void smeltItem()
    {
        if (this.canSmelt())
        {
            ItemStack itemstack = GemcutterRecipes.smelting().getSmeltingResult(this.gemcutterItemStacks[0], this.gemcutterItemStacks[3]);
            
            if (this.gemcutterItemStacks[2] == null)
            {
                this.gemcutterItemStacks[2] = itemstack.copy();
            }
            else if (this.gemcutterItemStacks[2].isItemEqual(itemstack))
            {
                gemcutterItemStacks[2].stackSize += itemstack.stackSize;
            }

            --this.gemcutterItemStacks[0].stackSize;

            if (this.gemcutterItemStacks[0].stackSize <= 0)
            {
                this.gemcutterItemStacks[0] = null;
            }
            
            --this.gemcutterItemStacks[3].stackSize;

            if (this.gemcutterItemStacks[3].stackSize <= 0)
            {
                this.gemcutterItemStacks[3] = null;
            }
        }
    }

 

 

 

The last thing i have changed is the getSmeltingItemResult:

public ItemStack getSmeltingResult(ItemStack item, ItemStack item2) 
    {
        if (item == null || item2 == null)
        {
            return null;
        }
        ItemStack ret = (ItemStack)gemcutterSmeltingList.get(Arrays.asList(item.itemID, item.getItemDamage(), item2.itemID, item2.getItemDamage()));
        if (ret != null) 
        {
            return ret;
        }
        return (ItemStack)gemcutterList.get(Integer.valueOf(item.itemID));
    }

 

I hope you can help me to get this addGemcutterRecipe working. Also i would like to ask are the changes i made good or almost good or not good at all. Thanks for your time and effort

[OwnAgePau]

Sorry for another double post but i would really appreciate some help with this...