[1.15.2] Items and blocks don't register correctly

[SaltStation]

I wanted to try the DeferredRegister to register items and blocks, but I always get this error:

 

Quote

 Exception caught during firing event: Attempted to set registry name with existing registry name! New: opus:sulfureore Old: opus:sulfureore

 

 

RegistryHandler code :

Spoiler

	//Register
	private static final DeferredRegister<Item> ITEMS = new DeferredRegister<>(ForgeRegistries.ITEMS, MODID);
    private static final DeferredRegister<Block> BLOCKS = new DeferredRegister<>(ForgeRegistries.BLOCKS, MODID);


	//Register Blocks
	public static final RegistryObject<Block> SULFUREORE_BLOCK = BLOCKS.register("sulfureore",() -> new BasicOre().ore("sulfureore"));
	public static final RegistryObject<Block> CINNABARORE_BLOCK = BLOCKS.register("cinnabarore",() -> new BasicOre().ore("cinnabarore"));
	public static final RegistryObject<Block> SALTORE_BLOCK = BLOCKS.register("saltore",() -> new BasicOre().ore("saltore"));

	//Register Items
	public static final RegistryObject<Item> SULFUREORE_ITEM = ITEMS.register("sulfureore",() -> new ItemHelper().ItemfromBlock(new BasicOre().ore("sulfureore")));
	public static final RegistryObject<Item> CINNABARORE_ITEM = ITEMS.register("cinnabarore",() -> new ItemHelper().ItemfromBlock(new BasicOre().ore("cinnabarore")));
	public static final RegistryObject<Item> SALTORE_ITEM = ITEMS.register("saltore",() -> new ItemHelper().ItemfromBlock(new BasicOre().ore("saltore")));

	public static void registerall(){

		BLOCKS.register(FMLJavaModLoadingContext.get().getModEventBus());
		ITEMS.register(FMLJavaModLoadingContext.get().getModEventBus());
    }

 

Main mod class:

Spoiler

public Opus() {
        // Register the setup method for modloading
        FMLJavaModLoadingContext.get().getModEventBus().addListener(this::setup);
        FMLJavaModLoadingContext.get().getModEventBus().addListener(this::doClientStuff);

        RegistryHandler.registerall();

        // Register ourselves for server and other game events we are interested in
        MinecraftForge.EVENT_BUS.register(this);


}

 

 

There are blocks with the same name as items, but this should be fine shouldn't it?

How does this error happen and how would I fix it?

Thanks in advance!

[DaemonUmbra]

Do you set the registry name in your block's constructor?

Is there a reason your block's constructor doesn't match Block's constructor?

[SaltStation]

Because all three blocks are the same except in name I made the following class:

Spoiler

public class BasicOre {

    public static Block ore(String name){
        return new Block(Block.Properties.create(Material.ROCK)
                .lightValue(0)
                .hardnessAndResistance(3,15)
                .harvestLevel(1)
                .harvestTool(net.minecraftforge.common.ToolType.PICKAXE)).setRegistryName(name);
    }
}

 

 

Edited March 24, 2020 by SaltStation
spelling and wording

[DaemonUmbra]

Helpers like that are basically useless, just use the regular Block constructor in-line.

Also, is ItemHelper one of your classes? I can't seem to find it in Forge or Minecraft

[SaltStation]

Yes it is this class:

	public static BlockItem ItemfromBlock(Block p) {
		return (BlockItem) new BlockItem(p, (new Item.Properties()).group(ItemGroup.BUILDING_BLOCKS)).setRegistryName(p.getRegistryName());
	}
}

 

[DaemonUmbra]

That's terrible, don't use it

[DavidM]

DeferredRegistry already automatically sets the registry name.

You are also setting It manually, resulting in:

Quote

Exception caught during firing event: Attempted to set registry name with existing registry name! New: opus:sulfureore Old: opus:sulfureore

 

[SaltStation]

Ah ok it works now, but why shouldn't I use the ItemfromBlock method?

[DaemonUmbra]

Because you might as well just use new BlockItem directly and not auto-assign the item to Building Blocks