Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[Solved]Item loss

Naiten

By Naiten
in Modder Support

 Share

Recommended Posts

Naiten Diamond Finder

Naiten

Posted
Posted

I have an item, and it tends to get lost after i save/load. What's wrong?

package net.obscuracraft.item;

import java.util.Random;

import net.minecraft.client.Minecraft;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemMapBase;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;
import net.minecraft.world.storage.MapData;
import net.obscuracraft.ObscuraCraft;
import net.obscuracraft.camera.BlockObscura;

public class ItemPhotoEmpty extends ItemMapBase
{
    public ItemPhotoEmpty(int par1){
        super(par1);
        this.setMaxDamage(0);
        this.maxStackSize = 1;
        this.hasSubtypes = true;
        setUnlocalizedName("obscuracraft:positive");
        setCreativeTab(CreativeTabs.tabRedstone);
    }
@Override
public ItemStack onItemRightClick(ItemStack item, World world, EntityPlayer player){
	ItemStack item1 = new ItemStack(ObscuraCraft.iphoto, 1, world.getUniqueDataId("photo"));
	item1.attemptDamageItem(1, new Random());
        String s = "photo_" + item1.getItemDamage();
        MapData mapdata = new MapData(s);
        mapdata.colors = BlockObscura.lastColors;
        world.setItemData(s, mapdata);
        mapdata.markDirty();
        item1.setItemName("Photo #" + item1.getItemDamage());
        item.stackSize--;
        return item1;
    }
}

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

SanAndreaP World Shaper

SanAndreaP

Posted
Posted

I have an item, and it tends to get lost after i save/load. What's wrong?

package net.obscuracraft.item;

import java.util.Random;

import net.minecraft.client.Minecraft;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemMapBase;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;
import net.minecraft.world.storage.MapData;
import net.obscuracraft.ObscuraCraft;
import net.obscuracraft.camera.BlockObscura;

public class ItemPhotoEmpty extends ItemMapBase
{
    public ItemPhotoEmpty(int par1){
        super(par1);
        this.setMaxDamage(0);
        this.maxStackSize = 1;
        this.hasSubtypes = true;
        setUnlocalizedName("obscuracraft:positive");
        setCreativeTab(CreativeTabs.tabRedstone);
    }
@Override
public ItemStack onItemRightClick(ItemStack item, World world, EntityPlayer player){
	ItemStack item1 = new ItemStack(ObscuraCraft.iphoto, 1, world.getUniqueDataId("photo"));
	item1.attemptDamageItem(1, new Random());
        String s = "photo_" + item1.getItemDamage();
        MapData mapdata = new MapData(s);
        mapdata.colors = BlockObscura.lastColors;
        world.setItemData(s, mapdata);
        mapdata.markDirty();
        item1.setItemName("Photo #" + item1.getItemDamage());
        item.stackSize--;
        return item1;
    }
}

 

get lost in which way? Disappearing or data isn't saved or what?

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Naiten Diamond Finder

Naiten

Posted
  • Author
Posted

Ite, dissappears from my inventory. And data isn't saved too, it's equal to all my photo items -_-

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Naiten Diamond Finder

Naiten

Posted
  • Author
Posted

I've made several items in this mod and they don't get lost.

Also, as i remember, no spetial registration is needed so far...

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Naiten Diamond Finder

Naiten

Posted
  • Author
Posted

Also, items are getting lost if i right-click a block with it in my hand...

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Naiten Diamond Finder

Naiten

Posted
  • Author
Posted

Oh, i got it. It's in

mineCraft.thePlayer.inventory.setCurrentItem(ObscuraCraft.icamera.itemID, 0, false, true);

How do i do that in right way?

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Zetal Creeper Killer

Zetal

Posted
Posted

You should use this instead:

 

    	this.inventory.addItemStackToInventory(YOURITEMSTACKHERE);

 

The code that you're using is designed to change which item a player has 'selected' at the time. The above will actually add it to the inventory. In order to use it, you'll need to create a new ItemStack object using whatever parameters you need. An inventory object only ever takes 'ItemStack' objects into it's slots, not items.

Have a modding question? PM me and hopefully I'll be able to help. Good at 2d Pixel Art? We need your help!  http://www.minecraftforum.net/topic/1806355-looking-for-2d-pixel-artist/

Naiten Diamond Finder

Naiten

Posted
  • Author
Posted 
public class BlockObscura extends BlockContainer{
blablabla;
//called from other place
public static void takePhoto(){
	blablabla;
	Minecraft mineCraft = Minecraft.getMinecraft();
	mineCraft.thePlayer.inventory.addItemStackToInventory(new ItemStack(ObscuraCraft.icamera));
	//mineCraft.thePlayer.inventory.setCurrentItem(ObscuraCraft.icamera.itemID, 0, false, true);
	blablabla;
}
}

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Naiten Diamond Finder

Naiten

Posted
  • Author
Posted

Now i need to update inventory, as my item appear them only after s/l -____-

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Naiten Diamond Finder

Naiten

Posted
  • Author
Posted

There's public boolean onItemUse(ItemStack item, EntityPlayer player, World world, int x, int y, int z, int side, float xOffset, float yOffset, float zOffSet)

And i can't use onItemRightClick, because i need clicked block coordinates.

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Naiten Diamond Finder

Naiten

Posted
  • Author
Posted 
@Override
    public boolean onItemUse(ItemStack item, EntityPlayer player, World world, int x, int y, int z, int side, float xOffset, float yOffset, float zOffSet){
        if (!world.isRemote && item.getItemDamage() == 0){
        	if(world.getBlockId(x, y, z) == ObscuraCraft.camera.blockID){
        		if(world.getBlockMetadata(x, y, z) == 4){
        			y--;
        		}
        		int meta = world.getBlockMetadata(x, y, z);
        		world.setBlockMetadataWithNotify(x, y, z, 4, 0x02);
        		world.setBlockMetadataWithNotify(x, y, z, meta, 0x02);
        		TileEntityObscura tl = (TileEntityObscura)world.getBlockTileEntity(x, y, z);
        		tl.filled = true;
        		BlockObscura.takePhoto(player);
            	if (!player.capabilities.isCreativeMode){--item.stackSize;}
            	player.inventory.addItemStackToInventory(new ItemStack(ObscuraCraft.icamera));
            	return true;
        	}
	}
        return false;
    }

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

SanAndreaP World Shaper

SanAndreaP

Posted
Posted 

@Override
    public boolean onItemUse(ItemStack item, EntityPlayer player, World world, int x, int y, int z, int side, float xOffset, float yOffset, float zOffSet){
        if (!world.isRemote && item.getItemDamage() == 0){
        	if(world.getBlockId(x, y, z) == ObscuraCraft.camera.blockID){
        		if(world.getBlockMetadata(x, y, z) == 4){
        			y--;
        		}
        		int meta = world.getBlockMetadata(x, y, z);
        		world.setBlockMetadataWithNotify(x, y, z, 4, 0x02);
        		world.setBlockMetadataWithNotify(x, y, z, meta, 0x02);
        		TileEntityObscura tl = (TileEntityObscura)world.getBlockTileEntity(x, y, z);
        		tl.filled = true;
        		BlockObscura.takePhoto(player);
            	if (!player.capabilities.isCreativeMode){--item.stackSize;}
            	player.inventory.addItemStackToInventory(new ItemStack(ObscuraCraft.icamera));
            	return true;
        	}
	}
        return false;
    }

 

after

player.inventory.addItemStackToInventory(new ItemStack(ObscuraCraft.icamera));

use this:

player.inventoryContainer.detectAndSendChanges();

 

It sends the changes you made in the players inventory on the server to the client.

 

Also you should define a quantity in your ItemStack like this: new ItemStack(ObscuraCraft.icamera, 1)

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Naiten Diamond Finder

Naiten

Posted
  • Author
Posted
use this:

player.inventoryContainer.detectAndSendChanges();

It sends the changes you made in the players inventory on the server to the client.

Also you should define a quantity in your ItemStack like this: new ItemStack(ObscuraCraft.icamera, 1)

Thanks.

And, i actually should not. ItemStack has a constructor without quantity that automatically sets it to 1.

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

SanAndreaP World Shaper

SanAndreaP

Posted
Posted

use this:

player.inventoryContainer.detectAndSendChanges();

It sends the changes you made in the players inventory on the server to the client.

Also you should define a quantity in your ItemStack like this: new ItemStack(ObscuraCraft.icamera, 1)

Thanks.

And, i actually should not. ItemStack has a constructor without quantity that automatically sets it to 1.

 

Oh, didn't know that. Well then not :P

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • Attack Helicopter
      Essential mod incopatible

      By Attack Helicopter · Posted

      I tried do download the essential mod to my mod pack but i didnt work. I paly on 1.21 and it should work. I use neoforge for my modding. The weird things is my friend somehow added the mod to his modpack and many others that I somehow can´t. Is there anything i can do? 
    • Venatus94
      Minecraft Server crash

      By Venatus94 · Posted

      Thanks, I've now installed a slightly newer version and the server is at least starting up now.
    • Mrmeeseeks
      New Issue no title

      By Mrmeeseeks · Posted

      i have the same issue. Found 1 Create mod class dependency(ies) in createdeco-1.3.3-1.19.2.jar, which are missing from the current create-1.19.2-0.5.1.i.jar Found 11 Create mod class dependency(ies) in createaddition-fabric+1.19.2-20230723a.jar, which are missing from the current create-1.19.2-0.5.1.i.jar Detailed walkthrough of mods which rely on missing Create mod classes: Mod: createaddition-fabric+1.19.2-20230723a.jar Missing classes of create: com/simibubi/create/compat/jei/category/sequencedAssembly/JeiSequencedAssemblySubCategory com/simibubi/create/compat/recipeViewerCommon/SequencedAssemblySubCategoryType com/simibubi/create/compat/rei/CreateREI com/simibubi/create/compat/rei/EmptyBackground com/simibubi/create/compat/rei/ItemIcon com/simibubi/create/compat/rei/category/CreateRecipeCategory com/simibubi/create/compat/rei/category/WidgetUtil com/simibubi/create/compat/rei/category/animations/AnimatedBlazeBurner com/simibubi/create/compat/rei/category/animations/AnimatedKinetics com/simibubi/create/compat/rei/category/sequencedAssembly/ReiSequencedAssemblySubCategory com/simibubi/create/compat/rei/display/CreateDisplay Mod: createdeco-1.3.3-1.19.2.jar Missing classes of create: com/simibubi/create/content/kinetics/fan/SplashingRecipe
    • TileEntity
      Minecraft Server crash

      By TileEntity · Posted

      The crash points to moonlight lib - try other builds or make a test without this mod and the mods requiring it
    • TileEntity
      Game Crashes When I Start It

      By TileEntity · Posted

      Do you have shaders enabled? There is an issue with the mod simpleclouds - remove this mod or disable shaders, if enabled  

  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept