[Solved]Item loss

[Naiten]

I have an item, and it tends to get lost after i save/load. What's wrong?

package net.obscuracraft.item;

import java.util.Random;

import net.minecraft.client.Minecraft;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemMapBase;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;
import net.minecraft.world.storage.MapData;
import net.obscuracraft.ObscuraCraft;
import net.obscuracraft.camera.BlockObscura;

public class ItemPhotoEmpty extends ItemMapBase
{
    public ItemPhotoEmpty(int par1){
        super(par1);
        this.setMaxDamage(0);
        this.maxStackSize = 1;
        this.hasSubtypes = true;
        setUnlocalizedName("obscuracraft:positive");
        setCreativeTab(CreativeTabs.tabRedstone);
    }
@Override
public ItemStack onItemRightClick(ItemStack item, World world, EntityPlayer player){
	ItemStack item1 = new ItemStack(ObscuraCraft.iphoto, 1, world.getUniqueDataId("photo"));
	item1.attemptDamageItem(1, new Random());
        String s = "photo_" + item1.getItemDamage();
        MapData mapdata = new MapData(s);
        mapdata.colors = BlockObscura.lastColors;
        world.setItemData(s, mapdata);
        mapdata.markDirty();
        item1.setItemName("Photo #" + item1.getItemDamage());
        item.stackSize--;
        return item1;
    }
}

[SanAndreaP]

I have an item, and it tends to get lost after i save/load. What's wrong?

package net.obscuracraft.item;

import java.util.Random;

import net.minecraft.client.Minecraft;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemMapBase;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;
import net.minecraft.world.storage.MapData;
import net.obscuracraft.ObscuraCraft;
import net.obscuracraft.camera.BlockObscura;

public class ItemPhotoEmpty extends ItemMapBase
{
    public ItemPhotoEmpty(int par1){
        super(par1);
        this.setMaxDamage(0);
        this.maxStackSize = 1;
        this.hasSubtypes = true;
        setUnlocalizedName("obscuracraft:positive");
        setCreativeTab(CreativeTabs.tabRedstone);
    }
@Override
public ItemStack onItemRightClick(ItemStack item, World world, EntityPlayer player){
	ItemStack item1 = new ItemStack(ObscuraCraft.iphoto, 1, world.getUniqueDataId("photo"));
	item1.attemptDamageItem(1, new Random());
        String s = "photo_" + item1.getItemDamage();
        MapData mapdata = new MapData(s);
        mapdata.colors = BlockObscura.lastColors;
        world.setItemData(s, mapdata);
        mapdata.markDirty();
        item1.setItemName("Photo #" + item1.getItemDamage());
        item.stackSize--;
        return item1;
    }
}

 

get lost in which way? Disappearing or data isn't saved or what?

[Naiten]

Ite, dissappears from my inventory. And data isn't saved too, it's equal to all my photo items

[Senitiel]

Do You have any other items which don't share this issue? Or is it the first item You've created so far, if so,

post code responsible for creating and registering this item.

[Naiten]

I've made several items in this mod and they don't get lost.

Also, as i remember, no spetial registration is needed so far...

[Naiten]

Also, items are getting lost if i right-click a block with it in my hand...

[Naiten]

Oh, i got it. It's in

mineCraft.thePlayer.inventory.setCurrentItem(ObscuraCraft.icamera.itemID, 0, false, true);

How do i do that in right way?

[Zetal]

What do you want that method to do?

[Naiten]

I want my block to give item to player.

[Zetal]

You should use this instead:

 

    	this.inventory.addItemStackToInventory(YOURITEMSTACKHERE);

 

The code that you're using is designed to change which item a player has 'selected' at the time. The above will actually add it to the inventory. In order to use it, you'll need to create a new ItemStack object using whatever parameters you need. An inventory object only ever takes 'ItemStack' objects into it's slots, not items.

[Naiten]

I've just tried that, no result.

[Zetal]

Could you show me the new code you're using? I'm not a psychic! 

[Naiten]

public class BlockObscura extends BlockContainer{
blablabla;
//called from other place
public static void takePhoto(){
	blablabla;
	Minecraft mineCraft = Minecraft.getMinecraft();
	mineCraft.thePlayer.inventory.addItemStackToInventory(new ItemStack(ObscuraCraft.icamera));
	//mineCraft.thePlayer.inventory.setCurrentItem(ObscuraCraft.icamera.itemID, 0, false, true);
	blablabla;
}
}

[Zetal]

Try replacing

  mineCraft.thePlayer.inventory.addItemStackToInventory(new ItemStack(ObscuraCraft.icamera));

 

with this instead;

 

player.inventory.addItemStackToInventory(item1);

I /think/ that's what you're looking for. Let me know.

[Naiten]

Now i need to update inventory, as my item appear them only after s/l -____-

[Zetal]

Where is takePhoto() referenced? You shouldn't ever really have to update the inventory when adding an itemstack to a player.

[Naiten]

In onItemUse().

[Zetal]

Do you mean public ItemStack onItemRightClick(ItemStack item, World world, EntityPlayer player)? Or is there another method that I'm missing?

[Naiten]

There's public boolean onItemUse(ItemStack item, EntityPlayer player, World world, int x, int y, int z, int side, float xOffset, float yOffset, float zOffSet)

And i can't use onItemRightClick, because i need clicked block coordinates.

[Zetal]

Could you post that method? I'll look at it tomorrow. Going to sleep. Night!

[Naiten]

@Override
    public boolean onItemUse(ItemStack item, EntityPlayer player, World world, int x, int y, int z, int side, float xOffset, float yOffset, float zOffSet){
        if (!world.isRemote && item.getItemDamage() == 0){
        	if(world.getBlockId(x, y, z) == ObscuraCraft.camera.blockID){
        		if(world.getBlockMetadata(x, y, z) == 4){
        			y--;
        		}
        		int meta = world.getBlockMetadata(x, y, z);
        		world.setBlockMetadataWithNotify(x, y, z, 4, 0x02);
        		world.setBlockMetadataWithNotify(x, y, z, meta, 0x02);
        		TileEntityObscura tl = (TileEntityObscura)world.getBlockTileEntity(x, y, z);
        		tl.filled = true;
        		BlockObscura.takePhoto(player);
            	if (!player.capabilities.isCreativeMode){--item.stackSize;}
            	player.inventory.addItemStackToInventory(new ItemStack(ObscuraCraft.icamera));
            	return true;
        	}
	}
        return false;
    }

[SanAndreaP]

@Override
    public boolean onItemUse(ItemStack item, EntityPlayer player, World world, int x, int y, int z, int side, float xOffset, float yOffset, float zOffSet){
        if (!world.isRemote && item.getItemDamage() == 0){
        	if(world.getBlockId(x, y, z) == ObscuraCraft.camera.blockID){
        		if(world.getBlockMetadata(x, y, z) == 4){
        			y--;
        		}
        		int meta = world.getBlockMetadata(x, y, z);
        		world.setBlockMetadataWithNotify(x, y, z, 4, 0x02);
        		world.setBlockMetadataWithNotify(x, y, z, meta, 0x02);
        		TileEntityObscura tl = (TileEntityObscura)world.getBlockTileEntity(x, y, z);
        		tl.filled = true;
        		BlockObscura.takePhoto(player);
            	if (!player.capabilities.isCreativeMode){--item.stackSize;}
            	player.inventory.addItemStackToInventory(new ItemStack(ObscuraCraft.icamera));
            	return true;
        	}
	}
        return false;
    }

 

after

player.inventory.addItemStackToInventory(new ItemStack(ObscuraCraft.icamera));

use this:

player.inventoryContainer.detectAndSendChanges();

 

It sends the changes you made in the players inventory on the server to the client.

 

Also you should define a quantity in your ItemStack like this: new ItemStack(ObscuraCraft.icamera, 1)

[Naiten]

use this:

player.inventoryContainer.detectAndSendChanges();

It sends the changes you made in the players inventory on the server to the client.

Also you should define a quantity in your ItemStack like this: new ItemStack(ObscuraCraft.icamera, 1)

Thanks.

And, i actually should not. ItemStack has a constructor without quantity that automatically sets it to 1.

[SanAndreaP]

use this:

player.inventoryContainer.detectAndSendChanges();

It sends the changes you made in the players inventory on the server to the client.

Also you should define a quantity in your ItemStack like this: new ItemStack(ObscuraCraft.icamera, 1)

Thanks.

And, i actually should not. ItemStack has a constructor without quantity that automatically sets it to 1.

 

Oh, didn't know that. Well then not