[1.15.2] GlobalLootModifier not working

[Sinhika 7]

After explanations from Draco18s (which, with his permission, I have documented for future use here: How to use Global Loot Modifiers ), I have tried to implement a loot_modifier that looks for the modded shears items defined in my SimpleOres mod, and then regenerates the loot table as if they were silk touch items (or real minecraft:shears, I have tried both). The goal is to implement modded shears in a other-mod-friendly fashion; overriding vanilla loot tables, the only way I was able to do it previously, is extremely unfriendly to other mods.

 

The mod source code in question is here: https://github.com/Sinhika/SimpleOres2

The loot modifier stuff is in https://github.com/Sinhika/SimpleOres2/blob/1.15/src/main/java/mod/alexndr/simpleores/helpers/SimpleOresLootModifiers.java

(Don't want to clutter up this post with lots of source code).

It is registered (along with everything else) in https://github.com/Sinhika/SimpleOres2/blob/1.15/src/main/java/mod/alexndr/simpleores/ModEventSubscriber.java

 

I've cut down the loot_modifier/mod_shears_harvest.json to a minimal test case, like so:

{
	"conditions": [
		{
			"condition": "minecraft:match_tool",
			"predicate": {
				"item": "simpleores:copper_shears"
			}
		}
	]
}

Based on the logs, or lack thereof, the function is being registered, but isn't being called when it ought to be.

Can anyone see any reason why, when I whack a leaf block with the copper shears, the loot modifier function isn't being called?

Edited April 6 by Sinhika
line breaks messed up looks

[Draco18s 2335]

Your code looks fine, my guess is that the tool predicate is returning false. Ie. that the item you're using doesn't match "simpleores:copper_shears"

 

Double check your registry names.

 

Scratch that, this file is in the wrong folder:

https://github.com/Sinhika/SimpleOres2/blob/1.15/src/main/resources/data/forge/global_loot_modifiers/global_loot_modifiers.json

Should be forge/loot_modifiers not forge/global_loot_modifiers.

Edited April 6 by Draco18s

[Sinhika 7]

That does appear to have been the problem! Going on to test with some further refinements. Thank you.