Jump to content

[1.15.2] TileEntity in Client Side can't read the NBT Data.


Recommended Posts

Posted (edited)

I write a TileEntity which holds the data in Server side. The server side data sync to client side by getUpdatePacket and onDataPacket. If I exit the

Game save and enter it again, The Client Side TileEntity can't get NBT data by read(CompoundNBT compound). But after l put or get Item from the TileEntity, the Data will be synced. How can I let the Client Side TileEntity get the NBT data when the Saves load.

Here is my code.

AlchemyFurnaceBlockEntity.java

package com.otakusaikou.spiritcraft.block.blockentity;

import com.otakusaikou.spiritcraft.registry.BlockEntityTypeRegistry;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.CompoundNBT;
import net.minecraft.nbt.INBT;
import net.minecraft.nbt.ListNBT;
import net.minecraft.network.NetworkManager;
import net.minecraft.network.play.server.SUpdateTileEntityPacket;
import net.minecraft.tileentity.ITickableTileEntity;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.Direction;
import net.minecraftforge.common.util.Constants;

import javax.annotation.Nullable;
import java.util.HashMap;
import java.util.Map;

public class AlchemyFurnaceBlockEntity extends TileEntity implements ITickableTileEntity {
    private final Map<Direction, ItemStack> itemStackMap = new HashMap<>();
    private int i = 10;

    public AlchemyFurnaceBlockEntity() {
        super(BlockEntityTypeRegistry.alchemyFurnaceBlockEntityType.get());
    }

    public Map<Direction, ItemStack> getItemStackMap() {
        return itemStackMap;
    }

    public boolean putItem(Direction direction, Item item) {
        if (itemStackMap.containsKey(direction)) {
            return false;
        }
        ItemStack itemStack = new ItemStack(item);
        itemStackMap.put(direction, itemStack);
        world.notifyBlockUpdate(pos, getBlockState(), getBlockState(), Constants.BlockFlags.BLOCK_UPDATE);
        markDirty();
        return true;
    }

    public boolean isExist(Direction direction) {
        return itemStackMap.containsKey(direction);
    }

    public ItemStack getItem(Direction direction) {
        ItemStack itemStack = itemStackMap.get(direction);
        itemStackMap.remove(direction);
        world.notifyBlockUpdate(pos, getBlockState(), getBlockState(), Constants.BlockFlags.BLOCK_UPDATE);
        markDirty();
        return itemStack;
    }

    @Nullable
    @Override
    public SUpdateTileEntityPacket getUpdatePacket() {
        ListNBT listNBT = new ListNBT();
        for (Map.Entry<Direction, ItemStack> entry : itemStackMap.entrySet()) {
            CompoundNBT compoundNBT = new CompoundNBT();
            compoundNBT.putString("direction", entry.getKey().getName());
            compoundNBT.put("itemstack", entry.getValue().serializeNBT());
            listNBT.add(compoundNBT);
        }
        CompoundNBT compoundNBT = new CompoundNBT();
        compoundNBT.put("stacks", listNBT);
        return new SUpdateTileEntityPacket(pos, 1, compoundNBT);
    }

    @Override
    public void onDataPacket(NetworkManager net, SUpdateTileEntityPacket pkt) {
        if (world.isRemote) {
            CompoundNBT compoundNBT = pkt.getNbtCompound();
            INBT inbt = compoundNBT.get("stacks");
            if (inbt instanceof ListNBT) {
                ListNBT listNBT = (ListNBT) inbt;
                for (int i = 0; i < listNBT.size(); i++) {
                    CompoundNBT tag = (CompoundNBT) listNBT.get(i);
                    Direction direction = getDirection(tag.getString("direction"));
                    ItemStack itemStack = ItemStack.read(tag.getCompound("itemstack"));
                    itemStackMap.put(direction, itemStack);
                    markDirty();
                }
            }
        }
    }

    private Direction getDirection(String name) {
        for (Direction direction : Direction.values()) {
            if (direction.toString().equals(name)) {
                return direction;
            }
        }
        throw new IllegalArgumentException("Not find the direction");
    }

    @Override
    public void tick() {
//        if (!world.isRemote) {
//            if (i == 0) {
//                world.notifyBlockUpdate(pos, getBlockState(), getBlockState(), Constants.BlockFlags.BLOCK_UPDATE);
//                i = 10;
//            }
//            i--;
//        }
    }

    @Override
    public void read(CompoundNBT compound) {
        INBT inbt = compound.get("stacks");
        if (inbt instanceof ListNBT) {
            ListNBT listNBT = (ListNBT) inbt;
            for (int i = 0; i < listNBT.size(); i++) {
                CompoundNBT tag = (CompoundNBT) listNBT.get(i);
                Direction direction = getDirection(tag.getString("direction"));
                ItemStack itemStack = ItemStack.read(tag.getCompound("itemstack"));
                itemStackMap.put(direction, itemStack);
            }
        }
        super.read(compound);
    }

    @Override
    public CompoundNBT write(CompoundNBT compound) {
        ListNBT listNBT = new ListNBT();
        for (Map.Entry<Direction, ItemStack> entry : itemStackMap.entrySet()) {
            CompoundNBT compoundNBT = new CompoundNBT();
            compoundNBT.putString("direction", entry.getKey().getName());
            compoundNBT.put("itemstack", entry.getValue().serializeNBT());
            listNBT.add(compoundNBT);
        }
        compound.put("stacks", listNBT);
        return super.write(compound);
    }
}

 

AlchemyFurnace.java

package com.otakusaikou.spiritcraft.block;

import com.otakusaikou.spiritcraft.block.blockentity.AlchemyFurnaceBlockEntity;
import com.otakusaikou.spiritcraft.util.Utils;
import net.minecraft.block.Block;
import net.minecraft.block.BlockState;
import net.minecraft.block.material.Material;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.item.ItemStack;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.ActionResultType;
import net.minecraft.util.Direction;
import net.minecraft.util.Hand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.BlockRayTraceResult;
import net.minecraft.world.IBlockReader;
import net.minecraft.world.World;

import javax.annotation.Nullable;

public class AlchemyFurnace extends Block {

    public AlchemyFurnace() {
        super(Properties.create(Material.ROCK).harvestLevel(0).hardnessAndResistance(5).notSolid());
    }
    //TODO: change default the vertex shape

    @Override
    public boolean hasTileEntity(BlockState state) {
        return true;
    }

    @Nullable
    @Override
    public TileEntity createTileEntity(BlockState state, IBlockReader world) {
        return new AlchemyFurnaceBlockEntity();
    }

    @Override
    public ActionResultType onBlockActivated(BlockState state, World worldIn, BlockPos pos, PlayerEntity player, Hand handIn, BlockRayTraceResult hit) {
        if (Utils.isServerSide(worldIn) && handIn == Hand.MAIN_HAND) {
            TileEntity tileEntity = worldIn.getTileEntity(pos);
            Direction face = hit.getFace();
            if (tileEntity instanceof AlchemyFurnaceBlockEntity) {
                AlchemyFurnaceBlockEntity alchemyFurnaceBlockEntity = (AlchemyFurnaceBlockEntity) tileEntity;
                ItemStack inputItemStack = player.getHeldItem(Hand.MAIN_HAND);
                if (inputItemStack.isEmpty()) {
                    if (alchemyFurnaceBlockEntity.isExist(face)) {
                        ItemStack itemStack = alchemyFurnaceBlockEntity.getItem(face);
                        player.setHeldItem(Hand.MAIN_HAND, itemStack);
                    }
                } else {
                    ItemStack handItem = player.getHeldItem(Hand.MAIN_HAND);
                    if (alchemyFurnaceBlockEntity.putItem(face, handItem.getItem())) {
                        if (handItem.getCount() > 1) {
                            handItem.setCount(handItem.getCount() - 1);
                            player.setHeldItem(Hand.MAIN_HAND, handItem);
                        } else {
                            player.setHeldItem(Hand.MAIN_HAND, ItemStack.EMPTY);
                        }
                    }
                }
            }

        }
        return ActionResultType.SUCCESS;
    }
}

 

Edited by FledgeXu
Posted

Hi

This example project might help (mbe20)

https://github.com/TheGreyGhost/MinecraftByExample

 

You are probably missing one of these methods:

// When the world loads from disk, the server needs to send the TileEntity information to the client

// it uses getUpdatePacket(), getUpdateTag(), onDataPacket(), and handleUpdateTag() to do this:

// getUpdatePacket() and onDataPacket() are used for one-at-a-time TileEntity updates

// getUpdateTag() and handleUpdateTag() are used by vanilla to collate together into a single chunk update packet

 

Cheers

  

  TGG

  • Like 1
Posted (edited)
30 minutes ago, TheGreyGhost said:

Hi

This example project might help (mbe20)

https://github.com/TheGreyGhost/MinecraftByExample

 

You are probably missing one of these methods:

// When the world loads from disk, the server needs to send the TileEntity information to the client

// it uses getUpdatePacket(), getUpdateTag(), onDataPacket(), and handleUpdateTag() to do this:

// getUpdatePacket() and onDataPacket() are used for one-at-a-time TileEntity updates

// getUpdateTag() and handleUpdateTag() are used by vanilla to collate together into a single chunk update packet

 

Cheers

  

  TGG

Thanks Grey.
I just solved this problem. I forge to override the getUpdateTag.
Thank you anyway

Edited by FledgeXu

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Without Network protocol fix mod, I get kicked with a Network Protocol error when on LAN. Also, both of these issues are caused by a Null Pointer Exception/Screen cannot be null in a "Client Bound Player Combat Kill Packet".
    • You need a new "items" folder at  resources/assets/yourmodid/ there you add for every item model a .json file with the exact item/block name and fill it like this if it's an item: { "model": { "type": "minecraft:model", "model": "yourmodid:item/youritem" } } and so if its a block: { "model": { "type": "minecraft:model", "model": "yourmodid:block/youritem" } } There is also a generator for it you can do namy crazy things with it which replaces the previous hard coded Item Properties implementaion method (Bow pulling animation for example). https://misode.github.io/assets/item/
    • Hello! I'm playing a modpack (custom made) with some friends, and we have the server running on BisectHosting. We encountered a bug with an entity from The Box Of Horrors mod, that would crash the game whenever someone nearby it would log in. We tried to fix it by: 1) Editing the player.dat files to change the location of the affected players (something I had done successfully previously) 2) Updating the version of the mod we had (0.0.8.2) to the latest alpha version (0.0.8.3 However, after doing both of those, none of us are able to join the server, and we get the following errors: Server side: https://pastebin.com/J5sc3VQN Client side: Internal Server Error (that's basically all I've gotten) Please help! I've tried restoring the player data to how it was before I made the changes (Bisect allows you to restore deleted files) and deleting all of my player data files and I still get the same error. Deleting Box Of Horrors causes the error: Failed to load datapacks, cannot continue with server load.
    • Hey there! I'm trying to create a simple mod for Forge 1.21.1 that adds a few custom banner patterns that don't require any banner pattern items. To be completely honest, this is my first time modding for Minecraft, so after setting up the project in Intellij, I copied the parts of the source code from this mod on CurseForge that dealt with adding and registering banner patterns, including the lang and banner_pattern .json files. From what I understand, to add a banner pattern that doesn't require a banner pattern item, I only needed to create the registries for each pattern like in here and then register it in the main java class like here on Line 54. Additionally, in the lang/en_us.json file, add in the names for each respective banner color, and in the data/minecraft/tags/banner_pattern/no_items_required.json file, add each banner pattern that does not require a banner pattern item to make a banner. The project is able to compile when loading in Forge which makes me assume that the file structure I have is correct, but on loading a Minecraft world, this error appears in console and the loom is subsequently blank. [Worker-Main-1/ERROR] [minecraft/TagLoader]: Couldn't load tag minecraft:no_item_required as it is missing following references: *lists every added entry in no_item_required.json* The message clearly states something went wrong regarding when trying to load in the registries from the mod, but I have no clue what could be wrong with the code I have. Attached below are screenshots of what I currently have. Java Main Class Banner Registry Class File Structure Error in Console upon loading a Minecraft world What the loom shows without minecraft:no_item_required    The original mod I copied still functions completely, so if anyone can figure out why the registries for the mod I'm making isn't working, that would be greatly appreciated!    
    • Please someone help me to know how can I fix this generation error in the trees! I already uninstalled and reinstalled several mods in my modpack and can't figure out what is causing it.    
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.