[1.15.2] How to get Registry ids?

[Axspeo]

Quick question,

if

Registry.BIOME.getId(BiomeInit.TEST_BIOME)

is deprecated

What is the correct way to get the registry Id of a Biome on 1.15?

 

Thanks in Advance!

[imacatlolol]

Why do you need the integer id? Integer ids are unreliable and should almost never be used.

In any case, Registry is only really meant for vanilla's use. ForgeRegistries is what you would use to access registries.

[Axspeo]

1 hour ago, imacatlolol said:

Why do you need the integer id? Integer ids are unreliable and should almost never be used.

In any case, Registry is only really meant for vanilla's use. ForgeRegistries is what you would use to access registries.

Was checking Twilight Forest Source code and found it here.

That's why I was asking

[QuantumSoul]

1 hour ago, imacatlolol said:

Why do you need the integer id? Integer ids are unreliable and should almost never be used.

In any case, Registry is only really meant for vanilla's use. ForgeRegistries is what you would use to access registries.

In my custom BiomeProvider I have to use a custom layer which looks like this:

public class CustomLayer implements IC0Transformer
{
    @Override
    public int apply(INoiseRandom context, int value)
    {
     	 return Registry.BIOME.getId(BiomeInit.CUSTOM_BIOME)
    }
}

How can I do without using Minecraft Registry IDs ?

[Axspeo]

11 minutes ago, QuantumSoul said:

In my custom BiomeProvider I have to use a custom layer which looks like this:

public class CustomLayer implements IC0Transformer
{
    @Override
    public int apply(INoiseRandom context, int value)
    {
     	 return Registry.BIOME.getId(BiomeInit.CUSTOM_BIOME)
    }
}

How can I do without using Minecraft Registry IDs ?

bruh that was my question already

[imacatlolol]

16 minutes ago, QuantumSoul said:

How can I do without using Minecraft Registry IDs ?

27 minutes ago, Axspeo said:

Was checking Twilight Forest Source code and found it here.

That's why I was asking

Ah, I see. I'm not super familiar with world gen, but I think this is one of those rare cases where using the numerical IDs is actually necessary, you both were right in the first place.

I looked at a couple other major world-gen mods (Betweenlands and Midnight) and they seem to do the same thing, so I don't believe there's any issues with using the vanilla registry here.

As for the deprecation warning itself, you can use the SupressWarnings annotation; though you may want to add a comment about why the suppression is needed for your own future reference.

Edited May 13, 2020 by imacatlolol
Typo

[QuantumSoul]

6 minutes ago, Axspeo said:

bruh that was my question already

I feel like we both work on the same kind of mod lmao

[QuantumSoul]

4 minutes ago, imacatlolol said:

Ah, I see. I'm not super familiar with world gen, but I think this is one of those rare cases where using the numerical IDs is actually necessary, you both were right in the first place.

I looked at a couple other major world-gen mods (Betweenlands and Midnight) and they seem to do the same thing, so I don't believe there's any issues with using the vanilla registry here.

As for the deprecation warning itself, you can use the SupressWarnings annotation; though you may want to add a comment about why the suppression is needed for your own future reference.

I think if we want to use ForgeRegistries, we have to create a LOT of new classes just to solve that one layer problem

[imacatlolol]

1 minute ago, QuantumSoul said:

I think if we want to use ForgeRegistries, we have to create a LOT of new classes just to solve that one layer problem

I don't think you would. You'd probably just have to cast the IForgeRegistry to ForgeRegistry and use its getID method, but I'm just assuming that it would return the same result.

It certainly wouldn't be any more difficult to work with, I'm sure.

[QuantumSoul]

1 minute ago, imacatlolol said:

I don't think you would. You'd probably just have to cast the IForgeRegistry to ForgeRegistry and use its getID method, but I'm just assuming that it would return the same result.

It certainly wouldn't be any more difficult to work with, I'm sure.

Isn't it another ID ?

[imacatlolol]

6 minutes ago, QuantumSoul said:

Isn't it another ID ?

Ran a quick test, both registries seem to return the same IDs, which makes sense all things considered.

So, both the vanilla and forge registries would work for this purpose, unless I'm missing something. In the end I believe it would just be personal preference; most modders seem to use the vanilla registry, but using the forge registry may be preferred by the forge team.

[DavidM]

6 hours ago, imacatlolol said:

So, both the vanilla and forge registries would work for this purpose, unless I'm missing something. In the end I believe it would just be personal preference; most modders seem to use the vanilla registry, but using the forge registry may be preferred by the forge team.

Using the Forge method would indeed be preferred.

My thought on the matter is:

Vanilla methods that are marked deprecated means they should not be called by outside methods. Due to this, the method can be removed at any time by Mojang or Forge without undergoing the "oh look I'm deprecated, that means I will get removed in the next version; your IDE should be shouting at you to use the newly introduced approach instead!" Therefore the Forge provided method is often considered a better approach and often more future-proof.