[1.15.2] Custom Dimensions, isNightTime

[Guest]

When doing custom dimensions it is possible to overload the "isDaytime()" function in the dimension to control whether it is day or not. This function is then called in the world.

The problem is that Vanilla also added an inverse function to the world: isNightTime

Right now the function has a hardcoded check if the dimension is the overworld, which prevents custom dimensions from returning the right value. The new function is only used by bees which therefore work incorrectly in custom dimensions.

 

I would suggest delegating isNightTime to the dimension as for isDayTime or at least setting the function to the opposite of the isDaytime function.

[Novârch]

Why...? Just use !isDaytime.

[Guest]

No that does not work. As mentioned: Vanilla is calling isNightTime not me.

And therefore as I wrote: Bees do not work correctly in custom dimensions.

[Curle]

I'm going to look into this for a little. It should be as simple as a quick patch on the isNightTime function. Let's see.

 

[Curle]

I've opened a pull request, we'll see if the change is merged.

https://github.com/MinecraftForge/MinecraftForge/pull/6821