[1.15.2] [SOLVED] Usage of Capabilities to make an Inventory

[GenElectrovise]

Solution:

https://www.minecraftforge.net/forum/topic/85745-1152-usage-of-capabilities-to-make-an-inventory/?do=findComment&comment=403277

Be sure to reference the rest of the thread though!

 

===

 

Hello all. I am trying to make a block (Altar) which the player will be able to interact with. I have already made an GUI for it using this very helpful post and by using the enchantment table's own code. The downside of using said enchantment table code is that it does not use the Capability system which the forge documentation promotes. My current inventory (*contained* in ContainerAltar in my repo) mostly works -- the player's inventory is displayed correctly and can be interacted with, but any items which I place into the Altar's 4 Slots vanish when the GUI is closed (kind of understandable considering I'm doing nothing to persist the data. I think this is where IItemHandler comes in?).I have fiddled a bit with Capabilities before, but never had much success, so before I end up writing something bodged and half-working etc., I though I'd get some advice.

 

How can I use the Capability system (if that is even the best way!) to:

- create an inventory with 4 slots which the player can interact with through my GUI

- ... which will persist inside the Altar across openings.

 

GitHub: Here is the Github repo

Directly to the Altar package: ... and here is the package in question

 

Many thanks in advance!

Edited May 19, 2020 by GenElectrovise
solved

[GenElectrovise]

Also, can anyone suggest how I could not use BlockContainer, as I do currently? Was just reviewing Common Issues and found:

Quote

Problematic Code #4: Do not use ITileEntityProvider or BlockContainer. These classes are legacy vanilla code. To add a TileEntity to your Block, override hasTileEntity and createTileEntity in your Block class. 

 

[Draco18s]

15 minutes ago, GenElectrovise said:

Also, can anyone suggest how I could not use BlockContainer, as I do currently? Was just reviewing Common Issues and found:

Correct. BlockContainer from vanilla sets up a bunch of defaults that you do not want or need. One of the most common was setting the model render type to invisible (because vanilla would have special case renderers for its containers, like the chest) and people would post a question every week about why their custom chest won't render.

 

So yes. Extend block and override only the methods you need to override, namely has- and getTileEntity()

 

https://github.com/GenElectrovise/MagiksMostEvile/blob/1.15.2/src/main/java/genelectrovise/magiksmostevile/common/tileentity/altar/AltarTileEntity.java#L29

You do not need to implement ICapabilityProvider here, TileEntity already implements it. You aren't even overriding getCapability().

 

https://github.com/GenElectrovise/MagiksMostEvile/blob/1.15.2/src/main/java/genelectrovise/magiksmostevile/common/tileentity/altar/AltarTileEntity.java#L31-L32

This does nothing useful for you.

 

You want this:

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/harderores/entity/SifterTileEntity.java#L39

This:

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/harderores/entity/SifterTileEntity.java#L42

And this:

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/harderores/entity/SifterTileEntity.java#L145-L172

Edited May 18, 2020 by Draco18s

[GenElectrovise]

Ok, @Draco18s, I have added 

3 hours ago, Draco18s said:

this

 

3 hours ago, Draco18s said:

This

 

3 hours ago, Draco18s said:

And this

and pushed the changes to GitHub, but as yet, I can't test the new functionality as I believe ICustomContainer, which you are using to open the container has been removed between 1.14 and 1.15.2 (I believe your repo is 1.14.x?). What has it been replaced by? I can't seem to find any useful sounding interfaces with "Container" or "Gui" in the name...  

 

Am revising this right now

Edited May 18, 2020 by GenElectrovise
revising this

[Draco18s]

ICustomContainer is my own interface.

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/hardlib/api/interfaces/ICustomContainer.java

Its not even all that relevant here.

[GenElectrovise]

Yup found that  . CommonContainer is as well -- very helpful class!

All is looking good *so far*, but yet again I am wrestling with DeferredRegistry... Where is your registry in your repo? The error I am recieving is that "The constructor ContainerType<AltarContainer>(AltarContainer::new) is undefined". How are you registering yours?

 

Another hidded error is that "- The type AltarContainer does not define AltarContainer(int, PlayerInventory) that is applicable here". That could be fixed by adding another constructor with the applicable arguments, but what could I pass in as the PacketBuffer / IItemHandler and AltarTileEntity to get into another of my constructors...

Edited May 18, 2020 by GenElectrovise
more info

[Draco18s]

6 minutes ago, GenElectrovise said:

Where is your registry in your repo?

My code dates before DeferredRegister, so I haven't gotten a chance to mess around with it.

But here's where I do the needful:

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/harderores/HarderOres.java#L165

The method call to EasyRegistry there just shoves the value passed into a list and waits for the RegistryEvent.Register<T> for some the appropriate T and then registers the value.

It looks complicated, but only because I've got a thousand helpers that do various things to make my life easier in my actual mods,* but here's the relevant helper and event:

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/hardlib/EasyRegistry.java#L113-L136

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/hardlib/EasyRegistry.java#L195-L200

Mod Data Fixers do exist now, but as I said, I haven't really worked on things in a while.

That should all still be the same sorts of stuff you need to do.

 

*I definitely do not recommend doing things like this any more. My way is based on my own personal preferences for liking a clean-looking mod class and have shoved all the wonky aspects off into my EasyRegistry where I don't need to look at them. DeferredRegister has probably cleaned this up, I just haven't played with it.

[GenElectrovise]

Ironically, I found all of these just before I saw the message. For the moment, if you don't know how to register a ContainerType with DeferredRegister, where would one set the registry name of the ContainerType to be registered? EasyRegistry does it at https://github.com/Draco18s/ReasonableRealism/blob/033da26f8ba4bcd25b0911aa9775764f12d7dbbe/src/main/java/com/draco18s/hardlib/EasyRegistry.java#L89, but this to me doesn't seem to be what I need, given that I'm not using your EasyRegistry system. To set it in the event, I'd need an object to call the method on. Constructor is a no-go because it's called later... Any ideas?

[GenElectrovise]

Ahh! But I overthink and forget! I *do* have an object! What else am I registering!? 

 

Now I get an error when I try to open the GUI... Can't find the right ContainerType ? Looks to be something to do with NetworkHooks not being able to "Unable to construct this menu by type"  (seems pretty obvious). I'm passing in a ServerPlayerEntity, AltarTileEntity and the TileEntity's position. Have to check if one of them is null, but I'd expect NullPointerExceptions then, not this...

Spoiler

java.lang.UnsupportedOperationException: Unable to construct this menu by type
    at net.minecraft.inventory.container.Container.getType(Container.java:52) ~[?:?] {re:classloading}
    at net.minecraftforge.fml.network.NetworkHooks.openGui(NetworkHooks.java:207) ~[?:?] {re:classloading}
    at net.minecraftforge.fml.network.NetworkHooks.openGui(NetworkHooks.java:172) ~[?:?] {re:classloading}
    at genelectrovise.magiksmostevile.common.tileentity.altar.AltarTileEntity.openGUI(AltarTileEntity.java:133) ~[?:?] {re:classloading}
    at genelectrovise.magiksmostevile.common.tileentity.altar.AltarBlock.onBlockActivated(AltarBlock.java:120) ~[?:?] {re:classloading}
    at net.minecraft.block.BlockState.onBlockActivated(BlockState.java:294) ~[?:?] {re:classloading}
    at net.minecraft.server.management.PlayerInteractionManager.func_219441_a(PlayerInteractionManager.java:343) ~[?:?] {re:classloading}
    at net.minecraft.network.play.ServerPlayNetHandler.processTryUseItemOnBlock(ServerPlayNetHandler.java:881) ~[?:?] {re:classloading}
    at net.minecraft.network.play.client.CPlayerTryUseItemOnBlockPacket.processPacket(CPlayerTryUseItemOnBlockPacket.java:45) ~[?:?] {re:classloading}
    at net.minecraft.network.play.client.CPlayerTryUseItemOnBlockPacket.processPacket(CPlayerTryUseItemOnBlockPacket.java:12) ~[?:?] {re:classloading}
    at net.minecraft.network.PacketThreadUtil.lambda$checkThreadAndEnqueue$0(PacketThreadUtil.java:19) ~[?:?] {re:classloading}
    at net.minecraft.util.concurrent.TickDelayedTask.run(TickDelayedTask.java:20) ~[?:?] {re:classloading}
    at net.minecraft.util.concurrent.ThreadTaskExecutor.run(ThreadTaskExecutor.java:140) [?:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.util.concurrent.RecursiveEventLoop.run(RecursiveEventLoop.java:22) [?:?] {re:classloading}
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:759) [?:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:141) [?:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.util.concurrent.ThreadTaskExecutor.driveOne(ThreadTaskExecutor.java:110) [?:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.server.MinecraftServer.driveOneInternal(MinecraftServer.java:742) [?:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.server.MinecraftServer.driveOne(MinecraftServer.java:736) [?:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.util.concurrent.ThreadTaskExecutor.driveUntil(ThreadTaskExecutor.java:123) [?:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.server.MinecraftServer.runScheduledTasks(MinecraftServer.java:722) [?:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:666) [?:?] {re:classloading,pl:accesstransformer:B}
    at java.lang.Thread.run(Thread.java:748) [?:1.8.0_241] {}

Time for a break. I'll resume this tomorrow. Many thanks!

Edited May 18, 2020 by GenElectrovise
added error

[Draco18s]

You're trying to register a ContainerType, and to do that you need to specify your TE's constructor that takes no paremeters.

[GenElectrovise]

 

All working! I used DeferredRegister again instead of RegistryEvents, as I could reuse the code from before.

For anyone who is having the same issues, this post helped with the last error. The relevant classes on my Github are in this package for the Altar classes. and this package for my registry.

Thanks @Draco18s! Great EasyRegistry, but you might want to update that sometime . You don't seem like a "complete and utter jerk" to me!

 

-- Remember to override the read and write methods to your TileEntity if you want data to be persisted through saves! Examples are on both mine and @Draco18s's GitHubs repos

 

If I think of any more helpful things for people with this problem, I'll add them here.

 

Ps. How do I close this thread? Can only moderators do that?

Edited May 19, 2020 by GenElectrovise
helpful hint #1

[Draco18s]

6 hours ago, GenElectrovise said:

but you might want to update that sometime

Its on my ever growing list of TODOs. But at the moment it isn't broken, and other things are, so its low priority.

Quote

Ps. How do I close this thread? Can only moderators do that?

There really isn't a point to doing so. You can put "solved" in the title if you want, but locking a thread is a moderator tool.

Its a forum, threads are to remain open by default.

Edited May 19, 2020 by Draco18s