Should I add server check on item ?

[QuantumSoul]

Here's my custom item Item#onItemRightClick override:

    @Override
    public ActionResult<ItemStack> onItemRightClick(World worldIn, PlayerEntity playerIn, Hand handIn)
    {
        ItemStack stack = playerIn.getHeldItem(handIn);
        if(!(playerIn.abilities.isCreativeMode))
            stack.shrink(1);

        return ActionResult.resultConsume(stack);
    }

Should I add a !world.isRemote ?

If so, how what ActionResult should I return ?

 

Thanks in advance;

 

 

[DavidM]

If something actually affects the game (like changes to the world, as well as inventory), then it should be done on the server.

Think to yourself "if the player can freely edit this value/call this function, would that affect other players as well as bring an unfair advantage/disadvantage?" If yes, then throw it on the server.

Edited May 20, 2020 by DavidM

[QuantumSoul]

5 hours ago, DavidM said:

If something actually affects the game (like changes to the world, as well as inventory), then it should be done on the server.

Think to yourself "if the player can freely edit this value/call this function, would that affect other players as well as bring an unfair advantage/disadvantage?" If yes, then throw it on the server.

I checked that method on vanilla examples and they do the check to summon entities but don't to shrink itemstack. But it seemed weird that's why I asked;