Posted May 19, 20205 yr Here's my custom item Item#onItemRightClick override: @Override public ActionResult<ItemStack> onItemRightClick(World worldIn, PlayerEntity playerIn, Hand handIn) { ItemStack stack = playerIn.getHeldItem(handIn); if(!(playerIn.abilities.isCreativeMode)) stack.shrink(1); return ActionResult.resultConsume(stack); } Should I add a !world.isRemote ? If so, how what ActionResult should I return ? Thanks in advance;
May 20, 20205 yr If something actually affects the game (like changes to the world, as well as inventory), then it should be done on the server. Think to yourself "if the player can freely edit this value/call this function, would that affect other players as well as bring an unfair advantage/disadvantage?" If yes, then throw it on the server. Edited May 20, 20205 yr by DavidM Some tips: Spoiler Modder Support: Spoiler 1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code. 2. Always post your code. 3. Never copy and paste code. You won't learn anything from doing that. 4. Quote Programming via Eclipse's hotfixes will get you nowhere 5. Learn to use your IDE, especially the debugger. 6. Quote The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it. Support & Bug Reports: Spoiler 1. Read the EAQ before asking for help. Remember to provide the appropriate log(s). 2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.
May 20, 20205 yr Author 5 hours ago, DavidM said: If something actually affects the game (like changes to the world, as well as inventory), then it should be done on the server. Think to yourself "if the player can freely edit this value/call this function, would that affect other players as well as bring an unfair advantage/disadvantage?" If yes, then throw it on the server. I checked that method on vanilla examples and they do the check to summon entities but don't to shrink itemstack. But it seemed weird that's why I asked;
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.