[1.15.2] Custom Feature Register

[Axspeo]

Hi guys I was trying to register a custom feature and I created a "FeatureInit" class with:

Spoiler

public class FeatureInit {
	public static final DeferredRegister<Feature<?>> FEATURES = new DeferredRegister<>(ForgeRegistries.FEATURES, ExampleMod.MOD_ID);

	public static final RegistryObject<Feature<BlockStateFeatureConfig>> TEST_LAKE = FEATURES.register("feature_test_lake", () -> new TestLake(BlockStateFeatureConfig::deserialize));
}

 

Also my "Main" class:

Spoiler

public class ExampleMod {
    public static ExampleMod instance;
    public static final String MOD_ID = "examplemod";

    public ExampleMod() {
        final IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus();

        FeatureRegister.FEATURES.register(modEventBus);
        BiomeRegister.BIOMES.register(modEventBus);

        instance = this;

        MinecraftForge.EVENT_BUS.register(this);
    }

 

But when I build the game using that feature in a custom biome, it returns this error when the custom biome is registered:

Spoiler

[22:37:03] [Render thread/DEBUG] [ne.mi.fm.ja.FMLModContainer/LOADING]: Firing event for modid examplemod : RegistryEvent.Register<minecraft:biome>
[22:37:03] [Render thread/ERROR] [ne.mi.fm.ja.FMLModContainer/]: Exception caught during firing event: Registry Object not present
	Index: 4
	Listeners:
		0: NORMAL
		1: net.minecraftforge.eventbus.EventBus$$Lambda$2098/981716924@7833407
		2: net.minecraftforge.eventbus.EventBus$$Lambda$2098/981716924@66acaa54
		3: net.minecraftforge.eventbus.EventBus$$Lambda$2098/981716924@60739eca
		4: net.minecraftforge.eventbus.EventBus$$Lambda$2098/981716924@9ba167e
		5: net.minecraftforge.eventbus.EventBus$$Lambda$2098/981716924@17873842
		6: ASM: class com.axspeo.examplemod.ExampleMod onRegisterItems(Lnet/minecraftforge/event/RegistryEvent$Register;)V
java.lang.NullPointerException: Registry Object not present
	at java.util.Objects.requireNonNull(Objects.java:228)

 

Looks like it can't find the custom Feature, even tho I register it before I register the biomes

 

Edited May 21, 2020 by Axspeo
Moved error to spoiler tag

[Ugdhar]

There is no guarantee to registration order, except Blocks are first, Items second.

 

Add the feature to your biome in the FMLCommonSetupEvent and not in your biomes constructor. I am just guessing at this, since you only shared bits and pieces of code.

[Axspeo]

18 minutes ago, Ugdhar said:

There is no guarantee to registration order, except Blocks are first, Items second.

 

Add the feature to your biome in the FMLCommonSetupEvent and not in your biomes constructor. I am just guessing at this, since you only shared bits and pieces of code.

My Biome isn't a static class tho, how am I supposed to get the Biome instance inside FMLCommonSetupEvent?

 

EDIT: Isn't it possible to force biomes to be the last being registered?

Edited May 21, 2020 by Axspeo

[Ugdhar]

11 minutes ago, Axspeo said:

My Biome isn't a static class tho, how am I supposed to get the Biome instance inside FMLCommonSetupEvent?

 

EDIT: Isn't it possible to force biomes to be the last being registered?

As far as I know, nope.

 

And if you are registering your biome, you should have an instance of it somewhere, if not, make one.

[Axspeo]

5 minutes ago, Ugdhar said:

As far as I know, nope.

 

And if you are registering your biome, you should have an instance of it somewhere, if not, make one.

Lol my bad, ofc I have an instance of it... Thanks man you solved my problem! ?

[Axspeo]

On 5/22/2020 at 9:58 AM, diesieben07 said:

You will need to use DeferredWorkQueue in FMLCommonSetupEvent, biome features are not threadsafe.

Hey man sorry for taking so long to reply but I only saw your reply now.

I've been actually doing this without DeferredWorkQueue and I didn't see any problems, I decided to use it anyway like you told me to but I don't see any difference, can you please explain what does "not thread safe" means in this case? Thanks in advance

[Axspeo]

5 hours ago, diesieben07 said:

You won't see any problems until you run in a bigger modpack, where multiple mods will do this same thing. And even then it might sometimes work fine. Other times you might see random UnexpectedModificationExceptions show up from your or other (!!!) mods, even if those mods do it correctly. Other times you might see random structures just not being registered.

 

FMLCommonSetupEvent is fired on a threadpool, so your code runns concurrently with the other mods.

 

DeferredWorkQueue schedules something to run afterwards, on the main thread only.

Perfect explanation! Thanks