The matcher returns true, but then the getCraftingOutput does not run. Can you please help me?

Here is my mod
https://github.com/TallYate/Bedrock-Things-mod--unfinished-

Edited June 5, 20205 yr by TallYate

oops I typed "now" instead of "not"

8 hours ago, diesieben07 said:

Yes, nobody will ask for that recipe type. Vanilla only checks it's own recipe types.

I put a recipe that implements this in here: https://github.com/TallYate/Bedrock-Things-mod--unfinished-/blob/master/src/main/resources/data/bedrockthings/recipes/charged_diamond_pickaxe.json

 

The matches part works (I can tell because I made it log stuff),
the getRecipeOutput works (I can get a preview of the recipe),

and the getIngredients works (the correct ingredients are in the recipe preview).

But whenever matches returns true, getCraftingResult doesn't run at all. It doesn't log anything, and the crafting recipe doesn't work.

So how do I make the crafting table check for my recipe?

Where do I put that

You have to use ICraftingRecipe.

The crafting table container loads a crafting recipe with this line:

         Optional<ICraftingRecipe> optional = p_217066_1_.getServer().getRecipeManager().getRecipe(IRecipeType.CRAFTING, p_217066_3_, p_217066_1_);

I recently wanted to add a custom crafting type to a crafting table too, and it crashed because of a class cast exception, until I implemented ICraftingRecipe.

I changed it to ICraftingRecipe but still have the same issue

If you're still overriding getType, then you didn't really "fix" anything.

Thanks everyone, it works now!