Jump to content

[SOLVED] [1.15.2] Is there a way to get the world and the player holding an item?


Recommended Posts

Posted (edited)

I have created a new type of tool (a rather standard 3x3 mining tool). In its GetDestroySpeed function, I have made a way to get the tool to scan the entire 3x3 mining area and effectively use the hardness of the hardest block found in order to avoid exploits like using a cobblestone block to easily break obsidian:

	private PlayerEntity player = null;
	private World world = null;
	
	@Override
	public ActionResultType onItemUse(ItemUseContext context) {
		player = context.getPlayer();
		world = context.getWorld();
		Main.LOGGER.info("Player & World updated!");
		return super.onItemUse(context);
	}
	
	@Override
	public float getDestroySpeed(ItemStack stack, BlockState state) {
		float ogSpeed = super.getDestroySpeed(stack, state); //Get original speed

		if(player != null && world != null) {
			BlockRayTraceResult target = getTargetBlock(player, world);
			Direction targetFace = target.getFace();
			Vec3d targetAxisVector = new Vec3d(Math.abs(targetFace.getXOffset()), Math.abs(targetFace.getYOffset()), Math.abs(targetFace.getZOffset()));
			BlockPos pos = target.getPos();
			BlockPos[] donut = getBlockDonut(pos,targetAxisVector);
			
			//Set break speed based on harness of blocks in the 3x3 area being broken
			float maxHardness = state.getBlockHardness(null, null);
			for(BlockPos globalCheckPos : donut) {
				BlockState block = world.getBlockState(globalCheckPos);
				if(this.canHarvestBlock(block)) { //Check we can harvest the block, since non-harvestable blocks aren't broken by the hammer
					if(block.getBlockHardness(null, null) > maxHardness) {
						maxHardness = block.getBlockHardness(null, null);
					}
				}
			}
			//Multiply by state's hardness to nullify it, divide by maximum hardness found. This prevents exploits such as breaking obsidian quickly by placing dirt near it.
			float speed = (ogSpeed * state.getBlockHardness(null, null)) / maxHardness;
			Main.LOGGER.info(speed);
			return speed;
		} else {
			return ogSpeed;
		}
	}

The solution works if the player right-clicks something before breaking a block.

However, the way of acquiring the world and the player is extremely janky, I need a way of getting the player and the world from within the getDestroySpeed function else it's going to be extremely easy to exploit (and will almost definitely be completely broken in multiplayer). So is there a way to do that, or will I need to use a different solution?

In case it's needed, here are all the functions that this calls (I'm fairly sure this is all of them):

	private RayTraceResult getTarget(LivingEntity entity, World world) { //Function to get raytrace of where player is looking, necessary to enable 3x3 mining of hammer
		
		double reachDist = entity.getAttribute(PlayerEntity.REACH_DISTANCE).getValue(); //Get player's reach distance
		
		Vec3d pos = entity.getEyePosition(0F);
		Vec3d look = entity.getLook(0F);
		Vec3d rayTo = pos.add(look.x * reachDist, look.y * reachDist, look.z * reachDist);
		
		return world.rayTraceBlocks(new RayTraceContext(pos, rayTo, RayTraceContext.BlockMode.OUTLINE, RayTraceContext.FluidMode.NONE, entity));
	}
	
	private BlockRayTraceResult getTargetBlock(LivingEntity entity, World world) {
		return (BlockRayTraceResult) getTarget(entity, world);
	}
	
	private BlockPos[] getBlockDonut(BlockPos pos, Vec3d perpAxis) {
		Vec3d plane = new Vec3d(1, 1, 1).subtract(perpAxis);
		
		BlockPos[] donut = {};
		for(int x = (int) -plane.x; x <= (int) plane.x; x++) {
			for(int y = (int) -plane.y; y <= (int) plane.y; y++) {
				for(int z = (int) -plane.z; z <= (int) plane.z; z++) {
					if(!(x==0 && y==0 && z==0)) { //Don't try to break (0,0,0) because it was already broken to trigger onBlockDestroyed
						BlockPos localBreakPos = new BlockPos(x, y, z);
						BlockPos globalBreakPos = localBreakPos.add(pos);
						donut = Arrays.copyOf(donut, donut.length + 1);
						donut[donut.length-1] = globalBreakPos;
					}
				}
			}
		}
		return donut;
	}
	
	private void breakArea(World worldIn, BlockState state, BlockPos pos, Vec3d perpAxis, LivingEntity entityLiving) {
		BlockPos[] donut = getBlockDonut(pos, perpAxis); //Get donut of extra blocks to break
		
		for(BlockPos globalBreakPos : donut) { //Break them
			BlockState toBreak = worldIn.getBlockState(globalBreakPos);
			if(this.canHarvestBlock(toBreak)){
				worldIn.destroyBlock(globalBreakPos, true);
			}
		}
	}
	
	@Override
	public boolean canHarvestBlock(BlockState blockIn) {
		if(blockIn.getBlockHardness(null, null) == -1){
			return false;
		} else {
			return super.canHarvestBlock(blockIn);
		}
	}

 

Edited by TDplay
Solved, edited title to reflect that
Posted
8 minutes ago, TDplay said:

private PlayerEntity player = null;

private World world = null;

You can't do this. Items are singletons.

What happens if there are two players?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
3 hours ago, diesieben07 said:

Yes, OP's question was how to avoid this.

 

@TDplay You need to use PlayerEvent.BreakSpeed.

Thanks, managed to get it working as intended.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • The specific issue is that items in my inventory wont stack properly. For instance, if I punch a tree down to collect wood, the first block I collected goes to my hand. So when I punch the second block of wood to collect it, it drops, but instead of stacking with the piece of wood already in my hand, it goes to the second slot in my hotbar instead. Another example is that I'll get some dirt, and then when I'm placing it down later I'll accidentally place a block where I don't want it. When I harvest it again, it doesn't go back to the stack that it came from on my hotbar, where it should have gone, but rather into my inventory. That means that if my inventory is full, then the dirt wont be picked up even though there should be space available in the stack I'm holding. The forge version I'm using is 40.3.0, for java 1.18.2. I'll leave the mods I'm using here, and I'd appreciate it if anybody can point me in the right direction in regards to figuring out how to fix this. I forgot to mention that I think it only happens on my server but I&#39;m not entirely sure. PLEASE HELP ME! LIST OF THE MODS. aaa_particles Adorn AdvancementPlaques AI-Improvements AkashicTome alexsdelight alexsmobs AmbientSounds amwplushies Animalistic another_furniture AppleSkin Aquaculture aquamirae architectury artifacts Atlas-Lib AutoLeveling AutoRegLib auudio balm betterfpsdist biggerstacks biomancy BiomesOPlenty blockui blueprint Bookshelf born_in_chaos Botania braincell BrassAmberBattleTowers brutalbosses camera CasinoCraft cfm (MrCrayfish’s Furniture Mod) chat_heads citadel cloth-config Clumps CMDCam CNB cobweb collective comforts convenientcurioscontainer cookingforblockheads coroutil CosmeticArmorReworked CozyHome CrabbersDelight crashexploitfixer crashutilities Create CreativeCore creeperoverhaul cristellib crittersandcompanions Croptopia CroptopiaAdditions CullLessLeaves curios curiouslanterns curiouslights Curses' Naturals CustomNPCs CyclopsCore dannys_expansion decocraft Decoration Mod DecorationDelightRefurbished Decorative Blocks Disenchanting DistantHorizons doubledoors DramaticDoors drippyloadingscreen durabilitytooltip dynamic-fps dynamiclights DynamicTrees DynamicTreesBOP DynamicTreesPlus Easy Dungeons EasyAnvils EasyMagic easy_npc eatinganimation ecologics effective_fg elevatorid embeddium emotecraft enchantlimiter EnchantmentDescriptions EnderMail engineersdecor entityculling entity_model_features entity_texture_features epicfight EvilCraft exlinefurniture expandability explosiveenhancement factory-blocks fairylights fancymenu FancyVideo FarmersDelight fast-ip-ping FastSuite ferritecore finsandtails FixMySpawnR Forge Middle Ages fossil FpsReducer2 furnish GamingDeco geckolib goblintraders goldenfood goodall H.e.b habitat harvest-with-ease hexerei hole_filler huge-structure-blocks HunterIllager iammusicplayer Iceberg illuminations immersive_paintings incubation infinitybuttons inventoryhud InventoryProfilesNext invocore ItemBorders itemzoom Jade jei (Just Enough Items) JetAndEliasArmors journeymap JRFTL justzoom kiwiboi Kobolds konkrete kotlinforforge lazydfu LegendaryTooltips libIPN lightspeed lmft lodestone LongNbtKiller LuckPerms Lucky77 MagmaMonsters malum ManyIdeasCore ManyIdeasDoors marbledsarsenal marg mcw-furniture mcw-lights mcw-paths mcw-stairs mcw-trapdoors mcw-windows meetyourfight melody memoryleakfix Mimic minecraft-comes-alive MineTraps minibosses MmmMmmMmmMmm MOAdecor (ART, BATH, COOKERY, GARDEN, HOLIDAYS, LIGHTS, SCIENCE) MobCatcher modonomicon mods_optimizer morehitboxes mowziesmobs MutantMonsters mysticalworld naturalist NaturesAura neapolitan NekosEnchantedBooks neoncraft2 nerb nifty NightConfigFixes nightlights nocube's_villagers_sell_animals NoSeeNoTick notenoughanimations obscure_api oculus oresabovediamonds otyacraftengine Paraglider Patchouli physics-mod Pillagers Gun PizzaCraft placeableitems Placebo player-animation-lib pneumaticcraft-repressurized polymorph PrettyPipes Prism projectbrazier Psychadelic-Chemistry PuzzlesLib realmrpg_imps_and_demons RecipesLibrary reeves-furniture RegionsUnexplored restrictedportals revive-me Scary_Mobs_And_Bosses selene shetiphiancore ShoulderSurfing smoothboot
    • Hi everyone, I'm currently developing a Forge 1.21 mod for Minecraft and I want to display a custom HUD overlay for a minigame. My goal: When the game starts, all players should see an item/block icon (from the base game, not a custom texture) plus its name/text in the HUD – similar to how the bossbar overlay works. The HUD should appear centered above the hotbar (or at a similar prominent spot), and update dynamically (icon and name change as the target item changes). What I've tried: I looked at many online tutorials and several GitHub repos (e.g. SeasonHUD, MiniHUD), but most of them use NeoForge or Forge versions <1.20 that provide the IGuiOverlay API (e.g. implements IGuiOverlay, RegisterGuiOverlaysEvent). In Forge 1.21, it seems that neither IGuiOverlay nor RegisterGuiOverlaysEvent exist anymore – at least, I can't import them and they are missing from the docs and code completion. I tried using RenderLevelStageEvent as a workaround but it is probably not intended for custom HUDs. I am not using NeoForge, and switching the project to NeoForge is currently not an option for me. I tried to look at the original minecraft source code to see how elements like hearts, hotbar etc are drawn on the screen but I am too new to Minecraft modding to understand. What I'm looking for: What is the correct way to add a custom HUD element (icon + text) in Forge 1.21, given that the previous overlay API is missing? Is there a new recommended event, callback, or method in Forge 1.21 for custom HUD overlays, or is everyone just using a workaround? Is there a minimal open-source example repo for Forge 1.21 that demonstrates a working HUD overlay without relying on NeoForge or deprecated Forge APIs? My ideal solution: Centered HUD element with an in-game item/block icon (from the base game's assets, e.g. a diamond or any ItemStack / Item) and its name as text, with a transparent background rectangle. It should be visible to the players when the mini game is running. Easy to update the item (e.g. static variable or other method), so it can change dynamically during the game. Any help, code snippets, or up-to-date references would be really appreciated! If this is simply not possible right now in Forge 1.21, it would also help to know that for sure. Thank you very much in advance!
    • The simple answer is there is not an easy way. You would need to know how to program in Java, as well as at least some familiarity with how Forge works so you could port the differences. You would also need the sourcecode for the original mod, and permission from the author to modify it, if they did not use some sort of open source license. So it's not impossible, but it would take some effort, but doing so would open up a whole new world of possibilities for you!
    • Does it still crash if you remove holdmyitems? Looks like that mod doesn't work on a server as far as I can tell from the error.  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.