[1.15.2] Changing the water bottle mechanic

[65_7a 0]

I want to make it so when you click on water or a cauldron with a glass bottle, you have a 25% chance of getting an item other than the water bottle. (in my case, a "Salty Water Bottle".) If this is possible, I would like to know how to do this.

[Novârch 16]

4 minutes ago, 65_7a said:

I want to make it so when you click on water or a cauldron with a glass bottle, you have a 25% chance of getting an item other than the water bottle. (in my case, a "Salty Water Bottle".) If this is possible, I would like to know how to do this.

Take a look at PlayerInteractEvent.RightClickBlock.

[65_7a 0]

Thank you for your reply.

 

I have made it so that when you right click a water block, it runs some code.

The only thing I need to do now is to check if the player has a specific item in their hand, in my case a glass bottle.

I have tried this:

if(Minecraft.getInstance().player.getHeldItemMainhand().getItem() == Items.GLASS_BOTTLE) {
	SixSOMod.LOGGER.info("Right clicked water with glass bottle.");
}

But nothing was logged when I right clicked water with a glass bottle in my hand.

[diesieben07 7206]

You have to use the player given to you. Minecraft is client-only.

[65_7a 0]

I am very sorry, I don't understand what you mean by "use the player given to me".  Do I have to use something other than Minecraft.getInstance().player?

Is there something wrong with my code?

[diesieben07 7206]

2 minutes ago, 65_7a said:

Do I have to use something other than Minecraft.getInstance().player?

Is there something wrong with my code?

Yes and yes.

The methods in the Item class you need to be using have a player parameter.

[65_7a 0]

if(player.getCurrentEquuippedItem() != null){
    if(player.getCurrentEquippedItem().getItem() == Items.GLASS_BOTTLE){

    }
}

I tried this code. "player" was in red. Does "player" not exist? Is there a new way to access the current equipped item in newer versions?

[diesieben07 7206]

4 minutes ago, 65_7a said:

I tried this code. "player" was in red. Does "player" not exist? Is there a new way to access the current equipped item in newer versions?

What's the context for this code? Do you know Java?

[65_7a 0]

package com.callumwong.sixsomod.events;

import com.callumwong.sixsomod.SixSOMod;
import net.minecraft.block.BlockState;
import net.minecraft.block.Blocks;
import net.minecraft.item.Items;
import net.minecraft.util.math.BlockPos;
import net.minecraftforge.common.extensions.IForgeBlockState;
import net.minecraftforge.event.entity.player.PlayerInteractEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber.Bus;

@Mod.EventBusSubscriber(modid = SixSOMod.MOD_ID, bus = Bus.FORGE)
public class ClickWaterEvent {

    @SubscribeEvent
    public static void clickWaterEvent(PlayerInteractEvent.RightClickBlock event) {
        BlockPos blockPos = event.getPos().offset(event.getFace());
        IForgeBlockState state = event.getWorld().getBlockState(blockPos);
        if (((BlockState) state).getBlock() == Blocks.WATER) {
            if(player.getCurrentEquuippedItem() != null){
                if(player.getCurrentEquippedItem().getItem() == Items.GLASS_BOTTLE){
                    
                }
            }
        }

    }

}

 

I am very new to Minecraft Forge, and I am still a beginner at Java. Should I be learning more about Java before I start using Forge?

[Novârch 16]

10 minutes ago, 65_7a said:

Should I be learning more about Java before I start using Forge?

Yes, you should, modding isn't a good way to learn Java, get used to the language before trying to make something, think about trying to write a book in a language you aren't familiar with.