Jump to content

Recommended Posts

Posted

I'm trying to make a class that will have a FMLCommonSetupEvent but I think I'm not registering it correctly?

 

Spoiler

@Mod.EventBusSubscriber(modid = TutorialMod.MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD)
public class CommonEventBusSubscriber {

    @SubscribeEvent
    public void commonSetup(FMLCommonSetupEvent event) {
        DeferredWorkQueue.runLater(() -> {
            CustomBiomeFeatures.addCustomFeatures();
        });
    }
  
}

 

What am I missing? To be honest I still don't understand how to register this events properly

Posted (edited)
5 minutes ago, MistaOmega said:

Why do you think you're not subscribed, is there an error, have you done any manual debugging etc?? 

The code worked on main and now it doesn't

Edited by Axspeo
Posted

My thoughts, make sure that mod is correct, run some print statements to follow the program, or better yet use break points to determine the progress of the code. 

 

Without seeing the rest of your code I can't guide you personally. Also, "TutorialMod" I assume you're following a YouTube tutorial, if you are, no judgement from me, just make sure you understand exactly what they're doing. 

 

See if any errors come up, ya know, normal debug stuff and get back to me, if anyone spots anything in the meantime I'm sure they'll say something here. 

Posted
1 minute ago, MistaOmega said:

My thoughts, make sure that mod is correct, run some print statements to follow the program, or better yet use break points to determine the progress of the code. 

 

Without seeing the rest of your code I can't guide you personally. Also, "TutorialMod" I assume you're following a YouTube tutorial, if you are, no judgement from me, just make sure you understand exactly what they're doing. 

 

See if any errors come up, ya know, normal debug stuff and get back to me, if anyone spots anything in the meantime I'm sure they'll say something here. 

I'm actually making one not following one :) So the way I'm registering is correct right?

Posted
Just now, Axspeo said:

I'm actually making one not following one :) So the way I'm registering is correct right?

Oh hell yeah, sorry for my assumption, best of luck with it. 

 

To me it looks fine, although, I have my setup in my main class, for an event listener though, it looks right at first glance, which is why I suggested going through the usual debugging things to see if there's any obvious point it stops working. 

  • Like 1
Posted
23 minutes ago, MistaOmega said:

Oh hell yeah, sorry for my assumption, best of luck with it. 

 

To me it looks fine, although, I have my setup in my main class, for an event listener though, it looks right at first glance, which is why I suggested going through the usual debugging things to see if there's any obvious point it stops working. 

np man it's fine! :)

20 minutes ago, MistaOmega said:

Here's an example from one of my ongoing projects, this is subscribing to a different event but in the same kind of fashion 

https://github.com/MistaOmega/Opes/blob/master/src/main/java/mistaomega/opes/setup/ClientEventHandler.java

I actually found out what the problem was, the method has to be static... ?

Posted
12 hours ago, Axspeo said:

I actually found out what the problem was, the method has to be static... ?

Note that the method only has to be static if you are registering the event subscriber class with @EventBusSubscriber.

It should be non-static if an instance of the event subscriber class is constructed and registered via the event bus' register method.

  • Thanks 1

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.