[1.16.1] Trouble with displaying particles

[Tavi007]

Hello,

I'm currently working on my first particle by following TheGreyGhosts tutorial mod (MinecraftByExample). For now I copied most of the code and changed some lines from 'World' to 'ClientWorld'. I did this change, because the example is for 1.15 and I'm using 1.16 (for example line 26 in CombatParticle needs ClientWorld, because otherwise the constructor was unknown). The code is compiling just fine, but my particle is nowhere to be seen. The particle is supposed to be spawning, when I hit an enemy (see line 108-121 in ElementifyLivingHurtEvent). My best assumption is, that I'm trying to spawn the particle on the server side instead of client side, which is why makeParticle(...) of the CombatParticleFactory is never called.

 

Could someone please explain to me, what I'm doing wrong and how I can fix it?

[TheGreyGhost]

Howdy

I haven't played with 1.16 yet, but the best way to troubleshoot this is to set a breakpoint in your particle spawn, then trace into the vanilla code and see what it does after that.

You might find that your spawn call is just ignored (because you're calling the wrong method), or that your particle type is not registered correctly, or the packet is never sent, or that when the packet is received it is ignored for some reason, or that your particle is actually rendering but is invisible or in a different space than you think.

 

-TGG

[Tavi007]

I took a deeper look at vanilla minecraft code and noticed, that the addParticle()- function of the class World is empty. However ClientWorld extends World and implements the addParticle function properly. I also looked at the working 1.16 mod 'Rats'. Here he simply calls event.getWorld(), with event being an instance of PlayerInteractEvent.EntityInteract. Calling event.getWorld() should also return a World (not a ClientWorld!), but somehow he can then call .spawnParticle().

I'm kinda confused, why his mod is working. Also I still have no idea, how I should get the right ClientWorld, so I can use its addParticle() function.

[vemerion]

Assuming that it has not changed since 1.15, EntityInteract is fired on both logical sides. This means that when it is fired on the client side, the world will be a ClientWorld (remember that ClientWorld is a subclass of World), and thus addParticle will be implemented and work, which it why it works for the Rats mod. The onLivingHurt event however only fires on the server, I believe.

 

Edit: To create particles from the server, use the spawnParticle method instead of addParticle (as I now see that the Rats mod does), which should also send the particles to the client.

Edited July 9, 2020 by vemerion

[Tavi007]

You mean, that I should change

target.getEntityWorld().addParticle(new CombatParticleData(tint, diameter), xpos, ypos, zpos, xSpeed, ySpeed, zSpeed);

to

target.getEntityWorld().spawnParticle(new CombatParticleData(tint, diameter), xpos, ypos, zpos, xSpeed, ySpeed, zSpeed);

?

When I do that, I only get the error, that spawnParticle is an unknown method. ( I expected this error, but I tried anyway. I don't know, if I'm missing something crucial)

[vemerion]

Try casting the world instance first, like so:

ServerWorld world = (ServerWorld) target.getEntityWorld();

 

[Tavi007]

Thank you! Now it's working

[vemerion]

2 minutes ago, Tavi007 said:

Thank you! Now it's working

No problem! Happy modding