Jump to content
  • Home
  • Files
  • Docs
Topics
  • All Content

  • This Topic
  • This Forum

  • Advanced Search
  • Existing user? Sign In  

    Sign In



    • Not recommended on shared computers


    • Forgot your password?

  • Sign Up
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • structure spawning on air
Currently Supported: 1.16.X (Latest) and 1.15.X (LTS)
Sign in to follow this  
Followers 0
maciejkasztan

structure spawning on air

By maciejkasztan, July 9, 2020 in Modder Support

  • Reply to this topic
  • Start new topic

Recommended Posts

maciejkasztan    0

maciejkasztan

maciejkasztan    0

  • Tree Puncher
  • maciejkasztan
  • Members
  • 0
  • 2 posts
Posted July 9, 2020

how can I fix that? structure is spawning on air

spacer.png

  • Quote

Share this post


Link to post
Share on other sites

maciejkasztan    0

maciejkasztan

maciejkasztan    0

  • Tree Puncher
  • maciejkasztan
  • Members
  • 0
  • 2 posts
Posted July 10, 2020

can someone help pls

  • Quote

Share this post


Link to post
Share on other sites

HighFox    0

HighFox

HighFox    0

  • Tree Puncher
  • HighFox
  • Members
  • 0
  • 22 posts
Posted July 12, 2020

You could try checking that all the blocks below the structure are solid before generating it.

  • Quote

Share this post


Link to post
Share on other sites

FizixRichard    0

FizixRichard

FizixRichard    0

  • Tree Puncher
  • FizixRichard
  • Members
  • 0
  • 16 posts
Posted July 22, 2020 (edited)

I'm figuring out structures atm myself. You have to check that the terrain elevation is within an allowed range. If you look at the minecraft source you'll find the code to do this.

 

Call a surface height range checker during the canBeGenerated method of your structure class:

 

protected boolean surfaceCheck(@Nonnull ChunkGenerator<?> chunkGenerator, int chunkX, int chunkZ)
    {        
        int offset = getSize() * 16;
        int xStart = (chunkX << 4);
        int zStart = (chunkZ << 4);

       
        int c1 = chunkGenerator.func_222531_c(xStart, zStart, Heightmap.Type.WORLD_SURFACE_WG);
        int c2 = chunkGenerator.func_222531_c(xStart, zStart + offset, Heightmap.Type.WORLD_SURFACE_WG);
        int c3 = chunkGenerator.func_222531_c(xStart + offset, zStart, Heightmap.Type.WORLD_SURFACE_WG);
        int c4 = chunkGenerator.func_222531_c(xStart + offset, zStart + offset, Heightmap.Type.WORLD_SURFACE_WG);

      
        int lowerHeight = Math.min(Math.min(c1, c2), Math.min(c3, c4));
        int upperHeight = Math.max(Math.max(c1, c2), Math.max(c3, c4));

        LOGGER.info("Area Height Range" + lowerHeight + " to " + upperHeight);

        boolean isFlat = Math.abs(upperHeight - lowerHeight) <= getHeightDelta(); 
  
  // getHeightDelta() should just return the maximum elevation change you want to allow your structure to generate on (this can be a property at the top of the class and set on a per-structure basis). A value of 3 will allow for your structure to generate over a 3 block elevation change, lower numbers require flatter terrain but will (depending on the size of your structure) reduce the opportunities for the structure to spawn.

        return isFlat;
    }

 

 

Call it something like this:

In canBeGenerated method:

if (surfaceCheck(chunkGenerator, chunkX, chunkZ))
{
   ... Continue with other checks
}

 

 

The other option, which I'm trying to figure out, is generating blocks underneath the structure if they are air or water (which Minecraft does for certain structures). Not that I have figured out how to implement that.

Edited July 22, 2020 by FizixRichard
  • Quote

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

    • Insert image from URL
×
  • Desktop
  • Tablet
  • Phone
Sign in to follow this  
Followers 0
Go To Topic Listing



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • cadbane86140
      Minecraft: Cereal UHC Season 2 Episode 5- THE FINALE!

      By cadbane86140 · Posted 15 minutes ago

      Hello There! A bit of a late upload due to technical issues but ITS UP! So after a week of Cereal UHC we have finally reached the end of it! I am so thankful to be apart of this series and I can't wait for the next season! There are so many hilarious moments especially during the final battle! I hope you all enjoyed this series and if you did don't forget to like and sub for more!  
    • samjviana
      [1.16.5] How to make EnchantedBook go to Custom ItemGroup

      By samjviana · Posted 33 minutes ago

      But how can i do that for an enchantment book, for normal items i was able to do that by calling the function "group" as you said, but with the enchantment seems to be different.
    • poopoodice
      [1.16.5] How to make EnchantedBook go to Custom ItemGroup

      By poopoodice · Posted 1 hour ago

      Just create an instance of ItemGroup, and set the group of the item in the item property builder.
    • poopoodice
      Trying to make a crop have an "X" shape model

      By poopoodice · Posted 1 hour ago

      Check the parent of their block model.
    • LexManos
      Forge says this file does not have an app associated with it.

      By LexManos · Posted 1 hour ago

      Some zip managers like to take control of the .jar file extension away from Java. Make sure you have Java installed and try running Jarfix once, then try the installer again.
  • Topics

    • cadbane86140
      0
      Minecraft: Cereal UHC Season 2 Episode 5- THE FINALE!

      By cadbane86140
      Started 15 minutes ago

    • samjviana
      2
      [1.16.5] How to make EnchantedBook go to Custom ItemGroup

      By samjviana
      Started 3 hours ago

    • TheMajorN
      1
      Trying to make a crop have an "X" shape model

      By TheMajorN
      Started 2 hours ago

    • ESCCarp
      3
      Forge says this file does not have an app associated with it.

      By ESCCarp
      Started 5 hours ago

    • hammy3502
      0
      [1.16.4] Fluid Flowing Very Oddly

      By hammy3502
      Started 2 hours ago

  • Who's Online (See full list)

    • Gorp5
    • LiliToBreazy
    • Caseofgames
    • digital_trucker
    • Pickle_Face5
    • cadbane86140
    • Kaeso
    • DerangedPenguins
    • LSMGaming
    • PyRoTheLifeLess
    • PtownCoderSchool
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • structure spawning on air
  • Theme

Copyright © 2019 ForgeDevelopment LLC · Ads by Longitude Ads LLC Powered by Invision Community