Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.16.1] [SOLVED]Custom biomes not generating in the world


Beethoven92
 Share

Recommended Posts

Hello, so, my goal is to add new biomes to default minecraft dimensions, without having to create a new world type like mods such as biomes o' plenty are doing. I looked at the way other mods that simply add their biomes to the default world generation (Traverse, Atmospheric...) are doing the trick, and in fact it seems a fairly simple task. The problem is that these mod are still in 1.15+, and doing the same in 1.16 seems to not produce the desired result. The same code does compile without errors in 1.16 but my custom biome simply isn't showing up during default world generation. My biome is registered and created correctly though, because i am able to select it in the single-biome world type and generate a world with it. It also shows up in the list of available biomes when i try the /locatebiome command, but it always says that it could not find it within reasonable distance, no matter how far i go around the world.

 

This is my Biome manager class:

 

package mod.beethoven92.testmod116.init;

import mod.beethoven92.testmod116.Reference;
import mod.beethoven92.testmod116.world.biome.TestBiome;
import net.minecraft.world.biome.Biome;
import net.minecraftforge.common.BiomeDictionary;
import net.minecraftforge.common.BiomeDictionary.Type;
import net.minecraftforge.common.BiomeManager;
import net.minecraftforge.eventbus.api.IEventBus;
import net.minecraftforge.fml.RegistryObject;
import net.minecraftforge.registries.DeferredRegister;
import net.minecraftforge.registries.ForgeRegistries;

public class ModBiomes 
{
	public static final DeferredRegister<Biome> BIOMES = DeferredRegister.create(ForgeRegistries.BIOMES, Reference.MOD_ID);
	
	public static final RegistryObject<Biome> TEST_BIOME = BIOMES.register("test_biome", TestBiome::new);
	
	public static void register(IEventBus modEventBus)
	{
		BIOMES.register(modEventBus);
	}
	
	public static void setupBiomes()
	{
		BiomeManager.addBiome(BiomeManager.BiomeType.COOL, new BiomeManager.BiomeEntry(TEST_BIOME.get(), 10));
		
		BiomeDictionary.addTypes(TEST_BIOME.get(), Type.PLAINS, Type.OVERWORLD);
	}
}

 

My custom biome:

package mod.beethoven92.testmod116.world.biome;

import net.minecraft.entity.EntityClassification;
import net.minecraft.entity.EntityType;
import net.minecraft.world.biome.Biome;
import net.minecraft.world.biome.BiomeAmbience;
import net.minecraft.world.biome.MoodSoundAmbience;
import net.minecraft.world.gen.surfacebuilders.SurfaceBuilder;

public class TestBiome extends Biome
{
	public TestBiome()
	{
		super((new Biome.Builder()).
				surfaceBuilder(SurfaceBuilder.DEFAULT, SurfaceBuilder.GRASS_DIRT_GRAVEL_CONFIG).
				precipitation(Biome.RainType.RAIN).
				category(Biome.Category.PLAINS).
				depth(0.1F).
				scale(0.2F).
				temperature(0.7F).
				downfall(0.8F).
				func_235097_a_((new BiomeAmbience.Builder()).
						setWaterColor(7098023).
						setWaterFogColor(14733798).
						setFogColor(16627961).
						setMoodSound(MoodSoundAmbience.field_235027_b_).
						build()).
				parent((String)null));
		
		this.addSpawn(EntityClassification.CREATURE, new Biome.SpawnListEntry(EntityType.BEE, 12, 2, 4));
	}
}

 

And finally my main class:

package mod.beethoven92.testmod116;

import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.eventbus.api.EventPriority;
import net.minecraftforge.eventbus.api.IEventBus;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent;
import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent;
import net.minecraftforge.fml.event.server.FMLServerStartingEvent;
import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;

import mod.beethoven92.testmod116.init.ModBiomes;
import mod.beethoven92.testmod116.init.ModBlocks;
import mod.beethoven92.testmod116.init.ModItems;


@Mod(Reference.MOD_ID)
public class TestMod116
{
    public static final Logger LOGGER = LogManager.getLogger(Reference.MOD_ID);

    public TestMod116() 
    {
    	IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus();
        

        modEventBus.addListener(this::clientSetup);
        modEventBus.addListener(EventPriority.LOWEST, this::commonSetup);
        
        //Registering deferred registers to the mod bus
        ModBlocks.register(modEventBus);
        ModItems.register(modEventBus);
        ModBiomes.register(modEventBus);
        
        MinecraftForge.EVENT_BUS.register(this);
    }

    private void commonSetup(final FMLCommonSetupEvent event)
    {
    	ModBiomes.setupBiomes();
    }

    private void clientSetup(final FMLClientSetupEvent event) 
    {
    }
    
    @SubscribeEvent
    public void onServerStarting(FMLServerStartingEvent event) 
    {
    }
}

 

which is the way i have seen other mods dealing with this. It just doesn't seem to work, and i really don't know what i am missing here. Any help is welcome! Thank you very much

 

/// EDIT: solved in the newer versions of Forge

Edited by Beethoven92

Check out the port of the BetterEnd fabric mod (WIP): https://www.curseforge.com/minecraft/mc-mods/betterend-forge-port

Link to comment
Share on other sites

  • 3 months later...

I did this in 1.16.1, and at the time i posted this topic there was an issue with the forge version i was using that prevented the code above to work correctly..and as i said at the end of the post the issue was addressed and fixed. See the relative changelog:

Quote

Build: 1.16.1-32.0.82 - Mon Jul 27 21:14:02 GMT 2020
	email.squishling:
		Fixed modded overworld biomes not spawning [1.16.x] (#6990)

 

Check out the port of the BetterEnd fabric mod (WIP): https://www.curseforge.com/minecraft/mc-mods/betterend-forge-port

Link to comment
Share on other sites

  • 3 weeks later...

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.