Jump to content

[1.15.2] Cancel Arm Swing on Item Right Click


BaileyH

Recommended Posts

Hello,

I am attempting to cancel the arm swing animation when an item is used on a block, in the air, and on an entity. Currently, I am successful for all of these except for when the item is used on a block.

I was following the post her, however I suspect it is out of date.

 

 @SubscribeEvent
    public static void onEntity(final PlayerInteractEvent.EntityInteract event) {
        PlayerEntity entity = event.getPlayer();
        if(!event.getWorld().isRemote || event.getHand() != Hand.MAIN_HAND)
            return;
        if(entity.getHeldItem(event.getHand()).getItem() instanceof SpellBook){
            System.out.println("Cancelling");
            event.setCanceled(true);
            ObfuscationReflectionHelper.setPrivateValue(FirstPersonRenderer.class, minecraft.getFirstPersonRenderer(), 1f, MappingUtil.getEquippedProgressMainhand());
        }
    }

I repeat the above code for the following events (some of them are covered by others, I realize):

PlayerInteractEvent.EntityInteract

PlayerInteractEvent.RightClickBlock

PlayerInteractEvent.RightClickItem

PlayerInteractEvent

 

Do I need to cancel other events? Am I setting the wrong value?

 

Thank you!

Link to comment
Share on other sites

Hello,

They were already returning Success. Setting them to FAIL on the server side removes the swinging, but also causes the client to also not update blockstate changes properly. Setting them to fail on the client side does not seem to do anything.

 

I found the method IForgeItem#onEntitySwing and set it to true, but now left click breaking is also cancelled. I tested this with the event cancels and without.

 

Relevant code that is reasonably up to date: https://github.com/baileyholl/Ars-Nouveau/blob/master/src/main/java/com/hollingsworth/arsnouveau/common/items/SpellBook.java 

 

Thank you!

Edited by BaileyH
Clarification on sides, false -> true
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.