Help with 3-input Tile Entity [solved]

[wookiederk]

Hi, I have based my code from the furnace code. I have three specific inputs with one output. However, when I put those items in the proper slot nothing happens! Here is my Tile Entity Code:

package wookiederk;

import cpw.mods.fml.common.registry.GameRegistry;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.tileentity.TileEntity;
import net.minecraftforge.common.ForgeDirection;
import net.minecraftforge.common.ForgeDummyContainer;
import net.minecraftforge.common.ISidedInventory;

public class TileEntityKeg extends TileEntity implements ISidedInventory {

private static final int[] field_102010_d = new int[] { 0 };
private static final int[] field_102011_e = new int[] { 2, 1 };
private static final int[] field_102009_f = new int[] { 1 };

/**
 * The ItemStacks that hold the items currently being used in the furnace
 */
private ItemStack[] kegItemStacks = new ItemStack[4];

/** The number of ticks that the furnace will keep burning */
public int kegFermentTime = 0;

/**
 * The number of ticks that a fresh copy of the currently-burning item would
 * keep the furnace burning for
 */
public int currentItemFermentTime = 0;

/** The number of ticks that the current item has been cooking for */
public int kegCookTime = 0;
private String field_94130_e;

/**
 * Returns the number of slots in the inventory.
 */
public int getSizeInventory() {
	return this.kegItemStacks.length;
}

/**
 * Returns the stack in slot i
 */
public ItemStack getStackInSlot(int par1) {
	return this.kegItemStacks[par1];
}

/**
 * Removes from an inventory slot (first arg) up to a specified number
 * (second arg) of items and returns them in a new stack.
 */
public ItemStack decrStackSize(int par1, int par2) {
	if (this.kegItemStacks[par1] != null) {
		ItemStack itemstack;

		if (this.kegItemStacks[par1].stackSize <= par2) {
			itemstack = this.kegItemStacks[par1];
			this.kegItemStacks[par1] = null;
			return itemstack;
		} else {
			itemstack = this.kegItemStacks[par1].splitStack(par2);

			if (this.kegItemStacks[par1].stackSize == 0) {
				this.kegItemStacks[par1] = null;
			}

			return itemstack;
		}
	} else {
		return null;
	}
}

/**
 * When some containers are closed they call this on each slot, then drop
 * whatever it returns as an EntityItem - like when you close a workbench
 * GUI.
 */
public ItemStack getStackInSlotOnClosing(int par1) {
	if (this.kegItemStacks[par1] != null) {
		ItemStack itemstack = this.kegItemStacks[par1];
		this.kegItemStacks[par1] = null;
		return itemstack;
	} else {
		return null;
	}
}

/**
 * Sets the given item stack to the specified slot in the inventory (can be
 * crafting or armor sections).
 */
public void setInventorySlotContents(int par1, ItemStack par2ItemStack) {
	this.kegItemStacks[par1] = par2ItemStack;

	if (par2ItemStack != null
			&& par2ItemStack.stackSize > this.getInventoryStackLimit()) {
		par2ItemStack.stackSize = this.getInventoryStackLimit();
	}
}

/**
 * Returns the name of the inventory.
 */
public String getInvName() {
	return this.isInvNameLocalized() ? this.field_94130_e : "container.keg";
}

/**
 * If this returns false, the inventory name will be used as an unlocalized
 * name, and translated into the player's language. Otherwise it will be
 * used directly.
 */
public boolean isInvNameLocalized() {
	return this.field_94130_e != null && this.field_94130_e.length() > 0;
}

public void func_94129_a(String par1Str) {
	this.field_94130_e = par1Str;
}

/**
 * Reads a tile entity from NBT.
 */
public void readFromNBT(NBTTagCompound par1NBTTagCompound) {
	super.readFromNBT(par1NBTTagCompound);
	NBTTagList nbttaglist = par1NBTTagCompound.getTagList("Items");
	this.kegItemStacks = new ItemStack[this.getSizeInventory()];

	for (int i = 0; i < nbttaglist.tagCount(); ++i) {
		NBTTagCompound nbttagcompound1 = (NBTTagCompound) nbttaglist
				.tagAt(i);
		byte b0 = nbttagcompound1.getByte("Slot");

		if (b0 >= 0 && b0 < this.kegItemStacks.length) {
			this.kegItemStacks[b0] = ItemStack
					.loadItemStackFromNBT(nbttagcompound1);
		}
	}

	this.kegFermentTime = par1NBTTagCompound.getShort("BurnTime");
	this.kegCookTime = par1NBTTagCompound.getShort("CookTime");
	this.currentItemFermentTime = getItemBurnTime(this.kegItemStacks[1]);

	if (par1NBTTagCompound.hasKey("CustomName")) {
		this.field_94130_e = par1NBTTagCompound.getString("CustomName");
	}
}

/**
 * Writes a tile entity to NBT.
 */
public void writeToNBT(NBTTagCompound par1NBTTagCompound) {
	super.writeToNBT(par1NBTTagCompound);
	par1NBTTagCompound.setShort("BurnTime", (short) this.kegFermentTime);
	par1NBTTagCompound.setShort("CookTime", (short) this.kegCookTime);
	NBTTagList nbttaglist = new NBTTagList();

	for (int i = 0; i < this.kegItemStacks.length; ++i) {
		if (this.kegItemStacks[i] != null) {
			NBTTagCompound nbttagcompound1 = new NBTTagCompound();
			nbttagcompound1.setByte("Slot", (byte) i);
			this.kegItemStacks[i].writeToNBT(nbttagcompound1);
			nbttaglist.appendTag(nbttagcompound1);
		}
	}

	par1NBTTagCompound.setTag("Items", nbttaglist);

	if (this.isInvNameLocalized()) {
		par1NBTTagCompound.setString("CustomName", this.field_94130_e);
	}
}

/**
 * Returns the maximum stack size for a inventory slot. Seems to always be
 * 64, possibly will be extended. *Isn't this more of a set than a get?*
 */
public int getInventoryStackLimit() {
	return 64;
}

@SideOnly(Side.CLIENT)
/**
 * Returns an integer between 0 and the passed value representing how close the current item is to being completely
 * cooked
 */
public int getCookProgressScaled(int par1) {
	return this.kegCookTime * par1 / 200;
}

@SideOnly(Side.CLIENT)
/**
 * Returns an integer between 0 and the passed value representing how much burn time is left on the current fuel
 * item, where 0 means that the item is exhausted and the passed value means that the item is fresh
 */
public int getBurnTimeRemainingScaled(int par1) {
	if (this.currentItemFermentTime == 0) {
		this.currentItemFermentTime = this.kegFermentTime = getItemBurnTime(this.kegItemStacks[1]);
	}

	return this.kegFermentTime * par1 / this.currentItemFermentTime;
}

/**
 * Returns true if the furnace is currently burning
 */
public boolean isBurning() {
	return this.kegFermentTime > 0;
}

/**
 * Allows the entity to update its state. Overridden in most subclasses,
 * e.g. the mob spawner uses this to count ticks and creates a new spawn
 * inside its implementation.
 */
public void updateEntity() {
	boolean flag = this.kegFermentTime > 0;
	boolean flag1 = false;

	if (this.kegFermentTime > 0) {
		--this.kegFermentTime;
	}

	if (!this.worldObj.isRemote) {
		if (this.kegFermentTime == 0 && this.canSmelt()) {
			this.currentItemFermentTime = this.kegFermentTime = getItemBurnTime(this.kegItemStacks[1]);

			if (this.kegFermentTime > 0) {
				flag1 = true;

				if (this.kegItemStacks[1] != null) {
					// --this.kegItemStacks[1].stackSize;

					if (this.kegItemStacks[1].stackSize == 0) {
						this.kegItemStacks[1] = this.kegItemStacks[1]
								.getItem().getContainerItemStack(
										kegItemStacks[1]);
					}
				}
			}
		}

		if (this.isBurning() && this.canSmelt()) {
			++this.kegCookTime;

			if (this.kegCookTime == getItemBurnTime(this.kegItemStacks[1])) {
				this.kegCookTime = 0;
				this.smeltItem();
				flag1 = true;
			}
		} else {
			this.kegCookTime = 0;
		}

		if (flag != this.kegFermentTime > 0) {
			flag1 = true;
			BlockBeerKeg.updateFurnaceBlockState(this.kegFermentTime > 0,
					this.worldObj, this.xCoord, this.yCoord, this.zCoord);
		}
	}

	if (flag1) {
		this.onInventoryChanged();
	}
}

/**
 * Returns true if the furnace can smelt an item, i.e. has a source item,
 * destination stack isn't full, etc.
 */
private boolean canSmelt() {
	if (this.kegItemStacks[0] != new ItemStack(EatMe.yeast)) {
		return false;
	} else if (this.kegItemStacks[2] != new ItemStack(EatMe.cupEmpty)) {
		return false;
	} else if (this.kegItemStacks[1] == new ItemStack(EatMe.grapes)) {
		return true;
	} else if (this.kegItemStacks[1] == new ItemStack(EatMe.barley)) {
		return true;
	} else {
		return false;
	}
}

/**
 * Turn one item from the furnace source stack into the appropriate smelted
 * item in the furnace result stack
 */
public void smeltItem() {
	if (this.canSmelt()) {
		ItemStack itemstack = new ItemStack(EatMe.cupEmpty);

		if (this.kegItemStacks[1] == new ItemStack(EatMe.grapes)) {
			itemstack = new ItemStack(EatMe.alcohol);
		} else if (this.kegItemStacks[1] == new ItemStack(EatMe.barley)) {
			itemstack = new ItemStack(EatMe.flour);
		}

		if (this.kegItemStacks[3] == null) {
			this.kegItemStacks[3] = itemstack.copy();
		} else if (this.kegItemStacks[3].isItemEqual(itemstack)) {
			kegItemStacks[3].stackSize += itemstack.stackSize;
		}

		--this.kegItemStacks[0].stackSize;
		--this.kegItemStacks[1].stackSize;
		--this.kegItemStacks[2].stackSize;
	}
}

/**
 * Returns the number of ticks that the supplied fuel item will keep the
 * furnace burning, or 0 if the item isn't fuel
 */
public static int getItemBurnTime(ItemStack par0ItemStack) {
	if (par0ItemStack == null) {
		return 0;
	} else {
		int i = par0ItemStack.getItem().itemID;
		Item item = par0ItemStack.getItem();

		if (i == EatMe.grapes.itemID)
			return 3000;

		if (i == EatMe.barley.itemID)
			return 2000;
		return GameRegistry.getFuelValue(par0ItemStack);
	}
}

/**
 * Return true if item is a fuel source (getItemBurnTime() > 0).
 */
public static boolean isItemFuel(ItemStack par0ItemStack) {
	return getItemBurnTime(par0ItemStack) > 0;
}

/**
 * Do not make give this method the name canInteractWith because it clashes
 * with Container
 */
public boolean isUseableByPlayer(EntityPlayer par1EntityPlayer) {
	return this.worldObj.getBlockTileEntity(this.xCoord, this.yCoord,
			this.zCoord) != this ? false : par1EntityPlayer.getDistanceSq(
			(double) this.xCoord + 0.5D, (double) this.yCoord + 0.5D,
			(double) this.zCoord + 0.5D) <= 64.0D;
}

public void openChest() {
}

public void closeChest() {
}

/**
 * Returns true if automation is allowed to insert the given stack (ignoring
 * stack size) into the given slot.
 */
public boolean isStackValidForSlot(int par1, ItemStack par2ItemStack) {
	return par1 == 2 ? false : (par1 == 1 ? isItemFuel(par2ItemStack)
			: true);
}

/**
 * Returns an array containing the indices of the slots that can be accessed
 * by automation on the given side of this block.
 */
public int[] getAccessibleSlotsFromSide(int par1) {
	return par1 == 0 ? field_102011_e : (par1 == 1 ? field_102010_d
			: field_102009_f);
}

/**
 * Returns true if automation can insert the given item in the given slot
 * from the given side. Args: Slot, item, side
 */
public boolean canInsertItem(int par1, ItemStack par2ItemStack, int par3) {
	return this.isStackValidForSlot(par1, par2ItemStack);
}

/**
 * Returns true if automation can extract the given item in the given slot
 * from the given side. Args: Slot, item, side
 */
public boolean canExtractItem(int par1, ItemStack par2ItemStack, int par3) {
	return par3 != 0 || par1 != 1
			|| par2ItemStack.itemID == Item.bucketEmpty.itemID;
}

/***********************************************************************************
 * This function is here for compatibilities sake, Modders should Check for
 * Sided before ContainerWorldly, Vanilla Minecraft does not follow the
 * sided standard that Modding has for a while.
 * 
 * In vanilla:
 * 
 * Top: Ores Sides: Fuel Bottom: Output
 * 
 * Standard Modding: Top: Ores Sides: Output Bottom: Fuel
 * 
 * The Modding one is designed after the GUI, the vanilla one is designed
 * because its intended use is for the hopper, which logically would take
 * things in from the top.
 * 
 * This will possibly be removed in future updates, and make vanilla the
 * definitive standard.
 */

@Override
public int getStartInventorySide(ForgeDirection side) {
	if (ForgeDummyContainer.legacyFurnaceSides) {
		if (side == ForgeDirection.DOWN)
			return 2;
		if (side == ForgeDirection.UP)
			return 0;
		return 1;
	} else {
		if (side == ForgeDirection.DOWN)
			return 2;
		if (side == ForgeDirection.UP)
			return 0;
		return 1;
	}
}

@Override
public int getSizeInventorySide(ForgeDirection side) {
	return 1;
}

}

 

Edit: I think it is something wrong with the canSmelt() part.

[Quarg]

you can't simply compare two itemstacks using the standard == or !=, it will always consider them not equal since they arn't the same object, you should either manually compare their item IDs and Metadata/Damage OR use item1.equals(item2)

[SanAndreaP]

you can't simply compare two itemstacks using the standard == or !=, it will always consider them not equal since they arn't the same object, you should either manually compare their item IDs and Metadata/Damage OR use item1.equals(item2)

 

addition: You should use item1.isItemEqual(item2) instead of item1.equals(item2), since it compares only the Item ID and the metadata, and not the whole instance itself (which can cause problems). If you want to check if the NBT is equal, too then use ItemStack.areItemStacksEqual(item1, item2)

[wookiederk]

 if (this.kegItemStacks[0].isItemEqual(new ItemStack(EatMe.yeast))) {
		System.out.println("yeast");
		return false;

 

Gives a null pointer.

[redria7]

You have to make sure there is something in kegItemStacks[0] before you access what is inside it:

if (this.kegItemStacks[0] != null)
{
        if (this.kegItemStacks[0].isItemEqual(new ItemStack(EatMe.yeast))) 
        {
		System.out.println("yeast");
		return false;
        }
}
else
{
        //whatever you want to do if that slot is empty
}

[Quarg]

or better yet:

if (this.kegItemStacks[0] != null && this.kegItemStacks[0].isItemEqual(new ItemStack(EatMe.yeast)))

would work fine.