[1.16.3] Chuck Capability Not Registering

[BeardlessBrady]

I just recently moved from 1.12.2 to 1.16.3 and ALOT has changed so I may just be messing something simple up.

 

Capability parts: https://github.com/Beardlessbrady/FortKnox-Mod/tree/f81dc23108b2b3b1ed99fb6815702ba3e93841aa/src/main/java/com/beardlessbrady/fortknox/capabilities/protection

Registering Capability: https://github.com/Beardlessbrady/FortKnox-Mod/blob/f81dc23108b2b3b1ed99fb6815702ba3e93841aa/src/main/java/com/beardlessbrady/fortknox/ModFortKnox.java#L42

 

[poopoodice]

I think they should be registered in common setup.

Edited September 17, 2020 by poopoodice

[Cyborgmas]

https://github.com/Beardlessbrady/FortKnox-Mod/blob/f81dc23108b2b3b1ed99fb6815702ba3e93841aa/src/main/java/com/beardlessbrady/fortknox/ModFortKnox.java#L28
you want to use @ CapabilityInject here otherwise its always null
also, you are casting to a lazyoptional here... https://github.com/Beardlessbrady/FortKnox-Mod/blob/f81dc23108b2b3b1ed99fb6815702ba3e93841aa/src/main/java/com/beardlessbrady/fortknox/capabilities/protection/ProtectionProvider.java#L38
which is just plain wrong.
 

i recommend looking at forge's different cap implementations (energy, fluid handler, item handler)

[BeardlessBrady]

Alright I am trying to fix the #getCapability but I am having issues with the following:

 

 @Override
    public <T> LazyOptional<T> getCapability(Capability<T> cap, Direction side) {
        return (cap == ModFortKnox.PROTECTION_CAPABILITY) ? ((ModFortKnox.PROTECTION_CAPABILITY) protection) : null;
    }

 

My issue is when I am trying to cast protection with PROTECTION_CAPABILITY its telling me that PROTECTION_CAPABILITY is an unknown class. For some reason I can't cast it. Any ideas?

[BeardlessBrady]

Im following this (which I know is outdated) as my example:
https://github.com/JamiesWhiteShirt/MinecraftForge/blob/2a933e2094f73e69749c478d921e75bb3d26ead4/src/test/java/net/minecraftforge/debug/ChunkCapabilityPollutionTest.java

 

How do I return protection in #getCapability

Edited September 26, 2020 by BeardlessBrady

[ChampionAsh5357]

1 hour ago, BeardlessBrady said:

How do I return protection in #getCapability

You're not returning an instance, you're returning a holder to that instance. For that, you need to create a holder that references your instance. You'll need to use LazyOptional::of and pass the instance in and then cast it within the method. Note that you should always return the super of the method in case something else decides to override it.

[BeardlessBrady]

What do I cast 'protection' to?

[ChampionAsh5357]

21 minutes ago, BeardlessBrady said:

What do I cast 'protection' to?

I never said cast your instance to anything. You should probably look over the LazyOptional class and check out the method I'm referring to.

[BeardlessBrady]

Im just not understanding what I need to pass to LazyOptional.of();

[poopoodice]

An instance of your capability

[ChampionAsh5357]

1 hour ago, BeardlessBrady said:

Im just not understanding what I need to pass to LazyOptional.of();

Your capability instance.

[BeardlessBrady]

Right but when I do...

Quote

return LazyOptional.of(protection);

My IDE complains that 'protection' needs to be a NonNullSupplier.

Edited October 6, 2020 by BeardlessBrady

[BeardlessBrady]

It works fine if my SafeProtection class doesn't need a parameter when a new instance is created however because I do need a parameter it gives the above complaint

[ChampionAsh5357]

1 hour ago, BeardlessBrady said:

'protection' needs to be a NonNullSupplier

Yes, protection is an instance. So you need to supply an instance. Take some time to learn functional programming.

[BeardlessBrady]

I am trying to understand but it isn't very clear what I am supposed to put into the LazyOptional.of() method. If I place the instance of my capability I get the error stated above. As I mentioned I can get it working fine if a new instance doesn't require any parameters but mine does because it's a chunk capability. Can someone just help me understand what I need to do with my instance in order to put it in the LazyOptional.of().

Edited October 6, 2020 by BeardlessBrady

[poopoodice]

https://docs.oracle.com/javase/tutorial/java/javaOO/lambdaexpressions.html

LazyOptional.of(() -> new TestCapability())

or use ::

LazyOptional.of(TestCapability::new)

[BeardlessBrady]

Thank you! that has done it

Edited October 7, 2020 by BeardlessBrady