Jump to content
Currently supported: All versions

Container#mergeItemStack is not sensitive for IInventory#isStackValidForSlot

WorldsEnder

By WorldsEnder
in Suggestions

 Share

Recommended Posts

WorldsEnder Creeper Killer

WorldsEnder

Posted
Posted

I think this is pretty much an issue. I mean what does isStackValidForSlot has to do if not tell other people whether or not the stack is valid for the slot? And in the mergeItemStack method this doesn't get checked. Items are just put into the slots which is pretty much not what I want :)

ObsequiousNewt Dragon Slayer

ObsequiousNewt

Posted
Posted

I just found out that really NOTHING (but the hopper) calls this method anyways. This would be a light change I guess. So why do you write such a method if you don't use it anyways?

False. This method is called whenever you shift-click on an item. I actually redefined this method for this exact purpose.

BEWARE OF GOD

---

Co-author of Pentachoron Labs' SBFP Tech.

ObsequiousNewt Dragon Slayer

ObsequiousNewt

Posted
Posted

isStackValidForSlot is (once again) just a stupid MCP name. It should be canAutomationInsert or something like that. It should at least indicate that this method is indicated for automation purposes (e.g. the hopper).

Oh, ha ha. I was thinking of isItemValid() in the slot class. Which I believe should be checked in mergeItemStack. Besides, I had thought he had meant that nothing called mergeItemStack() besides the hopper.

BEWARE OF GOD

---

Co-author of Pentachoron Labs' SBFP Tech.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • Shura4437
      Game Crashed after I updated some mods :/

      By Shura4437 · Posted

      Yep I did upgrade just because it showed me a new version available.  I'll redownload the mod list and make sure anything works.  Thanks!
    • Ugdhar
      Game Crashed after I updated some mods :/

      By Ugdhar · Posted

      The latest log was taken down by pastebin for some reason. Did you try removing the mods you added? The mods you updated, was there a specific reason you updated, or just because? It's possible the updates introduced incompatibilitie, or even need a newer build of forge. If you didn't need the updates for a specific reason, you could also try downgrading those mods.
    • Ugdhar
      Forge 1.20.1 crash with exit code -1

      By Ugdhar · Posted

      Please read the FAQ, and post logs as described there. https://forums.minecraftforge.net/topic/125488-rules-and-frequently-asked-questions-faq/
    • MrMirchi
      Forge 1.20.1 crash with exit code -1

      By MrMirchi · Posted

      I am using forge 1.20.1 (version 47.3.0). My pc has an RTX 4080 super and an i9 14900 KF, I am on the latest Nvidia graphics driver, latest windows 10 software, I have java 23, forge 1.12.2 works and so does all vanilla versions but for some reason no version of forge 1.20.1 works and instead the game just crashes with the error code "-1." I have no mods in my mods fodler, I have deleted my options.txt and forge.cfg files in case my settings were causing a crash and have tried removing my forge version from the installations folder and reinstalling but no matter what I still crash with the same code and my log doesn't tell me anything: 18:34:53.924 game 2025-02-06 18:34:53,914 main WARN Advanced terminal features are not available in this environment 18:34:54.023 game [18:34:54] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher running: args [--username, mrmirchi, --version, 1.20.1-forge-47.3.0, --gameDir, C:\Users\aryam\AppData\Roaming\.minecraft, --assetsDir, C:\Users\aryam\AppData\Roaming\.minecraft\assets, --assetIndex, 5, --uuid, 2db00ea8d678420a8956109a85d90e9d, --accessToken, ????????, --clientId, ZWI3NThkNzMtNmNlZS00MGI5LTgyZTgtYmZkNzcwMTM5MGMx, --xuid, 2535436222989555, --userType, msa, --versionType, release, --quickPlayPath, C:\Users\aryam\AppData\Roaming\.minecraft\quickPlay\java\1738838092785.json, --launchTarget, forgeclient, --fml.forgeVersion, 47.3.0, --fml.mcVersion, 1.20.1, --fml.forgeGroup, net.minecraftforge, --fml.mcpVersion, 20230612.114412] 18:34:54.027 game [18:34:54] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher 10.0.9+10.0.9+main.dcd20f30 starting: java version 17.0.8 by Microsoft; OS Windows 10 arch amd64 version 10.0 18:34:54.132 game [18:34:54] [main/INFO] [ne.mi.fm.lo.ImmediateWindowHandler/]: Loading ImmediateWindowProvider fmlearlywindow 18:34:54.191 game [18:34:54] [main/INFO] [EARLYDISPLAY/]: Trying GL version 4.6 18:34:54.303 game [18:34:54] [main/INFO] [EARLYDISPLAY/]: Requested GL version 4.6 got version 4.6 18:34:54.367 monitor Process Monitor Process crashed with exit code -1     screenshot of log: https://drive.google.com/file/d/1WdkH88H865XErvmIqAKjlg7yrmj8EYy7/view?usp=sharing
    • Thatdudepeter
      I need help with organising creative tabs

      By Thatdudepeter · Posted

      I am currently working on a big mod, but I'm having trouble with my tabs, I want to find a way to add tabs inside tabs, like how in mrcrayfishes furniture mod, his furniture tab has multiple other sub tabs to them, so i know it is possible but i just don't know how it is possible, any help would be appreciated, thanks

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept