Jump to content

Container#mergeItemStack is not sensitive for IInventory#isStackValidForSlot


WorldsEnder
 Share

Recommended Posts

I think this is pretty much an issue. I mean what does isStackValidForSlot has to do if not tell other people whether or not the stack is valid for the slot? And in the mergeItemStack method this doesn't get checked. Items are just put into the slots which is pretty much not what I want :)

Link to comment
Share on other sites

I just found out that really NOTHING (but the hopper) calls this method anyways. This would be a light change I guess. So why do you write such a method if you don't use it anyways?

False. This method is called whenever you shift-click on an item. I actually redefined this method for this exact purpose.

BEWARE OF GOD

---

Co-author of Pentachoron Labs' SBFP Tech.

Link to comment
Share on other sites

isStackValidForSlot is (once again) just a stupid MCP name. It should be canAutomationInsert or something like that. It should at least indicate that this method is indicated for automation purposes (e.g. the hopper).

Oh, ha ha. I was thinking of isItemValid() in the slot class. Which I believe should be checked in mergeItemStack. Besides, I had thought he had meant that nothing called mergeItemStack() besides the hopper.

BEWARE OF GOD

---

Co-author of Pentachoron Labs' SBFP Tech.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.