So as I'm porting a mod I came across this

@SubscribeEvent
public void logIn(PlayerLoggedInEvent event) {
    if (RoughConfig.healthRegenOff && event.player.world.getGameRules().getBoolean("naturalRegeneration")) {
        event.player.world.getGameRules().setOrCreateGameRule("naturalRegeneration", "false");
    }
}

Now I turned it into this

@SubscribeEvent
public void logIn(PlayerLoggedInEvent event) {
    if(RoughConfig.GENERAL.HEALTH_REGEN.get() && event.getPlayer().world.getGameRules().getBoolean(new RuleKey<BooleanValue>("naturalRegeneration", Category.UPDATES))) {
            event.getPlayer().world.getGameRules().func_234903_a_("naturalRegeneration", GameRules.Category.UPDATES, GameRules.BooleanValue.create(false));
    }
}

Which I'm worried of because I have no idea at some bits that I'm doing here,

 

First of all, getBoolean now requires a generic RuleKey, which requires a name and a Category, instead of only the name

Secondly, #setOrCreateGameRule doesn't seem to be a thing anymore, so I found out that vanilla uses that func that I'm using, so I did that, added a name, a category, and now the third parameter doesn't work, since BooleanValue#create is private

Last but not least, I'm pretty sure the check will error, since the rule isn't existant

 

Someone help me here, this is very confusing..

 

Thanks in regards!

Edited October 25, 20204 yr by MostafaSabry55

bump