Jump to content

[1.16] How would I convert a map in game to an external image?


Recommended Posts

Posted

I am trying to convert a map that I would create while on a server to an external image to use later. I have tried to approach this in a couple ways. I tried to take a screenshot whenever there's a map in my inventory using getStackInSlot(), but I have no clue how I would do that. I tried doing KeyBinding.setKeyBindState(minecraft.gameSettings.keyBindScreenshot.getKeyCode(), true); and the same for KeyBinding.onTick(....keyBindScreenshot.getKeyCode()), but they never worked. Any idea on how to use this?

 

I also attempted to use the class MapData, but I don't know how I would rebuild the map image using the information there.

 

To be clear, this is not on a singleplayer world, so I can't just convert the .dat file stored locally in my .minecraft folder. This is a map that is created in my inventory on a server.

Posted (edited)

How do I create an instance of MapItemRenderer?

 

Edit: Figured it out. I updated the map texture using a MapData instance of the map. func_228089_a_ is in a private package. Now what should I do?  Also, referring to my screenshot approach, how would I use it correctly? 

Edited by TheHook
Posted

 

On 11/1/2020 at 3:42 AM, diesieben07 said:

Well, you can't literally use those methods, because they draw on the screen. You need to look at what they do and replicate it.

I think you may be misunderstanding me. I am not trying to create a map in the program, but the map already exists in my inventory. I am trying to convert that map to an external image for later use. Is there any easier way to do this than to replicate an API method?

Posted
1 hour ago, diesieben07 said:

Considering this functionality does not already exist in Minecraft: No.

There is absolutely no way that I can maybe rebuild an image from whatever data I have available to me with the conditions I described?

 

If that's the case, then I'll go ahead with the screenshot approach. 

On 11/1/2020 at 3:42 AM, diesieben07 said:

Well, a screenshot would be of the entire game, not just the map. But you'll want to look into glReadPixels.

Let me clarify again. For the screenshot approach, once the "map is in inventory" flag is raised, I would take a screenshot automatically within the program. Is the KeyBinding approach incorrect?

Posted
1 minute ago, diesieben07 said:

You want to take a screenshot automatically when the map is in the inventory. I don't know what you want a key binding for then.

Yes, what would API would I use to do that is my question.

Posted
2 minutes ago, diesieben07 said:

Of course you can. But you need to program a method that does it.

How would you recommend approaching this? Maybe taking the colors byte array from MapData and parsing it into a 2D array in which each member is a set of RGBa values representing a "grid of colors"? How would I rebuild that into a png/jpg file?

Posted

 

3 minutes ago, diesieben07 said:

glReadPixels, like I said. Look at ScreenshotHelper for how to do it.

 

Exactly. That's what the code I told you to look at before does.

 

Look into BufferdImage and friends.

Beautiful, thank you. I'll get started right away on implementation. I think you can close this thread now, if I have more questions, I can just make another one.

Posted (edited)

I am trying to use ScreenshotHelper methods createScreenshot and saveScreenshot, but it's only creating a blank file.

Framebuffer buffer = new Framebuffer(minecraft.displayWidth, minecraft.displayHeight, true);
ScreenShotHelper.createScreenshot(minecraft.displayHeight, minecraft.displayWidth, buffer);
ScreenShotHelper.saveScreenshot(gameDirectory, "screenshot.png", minecraft.displayWidth, minecraft.displayHeight, buffer);

This is what I'm doing. I'm pretty sure the issue is the buffer argument. I'm not too sure what the correct value should be. What am I doing wrong here? I know createScreenshot returns a BufferedImage, but is that BufferedImage the actual screenshot?

 

I attached the result png of this code:

screenshot.png

Edited by TheHook
Posted

Alright, I decided against the screenshot method and I'm using MapData to convert colors to a 2D array of rgb values. However, the colors array is always empty. 

MapData mapData = new MapData(minecraft.player.inventory.getStackInSlot(0).getDisplayName()); //where the map is
mapData.readFromNBT(minecraft.player.inventory.getStackInSlot(0).serializeNBT()); //added this after the array was empty, still doesn't work
byte[] mapColors = mapData.colors;
System.out.println("The color ID of " + mapData.mapName + " at " + index + " is: " + mapColors[index]); //index increments every time this code block is called.

This is the code I'm using. It makes sense as to why a static call to colors would be empty because the MapData constructor doesn't construct it. readFromNBT() assigns values to it, this I understand. I think the value I'm giving to it is incorrect, because the colors array is still empty, with the output produced has index incrementing, but the color ID is always 0. The map created is not in a blank world, I created a random world with no modifications and it still outputs 0. What should I do?

Posted
17 hours ago, diesieben07 said:

This makes zero sense. The display name is not involved here at all.

It's the argument of the constructor in the MapData class, "String mapname".

 

17 hours ago, diesieben07 said:

You need to call FilledMapItem.getMapData.

Is FilledMapItem an API class?

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I wasn't excepting this to be seen this fast and left the post marinating for a while, but thank you for such a quick reply! Regarding what the console shows me when the server fails to boot, you can find those logs on this pastebin link here. From what I could gather, the issue here is with the mod Night Lights. Should I remove this mod, I get the same issue with Rings of Ascension, and lastly with Oh The Biomes We've Gone. When I remove these three mods, the issue goes away, but since the world was generated with the biome mod, I would rather not part ways with it. Thank you for taking some time to read my extensive description, hope the link with the logs helps!
    • Please see https://forums.minecraftforge.net/topic/125488-rules-and-frequently-asked-questions-faq/ for information on how to post your log correctly.
    • Hello!  The detailed description of how you got to where you are is certainly valuable.  But, at the end of the day (well, any time of the day actually), it is going to be the actual logs that going to provide the necessary details to hopefully solve your startup issue. Part of me wonders if you have installed a client-only mod on a dedicated server.  But I may very well be wrong, and it will be the logs that will tell that story.
    • Hello there! I didn't quite know where to go regarding this, but ended up deciding to post it here. I have been running a forge server with around 200 mods for me and some friends to play on casually, but have recently started to get an issue when booting the server. This all started after I decided to add some new mods to the server. Like usual, I add a mod, test run the server for any issues, and if all is well, I'll add a next one and so on until I have added all that I wanted to. After doing so, in all test runs, it all seemed to work just fine. However, the next day, after trying to boot the server, I kept getting an error regarding java.lang.NullPointerException, towards one of the mods I had recently added. So far so good, I removed the mod that was causing the issue, started up the server again, and here in when things took a turn for the worse. I received another java.lang.NullPointerException null error that wouldn't allow me to boot the server, but this time with a mod that wasn't part of the new ones I had recently added. I found this weird, but nonetheless, I removed it thinking it might be causing some conflicts with some of the new ones. Afterwards, booting the server again proved to be impossible, as it gave me another java.lang.NullPointerException null error with the 3rd mod I had ever installed on the server! This mod was there since the start, it added some biomes and had been just fine so far. This turn of events made me remove all the newer mods I had recently added in hopes to fix this whole ordeal, but alas, to no avail. Same error, with that same biome mod that had been there since day one. Reluctantly, I removed the biome mod, booted the server, and voila! The server was running, although without a major mod that had always been there to begin with. As I do not wish to part ways with this mod, specially since it had been working so far without any issues, I tried to bring everything back to how it was before I added those new mods, but kept on getting the same java.lang.NullPointerException null error for the biome mod. Even adding the newer mods won't cause me this error, with exception of the one that started it all, which I find quite odd since the mods I had been using without any issues are now giving me the same error the newer one that started it all gave me. Now, I have checked that everything is up to date regarding the mods, forge (forge-1.20.1-47.3.12) and java. The modpack runs perfectly fine when I start Minecraft itself, and play singleplayer, or even when I open a LAN world, everything works. Everything aside from the server. From what I could gather, this java.lang.NullPointerException null error would point to a missing value of sorts, for an item perhaps, within the mod that is causing the error, but aside from removing the whole mod, I lack the knowledge on how to fix this. With this in mind, if anyone would be so kind as to shine some light into this situation, with a way to fix all this blunder, I would be most grateful!
    • If you want a mana GUI, call Minecraft.getInstance().setScreen(new ManaScreen()); somewhere display your GUI. I would recommend creating a keybind and listening to key events, and if your key bind is pressed down, running that code.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.