[1.16.3] Registering LootFunctionType and LootConditionType

[The_Wabbit]

For 1.16.x custom loot conditions and loot functions require registration of matching LootConditionType and LootFunctionType. There are no hooks via Forge registry events and using the builtin registry directly (sample how below) doesn't work (tried doing before registry events and after...nada).

Registry.register(Registry.LOOT_CONDITION_TYPE, <my_name>, new LootConditionType(<my_serializer>))

 

This is probably staring me right in the eyeball, but I can't see it. Any directions/samples would be appreciated.

 

[Draco18s]

"The guy who wrote this had to test it somehow! I wonder if he wrote any test code and where I might find it...maybe the Forge Github? Nah, couldn't be there, that would be dumb."

https://github.com/MinecraftForge/MinecraftForge/blob/1.16.x/src/test/java/net/minecraftforge/debug/gameplay/loot/GlobalLootModifiersTest.java#L83

[Choonster]

2 hours ago, Draco18s said:

"The guy who wrote this had to test it somehow! I wonder if he wrote any test code and where I might find it...maybe the Forge Github? Nah, couldn't be there, that would be dumb."

https://github.com/MinecraftForge/MinecraftForge/blob/1.16.x/src/test/java/net/minecraftforge/debug/gameplay/loot/GlobalLootModifiersTest.java#L83

 

The OP is asking about Vanilla loot conditions and functions, not global loot modifiers.

 

11 hours ago, The_Wabbit said:

For 1.16.x custom loot conditions and loot functions require registration of matching LootConditionType and LootFunctionType. There are no hooks via Forge registry events and using the builtin registry directly (sample how below) doesn't work (tried doing before registry events and after...nada).

Registry.register(Registry.LOOT_CONDITION_TYPE, <my_name>, new LootConditionType(<my_serializer>))

 

This is probably staring me right in the eyeball, but I can't see it. Any directions/samples would be appreciated.

 

 

I'm not 100% sure if it's the correct time to register them, but I do it on the main thread after FMLCommonSetupEvent (i.e. inside a lambda passed to event.enqueueWork). I use the Vanilla registries, just like in your example.

 

I'm not sure if it's necessary to register non-Forge registry entries at any specific time like it is with Forge registry entries.

 

This is my FMLCommonSetup handler, this is my LootConditionType registration and this is my LootFunctionType registration.

[Draco18s]

12 minutes ago, Choonster said:

The OP is asking about Vanilla loot conditions and functions, not global loot modifiers.

Oops, you're right.