[1.15.2] [SOLVED] - Change Player's Dimension on Right Click

[ModMCdl]

Hello. I have an item that I want onItemRightClick to check the player's dimension and then send the player to a specific dimension based on which dim is returned. The problem is that I can't figure out how to check which dimension the player is in. The method I would use in 1.12 used to be stored in the PlayerEntity, but it doesn't appear to be anymore. Can anyone point me in the right direction?

Thanks.

Edited November 13, 2020 by ModMCdl
problem solved

[ModMCdl]

UPDATE: I figured it out, but now it's spawning nether portals when teleporting, and I do not know why. I based this method off of the block collision in the EndPortalBlock, so I am not sure why or how this is happening.

 @Override
        public ActionResult<ItemStack> onItemRightClick(World world, PlayerEntity player, Hand hand)
        {
           if (!world.isRemote)
           {
                player.changeDimension(world.dimension.getType() == DimensionType.byName(VoidaicDepths.VOID_DIM_TYPE) ? DimensionType.OVERWORLD : DimensionType.byName(VoidaicDepths.VOID_DIM_TYPE));
           }

           return super.onItemRightClick(world, player, hand);
        }

 

 

[ModMCdl]

14 hours ago, diesieben07 said:

You need to implement ITeleporter and pass it to changeDimension.

Do you have an example of this? I would think it would be something like this, but I can't quite get it to work.

@Override
        public ActionResult<ItemStack> onItemRightClick(World world, PlayerEntity player, Hand hand)
        {
           if (!world.isRemote)
           {
               player.changeDimension(world.dimension.getType() == DimensionType.byName(VoidaicDepths.VOID_DIM_TYPE) ? DimensionType.OVERWORLD : DimensionType.byName(VoidaicDepths.VOID_DIM_TYPE)), new VoidTeleporter(ServerWorld);
           }

           return super.onItemRightClick(world, player, hand);
        }

Trying to implement my custom teleporter VoidTeleporter is not working, and is erroring out. 

 

VoidTeleporter.class

public class VoidTeleporter extends Teleporter
{
    public VoidTeleporter(ServerWorld world)
    {
        super(world);
    }

    @Override
    public Entity placeEntity(Entity entity, ServerWorld currentWorld, ServerWorld destWorld, float yaw, Function<Boolean, Entity> repositionEntity)
    {
        return repositionEntity.apply(false);
    }
}

 

Edited November 9, 2020 by ModMCdl

[ModMCdl]

2 minutes ago, diesieben07 said:

"erroring out" is entirely unhelpful as a problem description.

Also, implement ITeleporter, do not extend Teleporter.

Apologies, I meant that PlayerEntity#changeDimension was not accepting the custom teleporter.

 

As for implementing instead of extending, would you mean something like this? (Basing it off of the Teleporter.java, but neglecting portal creation.)

public class VoidTeleporter implements ITeleporter
{
    protected final ServerWorld world;
    protected final Random random;

    public VoidTeleporter(ServerWorld worldIn) {
        this.world = worldIn;
        this.random = new Random(worldIn.getSeed());
    }
}

 

If so, then how would I then pass this to my changeDimension method? Or do I need to trace back how PlayerEntity does it and recreate that for my custom teleporter. Looking into it, it seems like PlayerEntity#changeDimension has a parameter for setting the type of teleporter, but as I stated above, the method is not accepting mine.

[poopoodice]

It should, as ServerPlayerEntity#changeDimention takes ITeleporter as it's second parameter.

[ModMCdl]

2 hours ago, poopoodice said:

It should, as ServerPlayerEntity#changeDimention takes ITeleporter as it's second parameter.

Okay, so I got this to work:

               player.changeDimension(world.dimension.getType() == DimensionType.byName(VoidaicDepths.VOID_DIM_TYPE) ? DimensionType.OVERWORLD : DimensionType.byName(VoidaicDepths.VOID_DIM_TYPE), new VoidTeleporter((ServerWorld) player.getEntityWorld()));

However, it is still generating nether portals upon changing dimensions.

[ModMCdl]

UPDATE:

Okay, so I finally got this to work. I used the method as I had pasted in my previous post:

               player.changeDimension(world.dimension.getType() == DimensionType.byName(VoidaicDepths.VOID_DIM_TYPE) ? DimensionType.OVERWORLD : DimensionType.byName(VoidaicDepths.VOID_DIM_TYPE), new VoidTeleporter((ServerWorld) player.getEntityWorld()));

 

in combination with this VoidTeleporter.java that I was told wouldn't work/I shouldn't use:

 

public class VoidTeleporter extends Teleporter
{
    public VoidTeleporter(ServerWorld world)
    {
        super(world);
    }

    @Override
    public Entity placeEntity(Entity entity, ServerWorld currentWorld, ServerWorld destWorld, float yaw, Function<Boolean, Entity> repositionEntity)
    {
        return repositionEntity.apply(false);
    }
}

 

It works - I teleport between the desired dimensions without generating nether portals. I'm hesitant to call this solved though, as I would like to know why I should not be extending Teleporter.

Edited November 10, 2020 by ModMCdl

[vemerion]

5 hours ago, ModMCdl said:

It works - I teleport between the desired dimensions without generating nether portals. I'm hesitant to call this solved though, as I would like to know why I should not be extending Teleporter.

Teleporter is the vanilla Minecraft class, while ITeleporter is the forge alternative. There is no reason the extends Teleporter, since everything you get from it is a bunch of portal spawning logic. Your VoidTeleporter should work as desired if you implement ITeleporter, but keep the placeEntity override, since as the documentation in ITeleporter says, a portal will not spawn if you supply the Function with false.

[ModMCdl]

On 11/10/2020 at 3:34 AM, vemerion said:

Teleporter is the vanilla Minecraft class, while ITeleporter is the forge alternative. There is no reason the extends Teleporter, since everything you get from it is a bunch of portal spawning logic. Your VoidTeleporter should work as desired if you implement ITeleporter, but keep the placeEntity override, since as the documentation in ITeleporter says, a portal will not spawn if you supply the Function with false.

Alright, thank you! It has been implemented and it works like a charm!