Heya,

So, I tried making a GUI in minecraft, and everything was going smoothly, it all compiled, and Minecraft ran without a problem.

 

However, when I actually tried to right click the block, instead of opening the GUI, nothing happened and the debug console greeted me with this message:

 

[15:30:04] [Server thread/FATAL] [minecraft/ThreadTaskExecutor]: Error executing task on Server
java.lang.UnsupportedOperationException: Unable to construct this menu by type
    at net.minecraft.inventory.container.Container.getType(Container.java:56) ~[forge:?] {re:classloading}
    at net.minecraftforge.fml.network.NetworkHooks.openGui(NetworkHooks.java:223) ~[forge:?] {re:classloading}
    at net.minecraftforge.fml.network.NetworkHooks.openGui(NetworkHooks.java:188) ~[forge:?] {re:classloading}
    at com.thamajorn.scullery.procedures.OpenProcedure.executeProcedure(OpenProcedure.java:63) ~[?:?] {re:classloading}
    at com.thamajorn.scullery.blocks.Cuttingboard.onBlockActivated(Cuttingboard.java:103) ~[?:?] {re:classloading}
    at net.minecraft.block.AbstractBlock$AbstractBlockState.onBlockActivated(AbstractBlock.java:730) ~[forge:?] {re:classloading}
    at net.minecraft.server.management.PlayerInteractionManager.func_219441_a(PlayerInteractionManager.java:347) ~[forge:?] {re:classloading}
    at net.minecraft.network.play.ServerPlayNetHandler.processTryUseItemOnBlock(ServerPlayNetHandler.java:986) ~[forge:?] {re:classloading}
    at net.minecraft.network.play.client.CPlayerTryUseItemOnBlockPacket.processPacket(CPlayerTryUseItemOnBlockPacket.java:45) ~[forge:?] {re:classloading}
    at net.minecraft.network.play.client.CPlayerTryUseItemOnBlockPacket.processPacket(CPlayerTryUseItemOnBlockPacket.java:12) ~[forge:?] {re:classloading}
    at net.minecraft.network.PacketThreadUtil.lambda$checkThreadAndEnqueue$0(PacketThreadUtil.java:19) ~[forge:?] {re:classloading}
    at net.minecraft.util.concurrent.TickDelayedTask.run(TickDelayedTask.java:20) ~[forge:?] {re:classloading}
    at net.minecraft.util.concurrent.ThreadTaskExecutor.run(ThreadTaskExecutor.java:139) ~[forge:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.util.concurrent.RecursiveEventLoop.run(RecursiveEventLoop.java:22) ~[forge:?] {re:classloading}
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:758) ~[forge:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:159) ~[forge:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.util.concurrent.ThreadTaskExecutor.driveOne(ThreadTaskExecutor.java:109) ~[forge:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.server.MinecraftServer.driveOneInternal(MinecraftServer.java:741) ~[forge:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.server.MinecraftServer.driveOne(MinecraftServer.java:735) ~[forge:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.util.concurrent.ThreadTaskExecutor.driveUntil(ThreadTaskExecutor.java:122) ~[forge:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.server.MinecraftServer.runScheduledTasks(MinecraftServer.java:721) ~[forge:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.server.MinecraftServer.func_240802_v_(MinecraftServer.java:667) ~[forge:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.server.MinecraftServer.lambda$startServer$0(MinecraftServer.java:233) ~[forge:?] {re:classloading,pl:accesstransformer:B}
    at java.lang.Thread.run(Thread.java:748) [?:1.8.0_261] {}

 

The game never crashed or anything, it would just give that message whenever I right clicked the block.

If anyone can help or at least point me in the right direction, that would be much appreciated!

I'm guessing the ContainerType isn't registered. However, you should provide a repository with your code so there is no guessing required.

Hey, sorry for the late reply,

here is the repository:
https://github.com/TheMajorN/sculleryProject.git

Edited November 10, 20204 yr by TheMajorN

Yep, you don't properly register the ContainerType. You are calling the initialization before the ContainerType is even registered. This is not to mention that the container type will remain null until the constructor is called.

 

This also brings up logical sides and handling. You are trying to construct a random instance without a true container and compressing them all into one file. Please properly adhere to separation of concerns. There are a few issues, but technically, it will work regardless of the non-forge way of handling.

 

 

Thank you so much for the tips, so I should move the init method to after the container type register?

 

Also, how should I better adhere to the separation of concerns?

 

Sorry for all the questions, I'm still fairly new to this.

 

Thanks again!

Edited November 11, 20204 yr by TheMajorN

9 minutes ago, TheMajorN said:

Thank you so much for the tips, so I should move the init method to after the container type register?

Well the initialization method holds a client only method for registering screens which would be handled in FMLClientSetupEvent. It should also use enqueueWork which is provided by the event itself instead of calling DeferredWorkQueue directly.

 

11 minutes ago, TheMajorN said:

Also, how should I better adhere to the separation of concerns?

I would suggest reading about it and determining for yourself. In the most cases, client, common, and dedicated server code should be separated. Also, you might want to consider renaming your classes to better match the current class names of Forge.

 

12 minutes ago, TheMajorN said:

Sorry for all the questions, I'm still fairly new to this.

It's perfectly fine. As long as you understand the underlying language, we can explain how it works.

Alright, thanks, I'll look into that.  You've been a great help.

Howdy 

 

You might find this tutorial mod useful; it has a working example of how to create a block with a GUI (in this case - a simple chest)

https://github.com/TheGreyGhost/MinecraftByExample/tree/master/src/main/java/minecraftbyexample/mbe30_inventory_basic

 

-TGG

Oh thank you, I'll deffo give this a look