I am currently trying to make the fake watersource block in the center of this model https://gist.github.com/raziel23x/af84f9d7b10f8e8e7974b5d8ac14d4ce to visually look like a minture water still source block but i am unable to figure out in code how to have the color of the texture to change to the correct color of the current biome its placed in and share the same color proteries of the actual water source block i am unsure how to make the calls to biome color in my block https://gist.github.com/raziel23x/63a79110599abcedadb9eab0fbddcbe8 to do so

 

 

Edited November 21, 20204 yr by raziel23x

One way to add Biome colors to blocks is by registering directly in the client proxy. A few different examples below. In your case, the example with the oak hedge will let your block change with biome, and change getFoliageColor() to getWaterColor().

 

private void registerColors() {

BlockColors blockcolors = Minecraft.getInstance().getBlockColors(); 
ItemColors itemcolors = Minecraft.getInstance().getItemColors(); 

blockcolors.register((state, world, pos, tintIndex) -> 12665871, 
     ModBlocks.HEDGE_RED_MAPLE);

blockcolors.register((state, reader, pos, i) -> FoliageColors.getSpruce(), 
     ModBlocks.SPRUCE_LEAF_CARPET, ModBlocks.HEDGE_SPRUCE); 

blockcolors.register((state, reader, pos, i) -> reader != null && pos != null ? BiomeColors.getFoliageColor(reader, pos) : FoliageColors.getDefault(), 
     ModBlocks.OAK_LEAF_CARPET, ModBlocks.HEDGE_OAK, 

itemcolors.register((stack, i) -> { 
     BlockState state = ((BlockItem)stack.getItem()).getBlock().getDefaultState(); 
     return blockcolors.getColor(state, null, null, i); 
}, ModBlocks.OAK_LEAF_CARPET, ModBlocks.HEDGE_OAK, ModBlocks.SPRUCE_LEAF_CARPET, 
ModBlocks.HEDGE_SPRUCE, ModBlocks.HEDGE_RED_MAPLE);

}

Edited November 20, 20204 yr by urbanxx001

Well i tried it this way and when i run the code it crashes so i am scratching my head on this one

 

package raziel23x.projectskyblock.events;

import net.minecraft.client.Minecraft;
import net.minecraft.client.renderer.color.BlockColors;
import net.minecraft.world.biome.BiomeColors;
import net.minecraftforge.api.distmarker.Dist;
import net.minecraftforge.client.event.ColorHandlerEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;
import raziel23x.projectskyblock.ProjectSkyblock;
import raziel23x.projectskyblock.utils.RegistryHandler;

@Mod.EventBusSubscriber(modid = ProjectSkyblock.MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT)
public class ClientEvents {
    @SubscribeEvent
    public static void registerBlockColors(ColorHandlerEvent.Block event) {
        BlockColors blockcolors = Minecraft.getInstance().getBlockColors();

        blockcolors.register((state, reader, pos, color) -> reader != null && pos != null ? BiomeColors.getWaterColor(reader, pos) : -1, RegistryHandler.WATER_GENERATOR_BLOCK.get());
    }
}

 

Please provide the crash log, and you should probably get the block colours from the event instead of minecraft instance.

https://gist.github.com/raziel23x/e6a0c407c5be4ecda1195ac7d19dc564

Yeah it can be handled like that if you get it from the event, the way it was done with the instance is adding it to FMLClientSetupEvent.

Edited November 20, 20204 yr by urbanxx001

i have been following tutorials and trying to learn as i go so i am kinda lost at this

I recommend taking a look at the Forge documentation for events. In your Main class, the mod event bus is added as:

@Mod(Main.MOD_ID)
@Mod.EventBusSubscriber(bus = Mod.EventBusSubscriber.Bus.MOD)
public class Main {
    public static final String MOD_ID = "mod_id";
    public Main() {
         final IEventBus eventBus = FMLJavaModLoadingContext.get().getModEventBus();
         eventBus.addListener(this::onCommonSetup);
         eventBus.addListener(this::onClientSetup);
    }
    private void onClientSetup(FMLClientSetupEvent event) {
        registerColors();
    }
}

 

Alternatively, if you do the subscribe event, Poopoodice is saying you can get the colors from the event like:

BlockColors blockcolors = event.getBlockColors();

Edited November 20, 20204 yr by urbanxx001

this is what i have done so far

https://github.com/raziel23x/Project-Skyblock the water gen is what the issue is with

Well now i have the placed item working i am still having issues with the held item

 

package raziel23x.projectskyblock.events;

import net.minecraft.block.BlockState;
import net.minecraft.client.renderer.color.BlockColors;
import net.minecraft.client.renderer.color.ItemColors;
import net.minecraft.item.BlockItem;
import net.minecraft.world.biome.BiomeColors;
import net.minecraftforge.api.distmarker.Dist;
import net.minecraftforge.client.event.ColorHandlerEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;
import raziel23x.projectskyblock.ProjectSkyblock;
import raziel23x.projectskyblock.utils.RegistryHandler;



@Mod.EventBusSubscriber(modid = ProjectSkyblock.MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT)
public class ClientEvents {


    @SubscribeEvent
    public static void registerBlockColors(ColorHandlerEvent.Block event) {

        BlockColors blockcolors = event.getBlockColors();

        blockcolors.register((state, reader, pos, color) -> reader != null && pos != null ? BiomeColors.getWaterColor(reader, pos) : -1, RegistryHandler.WATER_GENERATOR_BLOCK.get());

    }

    @SubscribeEvent
    public static void registerItemColors(ColorHandlerEvent.Item event) {

        ItemColors itemcolors = event.getItemColors();
        BlockColors blockcolors = event.getBlockColors();

        itemcolors.register((stack, i) -> {
            BlockState state = ((BlockItem)stack.getItem()).getBlock().getDefaultState();
            return blockcolors.getColor(state, null, null, i);
        }, RegistryHandler.WATER_GENERATOR_BLOCK_ITEM.get());
    }
}

 

Edited November 20, 20204 yr by raziel23x

well i just found out that -1 is white but what are my other choices