Search the Forums BEFORE making a new post.

Currently supported: All versions

[1.15.2] How to make an entity save data

Posted November 22, 20204 yr

How would I make an entity save a float value?

I have looked into capabilities, but they seem a little to complicated to save a single float.

Quote

November 22, 20204 yr

Is the entity yours or is it a vanilla one?

Check out the port of the BetterEnd fabric mod (WIP): https://www.curseforge.com/minecraft/mc-mods/betterend-forge-port

Quote

November 23, 20204 yr

Author

oh yeah, its a custom entity.

Quote

November 23, 20204 yr

Author

I have already done that and it seems to do nothing

Edited November 23, 20204 yr by someRandomKid

Quote

November 23, 20204 yr

Author

public class Car extends AbstractChestedHorseEntity {
    public boolean outofgas;
    private boolean particle_reducer;
   // public static final DataParameter<Float> health = EntityDataManager.createKey(Car.class, DataSerializers.FLOAT);

    public Car(EntityType<? extends Car> type, World worldIn) {
        super(type, worldIn);
        this.outofgas = false;
        this.particle_reducer = false;
    }

    //forgot to do super.registerAttributes() [Sorry]
    @Override
    protected void registerAttributes() {
        this.getAttributes().registerAttribute(SharedMonsterAttributes.MAX_HEALTH);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.MOVEMENT_SPEED);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.FOLLOW_RANGE);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.KNOCKBACK_RESISTANCE);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.ARMOR);
        this.getAttributes().registerAttribute(LivingEntity.SWIM_SPEED);
        this.getAttributes().registerAttribute(LivingEntity.ENTITY_GRAVITY);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.ARMOR_TOUGHNESS);
        this.getAttribute(SharedMonsterAttributes.KNOCKBACK_RESISTANCE).setBaseValue(1.0F);
        this.getAttribute(SharedMonsterAttributes.MOVEMENT_SPEED).setBaseValue(0.4F);
        this.getAttribute(SharedMonsterAttributes.MAX_HEALTH).setBaseValue(40.0F);
        this.getAttribute(SharedMonsterAttributes.FOLLOW_RANGE).setBaseValue(0.0F);
        this.getAttribute(SharedMonsterAttributes.ARMOR).setBaseValue(2.0F);
        this.getAttribute(SharedMonsterAttributes.ARMOR_TOUGHNESS).setBaseValue(2.0F);
        this.getAttribute(LivingEntity.SWIM_SPEED).setBaseValue(0.05F);
    }

    @Override
    protected void registerData() {
        super.registerData();
       // this.dataManager.register(health, 20.0F);
    }

    @Override
    protected void registerGoals() {

    }



    @Override
    public boolean canBeLeashedTo(PlayerEntity player) {
        return false;

    }

    @Override
    public void readAdditional(@NotNull CompoundNBT compound) {
        super.readAdditional(compound);
        this.setFuelValue(compound.getFloat("movedDistance"));
    }

    @Override
    public void writeAdditional(@NotNull CompoundNBT compound) {
        super.writeAdditional(compound);
        compound.putFloat("movedDistance", this.movedDistance);
    }



    @Override
    public void tick() {
        super.tick();
        outofgas = this.movedDistance > 2000;
        this.particle_reducer = !this.particle_reducer;
        ClientWorld world = Minecraft.getInstance().world;
        Vec3d vec = new Vec3d(this.getPosX(),this.getPosY(), this.getPosZ());
        Vec3d speedvec = new Vec3d(-0.3d, 0.2d, 0d);
        vec.add(this.getLookVec());
        if(world != null && !this.outofgas && this.particle_reducer)
            world.addParticle(ParticleTypes.SQUID_INK, vec.x, vec.y, vec.z, speedvec.x, speedvec.y, speedvec.z);
       // this.setHealth(this.getDataManager().get(Car.health));
    }


    public float getMovedDistance(){
        return this.movedDistance;
    }

    public void Refuel(){
        this.distanceWalkedModified = 0;
        this.distanceWalkedOnStepModified = 0;
        this.prevDistanceWalkedModified = 0;
        this.prevMovedDistance = 0;
        this.movedDistance = 0;
        LOGGER.info("REFUELED");
    }

    public void setFuelValue(float value){
        this.distanceWalkedModified = value;
        this.distanceWalkedOnStepModified = value;
        this.prevDistanceWalkedModified = value;
        this.prevMovedDistance = value;
        this.movedDistance = value;
    }


    @Override
    protected boolean canMate() {
        return false;
    }

    @Override
    public boolean canBreed() {
        return false;
    }


    @Nullable
    @Override
    protected SoundEvent getDeathSound() {
        return null;
    }

    @Nullable
    @Override
    protected SoundEvent getAmbientSound() {
        return null;
    }

    @Nullable
    @Override
    protected SoundEvent getHurtSound(DamageSource damageSourceIn) {
        return null;
    }

    @Override
    protected void playStepSound(BlockPos pos, BlockState blockIn) {
        // this.playSound(ModSoundEvents.MOVING_CAR, 0.5F, 1.0F);

    }

    @Override
    public void setMoveStrafing(float amount) {}

    @Override
    public boolean hasChest() {
        return true;
    }

    @Override
    public boolean isTame() {
        return true;
    }

    @Override
    public boolean canEatGrass() {
        return false;
    }

    @Override
    public boolean isHorseSaddled() {
        return !this.outofgas;
    }

    @Override
    public boolean canBeSteered() {
        return !this.outofgas;
    }

    @Override
    public boolean isBreedingItem(@NotNull ItemStack stack) {
        return false;
    }



    @Override
    public boolean wearsArmor() {
        return false;
    }

    @Override
    public boolean canDespawn(double distanceToClosestPlayer) {
        return false;
    }



    @Override
    public boolean canJump() {
        return false;
    }

    @Override
    public boolean canBeRiddenInWater() {
        return false;
    }

    @Override
    public boolean canBePushed() {
        return false;
    }

    @Override
    public boolean canBeSaddled() {
        return false;
    }

    @Override
    protected int getInventorySize() {
        return 29;
    }

    @Override
    public int getInventoryColumns() {
        return 9;
    }
}

Quote

November 23, 20204 yr

Author

the value just resets to 0.

Quote

November 23, 20204 yr

Author

I have some gui that tells me the number.

Quote

November 23, 20204 yr

Author

are you sure about that, because its just text:

@SubscribeEvent
public void onRenderGui(RenderGameOverlayEvent.Post event){
    Minecraft minecraft = Minecraft.getInstance();
    if (event.isCancelable() || event.getType() != RenderGameOverlayEvent.ElementType.EXPERIENCE) {
        return;
    }
    FontRenderer font = minecraft.fontRenderer;
    PlayerEntity player = minecraft.player;
    if(player == null)
        return;
    LivingEntity RidingEntity = (LivingEntity)player.getRidingEntity();
    if(RidingEntity != null) {
        if (RidingEntity instanceof Car) {
            Car car = (Car) RidingEntity;
            ChatFormatting chat = (car.getMovedDistance() > 1500) ? ChatFormatting.RED : ChatFormatting.GREEN;
            font.drawStringWithShadow(chat + "Fuel:" + (2000-car.getMovedDistance())/20 + "%", 5, 5, 0);
        }
    }
    Entity entity = minecraft.pointedEntity;
    if(entity instanceof PlaceholderEntity){
        ChatFormatting chat = ChatFormatting.GREEN;
        font.drawStringWithShadow(chat+"Entity ID:"+entity.getEntityId(), 5,5, 0);
    }
}

Quote

November 23, 20204 yr

Author

do I use the data manager for that?

Quote

November 23, 20204 yr

Author

what do you mean by that? that text is always rendering no matter if the horse gui is opened or not.

Quote

November 23, 20204 yr

Author

I tried using the data manager and it didn't work

Quote

November 23, 20204 yr

Author

//updated code
public class Car extends AbstractChestedHorseEntity {
    public boolean outofgas;
    private boolean particle_reducer;
   public static final DataParameter<Float> Fuel = EntityDataManager.createKey(Car.class, DataSerializers.FLOAT);

    public Car(EntityType<? extends Car> type, World worldIn) {
        super(type, worldIn);
        this.outofgas = false;
        this.particle_reducer = false;
    }

    //forgot to do super.registerAttributes() [Sorry]
    @Override
    protected void registerAttributes() {
        this.getAttributes().registerAttribute(SharedMonsterAttributes.MAX_HEALTH);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.MOVEMENT_SPEED);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.FOLLOW_RANGE);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.KNOCKBACK_RESISTANCE);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.ARMOR);
        this.getAttributes().registerAttribute(LivingEntity.SWIM_SPEED);
        this.getAttributes().registerAttribute(LivingEntity.ENTITY_GRAVITY);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.ARMOR_TOUGHNESS);
        this.getAttribute(SharedMonsterAttributes.KNOCKBACK_RESISTANCE).setBaseValue(1.0F);
        this.getAttribute(SharedMonsterAttributes.MOVEMENT_SPEED).setBaseValue(0.4F);
        this.getAttribute(SharedMonsterAttributes.MAX_HEALTH).setBaseValue(40.0F);
        this.getAttribute(SharedMonsterAttributes.FOLLOW_RANGE).setBaseValue(0.0F);
        this.getAttribute(SharedMonsterAttributes.ARMOR).setBaseValue(2.0F);
        this.getAttribute(SharedMonsterAttributes.ARMOR_TOUGHNESS).setBaseValue(2.0F);
        this.getAttribute(LivingEntity.SWIM_SPEED).setBaseValue(0.05F);
    }

    @Override
    protected void registerData() {
        super.registerData();
        this.dataManager.register(Fuel, 0.0F);
    }

    @Override
    protected void registerGoals() {

    }



    @Override
    public boolean canBeLeashedTo(PlayerEntity player) {
        return false;

    }

    @Override
    public void readAdditional(@NotNull CompoundNBT compound) {
        super.readAdditional(compound);
        this.setFuelValue(compound.getFloat("movedDistance"));
    }

    @Override
    public void writeAdditional(@NotNull CompoundNBT compound) {
        super.writeAdditional(compound);
        compound.putFloat("movedDistance", this.movedDistance);
    }



    @Override
    public void tick() {
        super.tick();
        outofgas = this.movedDistance > 2000;
        this.particle_reducer = !this.particle_reducer;
        ClientWorld world = Minecraft.getInstance().world;
        Vec3d vec = new Vec3d(this.getPosX(),this.getPosY(), this.getPosZ());
        Vec3d speedvec = new Vec3d(-0.3d, 0.2d, 0d);
        vec.add(this.getLookVec());
        this.getDataManager().set(Fuel, this.movedDistance);
        if(world != null && !this.outofgas && this.particle_reducer)
            world.addParticle(ParticleTypes.SQUID_INK, vec.x, vec.y, vec.z, speedvec.x, speedvec.y, speedvec.z);
       // this.setHealth(this.getDataManager().get(Car.health));
    }


    public void Refuel(){
        this.distanceWalkedModified = 0;
        this.distanceWalkedOnStepModified = 0;
        this.prevDistanceWalkedModified = 0;
        this.prevMovedDistance = 0;
        this.movedDistance = 0;
        LOGGER.info("REFUELED");
    }

    public void setFuelValue(float value){
        this.distanceWalkedModified = value;
        this.distanceWalkedOnStepModified = value;
        this.prevDistanceWalkedModified = value;
        this.prevMovedDistance = value;
        this.movedDistance = value;
    }


    @Override
    protected boolean canMate() {
        return false;
    }

    @Override
    public boolean canBreed() {
        return false;
    }


    @Nullable
    @Override
    protected SoundEvent getDeathSound() {
        return null;
    }

    @Nullable
    @Override
    protected SoundEvent getAmbientSound() {
        return null;
    }

    @Nullable
    @Override
    protected SoundEvent getHurtSound(DamageSource damageSourceIn) {
        return null;
    }

    @Override
    protected void playStepSound(BlockPos pos, BlockState blockIn) {
        // this.playSound(ModSoundEvents.MOVING_CAR, 0.5F, 1.0F);

    }

    @Override
    public void setMoveStrafing(float amount) {}

    @Override
    public boolean hasChest() {
        return true;
    }

    @Override
    public boolean isTame() {
        return true;
    }

    @Override
    public boolean canEatGrass() {
        return false;
    }

    @Override
    public boolean isHorseSaddled() {
        return !this.outofgas;
    }

    @Override
    public boolean canBeSteered() {
        return !this.outofgas;
    }

    @Override
    public boolean isBreedingItem(@NotNull ItemStack stack) {
        return false;
    }



    @Override
    public boolean wearsArmor() {
        return false;
    }

    @Override
    public boolean canDespawn(double distanceToClosestPlayer) {
        return false;
    }



    @Override
    public boolean canJump() {
        return false;
    }

    @Override
    public boolean canBeRiddenInWater() {
        return false;
    }

    @Override
    public boolean canBePushed() {
        return false;
    }

    @Override
    public boolean canBeSaddled() {
        return false;
    }

    @Override
    protected int getInventorySize() {
        return 29;
    }

    @Override
    public int getInventoryColumns() {
        return 9;
    }
}

Edited November 23, 20204 yr by someRandomKid

Quote

November 23, 20204 yr

Author

oh wait I just realized how dumb I was

this is what it should be:

this.dataManager.register(Fuel, this.movedDistance);

Edited November 23, 20204 yr by someRandomKid

Quote

November 23, 20204 yr

Author

I am syncing them in the tick function.

It still is not working.

Edited November 23, 20204 yr by someRandomKid

Quote

November 23, 20204 yr

Author

updated code:

package com.new_swords.Entities;

import net.minecraft.block.BlockState;
import net.minecraft.client.Minecraft;
import net.minecraft.client.world.ClientWorld;
import net.minecraft.entity.EntityType;
import net.minecraft.entity.LivingEntity;
import net.minecraft.entity.SharedMonsterAttributes;
import net.minecraft.entity.passive.horse.AbstractChestedHorseEntity;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.CompoundNBT;
import net.minecraft.network.datasync.DataParameter;
import net.minecraft.network.datasync.DataSerializers;
import net.minecraft.network.datasync.EntityDataManager;
import net.minecraft.particles.ParticleTypes;
import net.minecraft.util.DamageSource;
import net.minecraft.util.SoundEvent;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.Vec3d;
import net.minecraft.world.World;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;

public class Car extends AbstractChestedHorseEntity {
    public boolean outofgas;
    private boolean particle_reducer;
   public static final DataParameter<Float> Fuel = EntityDataManager.createKey(Car.class, DataSerializers.FLOAT);

    public Car(EntityType<? extends Car> type, World worldIn) {
        super(type, worldIn);
        this.outofgas = false;
        this.particle_reducer = false;
    }

    //forgot to do super.registerAttributes() [Sorry]
    @Override
    protected void registerAttributes() {
        this.getAttributes().registerAttribute(SharedMonsterAttributes.MAX_HEALTH);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.MOVEMENT_SPEED);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.FOLLOW_RANGE);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.KNOCKBACK_RESISTANCE);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.ARMOR);
        this.getAttributes().registerAttribute(LivingEntity.SWIM_SPEED);
        this.getAttributes().registerAttribute(LivingEntity.ENTITY_GRAVITY);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.ARMOR_TOUGHNESS);
        this.getAttribute(SharedMonsterAttributes.KNOCKBACK_RESISTANCE).setBaseValue(1.0F);
        this.getAttribute(SharedMonsterAttributes.MOVEMENT_SPEED).setBaseValue(0.4F);
        this.getAttribute(SharedMonsterAttributes.MAX_HEALTH).setBaseValue(40.0F);
        this.getAttribute(SharedMonsterAttributes.FOLLOW_RANGE).setBaseValue(0.0F);
        this.getAttribute(SharedMonsterAttributes.ARMOR).setBaseValue(2.0F);
        this.getAttribute(SharedMonsterAttributes.ARMOR_TOUGHNESS).setBaseValue(2.0F);
        this.getAttribute(LivingEntity.SWIM_SPEED).setBaseValue(0.05F);
    }

    @Override
    protected void registerData() {
        super.registerData();
        this.dataManager.register(Fuel, this.movedDistance);
    }

    @Override
    protected void registerGoals() {

    }



    @Override
    public boolean canBeLeashedTo(PlayerEntity player) {
        return false;

    }

    @Override
    public void readAdditional(@NotNull CompoundNBT compound) {
        super.readAdditional(compound);
        this.setFuelValue(compound.getFloat("movedDistance"));
    }

    @Override
    public void writeAdditional(@NotNull CompoundNBT compound) {
        super.writeAdditional(compound);
        compound.putFloat("movedDistance", this.movedDistance);
    }



    @Override
    public void tick() {
        super.tick();
        outofgas = this.movedDistance > 2000;
        this.particle_reducer = !this.particle_reducer;
        World world = this.getEntityWorld();
        Vec3d vec = new Vec3d(this.getPosX(),this.getPosY(), this.getPosZ());
        Vec3d speedvec = new Vec3d(-0.3d, 0.2d, 0d);
        vec.add(this.getLookVec());
        this.getDataManager().set(Fuel, this.movedDistance);
        if(!this.outofgas && this.particle_reducer)
            world.addParticle(ParticleTypes.SQUID_INK, vec.x, vec.y, vec.z, speedvec.x, speedvec.y, speedvec.z);
       // this.setHealth(this.getDataManager().get(Car.health));
    }


    public void Refuel(){
        this.distanceWalkedModified = 0;
        this.distanceWalkedOnStepModified = 0;
        this.prevDistanceWalkedModified = 0;
        this.prevMovedDistance = 0;
        this.movedDistance = 0;
        LOGGER.info("REFUELED");
    }

    public void setFuelValue(float value){
        this.distanceWalkedModified = value;
        this.distanceWalkedOnStepModified = value;
        this.prevDistanceWalkedModified = value;
        this.prevMovedDistance = value;
        this.movedDistance = value;
    }


    @Override
    protected boolean canMate() {
        return false;
    }

    @Override
    public boolean canBreed() {
        return false;
    }


    @Nullable
    @Override
    protected SoundEvent getDeathSound() {
        return null;
    }

    @Nullable
    @Override
    protected SoundEvent getAmbientSound() {
        return null;
    }

    @Nullable
    @Override
    protected SoundEvent getHurtSound(DamageSource damageSourceIn) {
        return null;
    }

    @Override
    protected void playStepSound(BlockPos pos, BlockState blockIn) {
        // this.playSound(ModSoundEvents.MOVING_CAR, 0.5F, 1.0F);

    }

    @Override
    public void setMoveStrafing(float amount) {}

    @Override
    public boolean hasChest() {
        return true;
    }

    @Override
    public boolean isTame() {
        return true;
    }

    @Override
    public boolean canEatGrass() {
        return false;
    }

    @Override
    public boolean isHorseSaddled() {
        return !this.outofgas;
    }

    @Override
    public boolean canBeSteered() {
        return !this.outofgas;
    }

    @Override
    public boolean isBreedingItem(@NotNull ItemStack stack) {
        return false;
    }



    @Override
    public boolean wearsArmor() {
        return false;
    }

    @Override
    public boolean canDespawn(double distanceToClosestPlayer) {
        return false;
    }



    @Override
    public boolean canJump() {
        return false;
    }

    @Override
    public boolean canBeRiddenInWater() {
        return false;
    }

    @Override
    public boolean canBePushed() {
        return false;
    }

    @Override
    public boolean canBeSaddled() {
        return false;
    }

    @Override
    protected int getInventorySize() {
        return 29;
    }

    @Override
    public int getInventoryColumns() {
        return 9;
    }
}

Quote

November 23, 20204 yr

Author

So then how do I fix it?

So far I have fixed the tick function.

Edited November 23, 20204 yr by someRandomKid

Quote

November 23, 20204 yr

Author

then how would I do it server side?

Quote

November 23, 20204 yr

Author

so I would use if(!world.isRemote)?

Quote

November 23, 20204 yr

Author

ok so I did that, now what?

Quote

November 23, 20204 yr

Author

I guess that's fine, I was planning on making this mod open-source anyway

Quote

November 23, 20204 yr

Author

the value is not updating anymore

Quote

November 30, 20204 yr

Author

so after taking a break from modding (sorry for not responding!)

I finally figured out the problem.

The problem is that this.movedDistance doesn't get updated on the server, but is getting updated on client.

How would I fix that?

EDIT:

The data manager can't get the correct value to sync because this.movedDistance only gets updated on client.

So I think I have to make a packet for this to all work.

Edited November 30, 20204 yr by someRandomKid

Quote

December 4, 20204 yr

Author

SOLVED:

instead of using this.movedDistance I used this.distanceWalkedModified and it works fine.

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/94121-1152-how-to-make-an-entity-save-data/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

Minecraft crashes when trying to start singleplayer/create new world.

Thanks for the help! Removing lithostiched (& by proxy Tectonic) as well as Supplementaries did the trick!

By SynStar · 1 hour ago1 hr
Best Minecraft hosting 2024

If you're looking for a budget plan, check out MintServers, they offer Unlimited RAM and slots. With high end hardware, quick support team and great reviews on Trustpilot. Definitely best bang for your buck

By late2d2 · 2 hours ago2 hr
Minecraft crashes when trying to start singleplayer/create new world.

Make a test without lithostitched

By TileEntity · 5 hours ago5 hr
Minecraft crashes when trying to start singleplayer/create new world.

I've been trying to get an old modpack of mine working again (MC version 1.20.1, Forge version 47.4.8) & I finally got it to just load into the homescreen. Unfortunately, now its crashing whenever I try to start Singleplayer, specifically when its trying into the Create a New World screen. I've attached the latest Crash Report, though if that alone isn't enough I can also attach the Log in a comment. If anyone can help me figure out what's causing the issue I'd really appreciate it.

By SynStar · Posted 6 hours ago6 hr
exit code 1

S

By Drizzmic86 · Posted 17 hours ago17 hr

Paint_Ninja

Sign In

[1.15.2] How to make an entity save data

Featured Replies

Join the conversation

Posts

Minecraft crashes when trying to start singleplayer/create new world.

Best Minecraft hosting 2024

Minecraft crashes when trying to start singleplayer/create new world.

Minecraft crashes when trying to start singleplayer/create new world.

exit code 1

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)