Help with mod decompiling and BON2 mappings

[Ciomatx]

Hi everyone,

I'm trying to decompile a mod (Not Enough Roofs) for 1.12.2, to do that I used BON2 first to deobfuscate and BytecodeViewer (using fernflower, / CFR) to decompile it. Sadly I'm facing issues when I try to build it, the code seems to have a lot of method errors like:

cannot find symbol
      this.setTranslationKey(unlocalizedName);
          ^
  symbol: method setTranslationKey(String)

 

and if I get rid of these by replacing setTranslationKey with setUnlocalizedName, the build occurs well but minecraft crash when loading the mod, here's the crash-report:

java.lang.ClassCastException: notenoughroofs.items.BasicItem cannot be cast to net.minecraft.block.Block
	at net.minecraftforge.registries.GameData$BlockCallbacks.onAdd(GameData.java:284)
	at net.minecraftforge.registries.ForgeRegistry.add(ForgeRegistry.java:338)
	at net.minecraftforge.registries.ForgeRegistry.add(ForgeRegistry.java:269)
	at net.minecraftforge.registries.ForgeRegistry.register(ForgeRegistry.java:113)
	at net.minecraftforge.registries.ForgeRegistry.registerAll(ForgeRegistry.java:154)
	at notenoughroofs.items.ModItems.register(ModItems.java:27)
	at notenoughroofs.NotEnoughRoofs$RegistrationHandler.registerItems(NotEnoughRoofs.java:65)
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_7_RegistrationHandler_registerItems_Register.invoke(.dynamic)
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)
	at net.minecraftforge.fml.common.eventhandler.EventBus$1.invoke(EventBus.java:143)
	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:179)
	at net.minecraftforge.registries.GameData.fireRegistryEvents(GameData.java:736)
	at net.minecraftforge.fml.common.Loader.preinitializeMods(Loader.java:603)
	at net.minecraftforge.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:270)
	at net.minecraft.client.Minecraft.init(Minecraft.java:513)
	at net.minecraft.client.Minecraft.run(Minecraft.java:421)
	at net.minecraft.client.main.Main.main(Main.java:118)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97)
	at GradleStart.main(GradleStart.java:25)

 

I think it's a mapping problem, but in BON2 i can't find the 1.12.2 mappings, I used the 1.12 ones and I think that's the main problem.

What can I do about that? Are 1.12 and 1.12.2 mapping the same?

 

 

Thanks for considering my request

 

PS: I attached a BON2 screenshot with the mappings list.

Edited November 27, 2020 by Ciomatx

[DaemonUmbra]

Do you have permission from the author to do this?

[Ciomatx]

  On 11/27/2020 at 2:56 AM, DaemonUmbra said:

Do you have permission from the author to do this?

Expand  

From what I've seen on the curseforge website, It's under MIT Licence, so I think I can

The MIT License Copyright (c) Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

 

I also tried to get in touch with the mod author, and I didn't receive any answers yet.

By the way, if the author don't want me to use/modify his code, I will ofc respect his wishes! 

 

Thank you for your prompt reply though

[DaemonUmbra]

I should have brought this up first...

We don't support 1.12 anymore, if you want support you'll need to update to a modern version of Minecraft.