[1.5.2]Problems with Block Direction

[Vemahk20]

Alright, so in updating my mod to 1.5.2, everything went fine and smooth until I played the game, and when i placed a machine that was supposed to face the player, there was a set direction to it... If there is anyone who can help me out with a piece of code then it would be appreciated

[Draco18s]

Open up BlockFurnace.java

[Vemahk20]

What's funny is i just did that... after looking at what i said, but when i copied the script, it still didnt work... ive came to the conclusion that i really screwed something up when updating...

 

package IndustrialBreakout.Machines;

import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.block.BlockContainer;
import net.minecraft.block.material.Material;
import net.minecraft.client.renderer.texture.IconRegister;
import net.minecraft.entity.EntityLiving;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.tileentity.TileEntityChest;
import net.minecraft.tileentity.TileEntityFurnace;
import net.minecraft.util.Icon;
import net.minecraft.util.MathHelper;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import IndustrialBreakout.*;
import IndustrialBreakout.TileEntity.*;

public class BlockIBMachineRefiner extends BlockContainer
{
    /**
     * Is the random generator used by refiner to drop the inventory contents in random directions.
     */
    private Random refinerRand = new Random();

    /** True if this is an active refiner, false if idle */
    private final boolean isActive;

    /**
     * This flag is used to prevent the refiner inventory to be dropped upon block removal, is used internally when the
     * refiner block changes from idle to active and vice-versa.
     */
    private static boolean keepRefinerInventory = false;

    public BlockIBMachineRefiner(int par1, boolean par2)
    {
        super(par1, Material.rock);
        this.isActive = par2;
    }

    /**
     * Returns the ID of the items to drop on destruction.
     */
    public int idDropped(int par1, Random par2Random, int par3)
    {
        return mod_IndustrialBreakout.machineRefiner.blockID;
    }

    /**
     * Called whenever the block is added into the world. Args: world, x, y, z
     */
    public void onBlockAdded(World par1World, int par2, int par3, int par4)
    {
        super.onBlockAdded(par1World, par2, par3, par4);
        this.setDefaultDirection(par1World, par2, par3, par4);
    }

    /**
     * set a blocks direction
     */
    private void setDefaultDirection(World par1World, int par2, int par3, int par4)
    {
        if (!par1World.isRemote)
        {
            int var5 = par1World.getBlockId(par2, par3, par4 - 1);
            int var6 = par1World.getBlockId(par2, par3, par4 + 1);
            int var7 = par1World.getBlockId(par2 - 1, par3, par4);
            int var8 = par1World.getBlockId(par2 + 1, par3, par4);
            byte var9 = 3;

            if (Block.opaqueCubeLookup[var5] && !Block.opaqueCubeLookup[var6])
            {
                var9 = 3;
            }

            if (Block.opaqueCubeLookup[var6] && !Block.opaqueCubeLookup[var5])
            {
                var9 = 2;
            }

            if (Block.opaqueCubeLookup[var7] && !Block.opaqueCubeLookup[var8])
            {
                var9 = 5;
            }

            if (Block.opaqueCubeLookup[var8] && !Block.opaqueCubeLookup[var7])
            {
                var9 = 4;
            }

            par1World.setBlockMetadataWithNotify(par2, par3, par4, var9, 2);
        }
    }

    /**
     * Called upon block activation (right click on the block.)
     */
    public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int par6, float par7, float par8, float par9)
    {
        if (world.isRemote)
        {
            return true;
        }
        else
        {
            player.openGui(mod_IndustrialBreakout.instance, 3, world, x, y, z);
        }
        return true;
    }

    /**
     * Returns a new instance of a block's tile entity class. Called on placing the block.
     */
    public TileEntity createNewTileEntity(World par1World)
    {
        return new TileEntityRefiner();
    }

    /**
     * Called when the block is placed in the world.
     */
    public void onBlockPlacedBy(World par1World, int par2, int par3, int par4, EntityLiving par5EntityLiving, ItemStack par6ItemStack)
    {
        int l = MathHelper.floor_double((double)(par5EntityLiving.rotationYaw * 4.0F / 360.0F) + 0.5D) & 3;

        if (l == 0)
        {
            par1World.setBlockMetadataWithNotify(par2, par3, par4, 2, 2);
        }

        if (l == 1)
        {
            par1World.setBlockMetadataWithNotify(par2, par3, par4, 5, 2);
        }

        if (l == 2)
        {
            par1World.setBlockMetadataWithNotify(par2, par3, par4, 3, 2);
        }

        if (l == 3)
        {
            par1World.setBlockMetadataWithNotify(par2, par3, par4, 4, 2);
        }

        if (par6ItemStack.hasDisplayName())
        {
            ((TileEntityFurnace)par1World.getBlockTileEntity(par2, par3, par4)).func_94129_a(par6ItemStack.getDisplayName());
        }
    }

    /**
     * ejects contained items into the world, and notifies neighbours of an update, as appropriate
     */
    public void breakBlock(World par1World, int par2, int par3, int par4, int par5, int par6)
    {
        if (!keepRefinerInventory)
        {
            TileEntityRefiner tileentityrefiner = (TileEntityRefiner)par1World.getBlockTileEntity(par2, par3, par4);

            if (tileentityrefiner != null)
            {
                for (int j1 = 0; j1 < tileentityrefiner.getSizeInventory(); ++j1)
                {
                    ItemStack itemstack = tileentityrefiner.getStackInSlot(j1);

                    if (itemstack != null)
                    {
                        float f = this.refinerRand.nextFloat() * 0.8F + 0.1F;
                        float f1 = this.refinerRand.nextFloat() * 0.8F + 0.1F;
                        float f2 = this.refinerRand.nextFloat() * 0.8F + 0.1F;

                        while (itemstack.stackSize > 0)
                        {
                            int k1 = this.refinerRand.nextInt(21) + 10;

                            if (k1 > itemstack.stackSize)
                            {
                                k1 = itemstack.stackSize;
                            }

                            itemstack.stackSize -= k1;
                            EntityItem entityitem = new EntityItem(par1World, (double)((float)par2 + f), (double)((float)par3 + f1), (double)((float)par4 + f2), new ItemStack(itemstack.itemID, k1, itemstack.getItemDamage()));

                            if (itemstack.hasTagCompound())
                            {
                                entityitem.getEntityItem().setTagCompound((NBTTagCompound)itemstack.getTagCompound().copy());
                            }

                            float f3 = 0.05F;
                            entityitem.motionX = (double)((float)this.refinerRand.nextGaussian() * f3);
                            entityitem.motionY = (double)((float)this.refinerRand.nextGaussian() * f3 + 0.2F);
                            entityitem.motionZ = (double)((float)this.refinerRand.nextGaussian() * f3);
                            par1World.spawnEntityInWorld(entityitem);
                        }
                    }
                }

                par1World.func_96440_m(par2, par3, par4, par5);
            }
        }

        super.breakBlock(par1World, par2, par3, par4, par5, par6);
    }
    
    @SideOnly(Side.CLIENT)
    private Icon[] icons;
    
    @SideOnly(Side.CLIENT)
    public void registerIcons(IconRegister ir){
    	icons = new Icon[3];
    	
    	icons[0] = ir.registerIcon("IndustrialBreakout:9");
    	icons[1] = ir.registerIcon("IndustrialBreakout:10");
    	icons[2] = ir.registerIcon("IndustrialBreakout:18");
    }
    
    @SideOnly(Side.CLIENT)
    public Icon getIcon(int side, int metadata){
    	switch(side)
    	{
    		case 0:
    			return icons[1];
    		case 1:
    			return icons[1];
    		case 3:
    			return icons[2];
    		default:
    			return icons[0];
    	}
    }
}

 

that's the code of one of my machines

if you find something royally messed up with it plz point it out

[ObsequiousNewt]

What's funny is i just did that... after looking at what i said, but when i copied the script, it still didnt work... ive came to the conclusion that i really screwed something up when updating...

 

package IndustrialBreakout.Machines;

import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.block.BlockContainer;
import net.minecraft.block.material.Material;
import net.minecraft.client.renderer.texture.IconRegister;
import net.minecraft.entity.EntityLiving;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.tileentity.TileEntityChest;
import net.minecraft.tileentity.TileEntityFurnace;
import net.minecraft.util.Icon;
import net.minecraft.util.MathHelper;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import IndustrialBreakout.*;
import IndustrialBreakout.TileEntity.*;

public class BlockIBMachineRefiner extends BlockContainer
{
    /**
     * Is the random generator used by refiner to drop the inventory contents in random directions.
     */
    private Random refinerRand = new Random();

    /** True if this is an active refiner, false if idle */
    private final boolean isActive;

    /**
     * This flag is used to prevent the refiner inventory to be dropped upon block removal, is used internally when the
     * refiner block changes from idle to active and vice-versa.
     */
    private static boolean keepRefinerInventory = false;

    public BlockIBMachineRefiner(int par1, boolean par2)
    {
        super(par1, Material.rock);
        this.isActive = par2;
    }

    /**
     * Returns the ID of the items to drop on destruction.
     */
    public int idDropped(int par1, Random par2Random, int par3)
    {
        return mod_IndustrialBreakout.machineRefiner.blockID;
    }

    /**
     * Called whenever the block is added into the world. Args: world, x, y, z
     */
    public void onBlockAdded(World par1World, int par2, int par3, int par4)
    {
        super.onBlockAdded(par1World, par2, par3, par4);
        this.setDefaultDirection(par1World, par2, par3, par4);
    }

    /**
     * set a blocks direction
     */
    private void setDefaultDirection(World par1World, int par2, int par3, int par4)
    {
        if (!par1World.isRemote)
        {
            int var5 = par1World.getBlockId(par2, par3, par4 - 1);
            int var6 = par1World.getBlockId(par2, par3, par4 + 1);
            int var7 = par1World.getBlockId(par2 - 1, par3, par4);
            int var8 = par1World.getBlockId(par2 + 1, par3, par4);
            byte var9 = 3;

            if (Block.opaqueCubeLookup[var5] && !Block.opaqueCubeLookup[var6])
            {
                var9 = 3;
            }

            if (Block.opaqueCubeLookup[var6] && !Block.opaqueCubeLookup[var5])
            {
                var9 = 2;
            }

            if (Block.opaqueCubeLookup[var7] && !Block.opaqueCubeLookup[var8])
            {
                var9 = 5;
            }

            if (Block.opaqueCubeLookup[var8] && !Block.opaqueCubeLookup[var7])
            {
                var9 = 4;
            }

            par1World.setBlockMetadataWithNotify(par2, par3, par4, var9, 2);
        }
    }

    /**
     * Called upon block activation (right click on the block.)
     */
    public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int par6, float par7, float par8, float par9)
    {
        if (world.isRemote)
        {
            return true;
        }
        else
        {
            player.openGui(mod_IndustrialBreakout.instance, 3, world, x, y, z);
        }
        return true;
    }

    /**
     * Returns a new instance of a block's tile entity class. Called on placing the block.
     */
    public TileEntity createNewTileEntity(World par1World)
    {
        return new TileEntityRefiner();
    }

    /**
     * Called when the block is placed in the world.
     */
    public void onBlockPlacedBy(World par1World, int par2, int par3, int par4, EntityLiving par5EntityLiving, ItemStack par6ItemStack)
    {
        int l = MathHelper.floor_double((double)(par5EntityLiving.rotationYaw * 4.0F / 360.0F) + 0.5D) & 3;

        if (l == 0)
        {
            par1World.setBlockMetadataWithNotify(par2, par3, par4, 2, 2);
        }

        if (l == 1)
        {
            par1World.setBlockMetadataWithNotify(par2, par3, par4, 5, 2);
        }

        if (l == 2)
        {
            par1World.setBlockMetadataWithNotify(par2, par3, par4, 3, 2);
        }

        if (l == 3)
        {
            par1World.setBlockMetadataWithNotify(par2, par3, par4, 4, 2);
        }

        if (par6ItemStack.hasDisplayName())
        {
            ((TileEntityFurnace)par1World.getBlockTileEntity(par2, par3, par4)).func_94129_a(par6ItemStack.getDisplayName());
        }
    }

    /**
     * ejects contained items into the world, and notifies neighbours of an update, as appropriate
     */
    public void breakBlock(World par1World, int par2, int par3, int par4, int par5, int par6)
    {
        if (!keepRefinerInventory)
        {
            TileEntityRefiner tileentityrefiner = (TileEntityRefiner)par1World.getBlockTileEntity(par2, par3, par4);

            if (tileentityrefiner != null)
            {
                for (int j1 = 0; j1 < tileentityrefiner.getSizeInventory(); ++j1)
                {
                    ItemStack itemstack = tileentityrefiner.getStackInSlot(j1);

                    if (itemstack != null)
                    {
                        float f = this.refinerRand.nextFloat() * 0.8F + 0.1F;
                        float f1 = this.refinerRand.nextFloat() * 0.8F + 0.1F;
                        float f2 = this.refinerRand.nextFloat() * 0.8F + 0.1F;

                        while (itemstack.stackSize > 0)
                        {
                            int k1 = this.refinerRand.nextInt(21) + 10;

                            if (k1 > itemstack.stackSize)
                            {
                                k1 = itemstack.stackSize;
                            }

                            itemstack.stackSize -= k1;
                            EntityItem entityitem = new EntityItem(par1World, (double)((float)par2 + f), (double)((float)par3 + f1), (double)((float)par4 + f2), new ItemStack(itemstack.itemID, k1, itemstack.getItemDamage()));

                            if (itemstack.hasTagCompound())
                            {
                                entityitem.getEntityItem().setTagCompound((NBTTagCompound)itemstack.getTagCompound().copy());
                            }

                            float f3 = 0.05F;
                            entityitem.motionX = (double)((float)this.refinerRand.nextGaussian() * f3);
                            entityitem.motionY = (double)((float)this.refinerRand.nextGaussian() * f3 + 0.2F);
                            entityitem.motionZ = (double)((float)this.refinerRand.nextGaussian() * f3);
                            par1World.spawnEntityInWorld(entityitem);
                        }
                    }
                }

                par1World.func_96440_m(par2, par3, par4, par5);
            }
        }

        super.breakBlock(par1World, par2, par3, par4, par5, par6);
    }
    
    @SideOnly(Side.CLIENT)
    private Icon[] icons;
    
    @SideOnly(Side.CLIENT)
    public void registerIcons(IconRegister ir){
    	icons = new Icon[3];
    	
    	icons[0] = ir.registerIcon("IndustrialBreakout:9");
    	icons[1] = ir.registerIcon("IndustrialBreakout:10");
    	icons[2] = ir.registerIcon("IndustrialBreakout:18");
    }
    
    @SideOnly(Side.CLIENT)
    public Icon getIcon(int side, int metadata){
    	switch(side)
    	{
    		case 0:
    			return icons[1];
    		case 1:
    			return icons[1];
    		case 3:
    			return icons[2];
    		default:
    			return icons[0];
    	}
    }
}

 

that's the code of one of my machines

if you find something royally messed up with it plz point it out

Well, yes. Your orientation is dependent on metadata, but getIcon() isn't checking the metadata.

[Vemahk20]

I thought that the 2 variables on the genIcon() was the side number and the metadata value

[ObsequiousNewt]

I thought that the 2 variables on the genIcon() was the side number and the metadata value

Yes, but you're not using the metadata argument. You need to check for each combination of side and metadata.

[Vemahk20]

I have no idea how this works in truth... i tried debuging with adding a switch that included the metavalue but it kept changing.. first it was 5, then 0, then 2... there are some times where programming makes me hate it -.-