Jump to content

[Solved]Multi texture block bug in inventory


decebaldecebal

Recommended Posts

Hello forge community, I have created a multi textured block that is based on the furnace code.It basically works the same as the furnace, but with different recipes.The problem I have is that the texture on the block works well when it is placed in the world, but when it is in my hand or inventory, the texture does not render correctly.Here is a screenshot that shows exactly what I mean:

nm4Z6l3.jpg

 

The code to my block class is located here:

http://pastebin.com/eeMPk18v

 

Any help with this would be greatly appreciated.

 

Also, I have found another small bug with this block.I have made some custom fuels that can run into this custom furnace, some of them which have a very long burn time.The bug I found is that if I have an item that burns for let's say 30 seconds, and it burns half way through, after I exit the world and re-log back in, the flaming animation from the furnace fuel progress bar is back in the starting position, and not in the middle as it was before.After I wait another 14 seconds, the flame starts to go down very fast and finally it stops when the item is fully burned.I have no idea how to fix this bug.

 

I repeat that I have done exactly everything as the furnace does things, but it seems to not work properly.

Link to comment
Share on other sites

Also, I have found another small bug with this block.I have made some custom fuels that can run into this custom furnace, some of them which have a very long burn time.The bug I found is that if I have an item that burns for let's say 30 seconds, and it burns half way through, after I exit the world and re-log back in, the flaming animation from the furnace fuel progress bar is back in the starting position, and not in the middle as it was before.After I wait another 14 seconds, the flame starts to go down very fast and finally it stops when the item is fully burned.I have no idea how to fix this bug.

 

I repeat that I have done exactly everything as the furnace does things, but it seems to not work properly.

This bug is present in vanilla furnaces too last time I checked. If anyone knows a fix, I could use it too, but I've kind of given up on it myself.

Read my thoughts on my summer mod work and tell me what you think!

http://www.minecraftforge.net/forum/index.php/topic,8396.0.html

 

I absolutely love her when she smiles

Link to comment
Share on other sites

This bug is present in vanilla furnaces too last time I checked. If anyone knows a fix, I could use it too, but I've kind of given up on it myself.

 

Well I kind of tested it with a normal furnace and couldn't find any problem with the animation, maybe the fuel I used didn't burn for long enough if you say that this happens with Vanilla too...

Link to comment
Share on other sites

I meant the second bug. That's why I quoted you mentioning the second bug.

Put a piece of coal and 8 iron in a vanilla furnace and wait till 4 pieces have been smelted. The fire will have burned down halfway. Exit the world, then log back in, and you will notice the fire is full again, and will drop rapidly when it reaches the last item to be smelted.

Read my thoughts on my summer mod work and tell me what you think!

http://www.minecraftforge.net/forum/index.php/topic,8396.0.html

 

I absolutely love her when she smiles

Link to comment
Share on other sites

I have a solution for the second bug, but I'm stuck on the first myself.

 

The bug is caused because the fuel value of the last item burnt isn't written to NBT, and is read by looking at the item in the slot when the tile entity is loaded. All's well and good if that item is the same as before, but if the stack ran out then it defaults to 200 to avoid zero division.

 

Adding a new tag in the writeToNBT() and readFromNBT() methods seemed to solve it:

 

public void writeToNBT( NBTTagCompound tagCompound )
{
	super.writeToNBT( tagCompound );

	tagCompound.setShort( "BurnTime", (short) furnaceBurnTime );
	tagCompound.setShort( "CookTime", (short) furnaceCookTime );
	tagCompound.setShort( "ItemBurnTime", (short) currentItemBurnTime );        // <- this

	// add inventory and shizzle
}

public void readFromNBT( NBTTagCompound tagCompound )
{
	super.readFromNBT( tagCompound );
   
	// read inventory and shizzle

	furnaceBurnTime = tagCompound.getShort( "BurnTime" );
	furnaceCookTime = tagCompound.getShort( "CookTime" );
	currentItemBurnTime = tagCompound.getShort( "ItemBurnTime" );        // <- and this
}

 

... or something along those lines.

Link to comment
Share on other sites

What is the metadata of the block when it's in your hand?

given that this is how you call the front texture this should probably be thought about. (I'm guessing 0 and that it is rendering on the bottom of the item)

 

hint:

if you want to see the metadata in minecraft (sans NEI), just hold F3 and press H

Link to comment
Share on other sites

What is the metadata of the block when it's in your hand?

given that this is how you call the front texture this should probably be thought about. (I'm guessing 0 and that it is rendering on the bottom of the item)

 

hint:

if you want to see the metadata in minecraft (sans NEI), just hold F3 and press H

 

Well the metada of the block is 0, so I will try to check if the metadata is 0 and render that texture, but the problem is how to stop this happening in the world also.I will try it and see if it works.

Link to comment
Share on other sites

OK, so it seems that everything is fixed now.For the side, I added another check when the metadata is 0 and the side is 3, and that seems to work perfectly fine, in the inventory it looks like the furnace, and in the world everything works perfectly.

 

Also I added to the NBT data what Homletmoo said:

 

Adding a new tag in the writeToNBT() and readFromNBT() methods seemed to solve it:

 

public void writeToNBT( NBTTagCompound tagCompound )
{
	super.writeToNBT( tagCompound );

	tagCompound.setShort( "BurnTime", (short) furnaceBurnTime );
	tagCompound.setShort( "CookTime", (short) furnaceCookTime );
	tagCompound.setShort( "ItemBurnTime", (short) currentItemBurnTime );        // <- add this

	// add inventory and shizzle
}

public void readFromNBT( NBTTagCompound tagCompound )
{
	super.readFromNBT( tagCompound );
   
	// read inventory and shizzle

	furnaceBurnTime = tagCompound.getShort( "BurnTime" );
	furnaceCookTime = tagCompound.getShort( "CookTime" );

                currentItemBurnTime = getItemBurnTime(this.furnaceItemStacks[1]);     // <- if you have this delete it and

	currentItemBurnTime = tagCompound.getShort( "ItemBurnTime" );        // <- add this
}

 

Thanks for the help guys!

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • rp.crazyheal.xyz mods  
    • I'm developing a dimension, but it's kinda resource intensive so some times during player teleporting it lags behind making the player phase down into the void, so im trying to implement some kind of pregeneration to force the game loading a small set of chunks in the are the player will teleport to. Some of the things i've tried like using ServerLevel and ServerChunkCache methods like getChunk() dont actually trigger chunk generation if the chunk isn't already on persistent storage (already generated) or placing tickets, but that doesn't work either. Ideally i should be able to check when the task has ended too. I've peeked around some pregen engines, but they're too complex for my current understanding of the system of which I have just a basic understanding (how ServerLevel ,ServerChunkCache  and ChunkMap work) of. Any tips or other classes I should be looking into to understand how to do this correctly?
    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.