Jump to content

Recommended Posts

Posted

Hello forge community, I have created a multi textured block that is based on the furnace code.It basically works the same as the furnace, but with different recipes.The problem I have is that the texture on the block works well when it is placed in the world, but when it is in my hand or inventory, the texture does not render correctly.Here is a screenshot that shows exactly what I mean:

nm4Z6l3.jpg

 

The code to my block class is located here:

http://pastebin.com/eeMPk18v

 

Any help with this would be greatly appreciated.

 

Also, I have found another small bug with this block.I have made some custom fuels that can run into this custom furnace, some of them which have a very long burn time.The bug I found is that if I have an item that burns for let's say 30 seconds, and it burns half way through, after I exit the world and re-log back in, the flaming animation from the furnace fuel progress bar is back in the starting position, and not in the middle as it was before.After I wait another 14 seconds, the flame starts to go down very fast and finally it stops when the item is fully burned.I have no idea how to fix this bug.

 

I repeat that I have done exactly everything as the furnace does things, but it seems to not work properly.

Posted

Also, I have found another small bug with this block.I have made some custom fuels that can run into this custom furnace, some of them which have a very long burn time.The bug I found is that if I have an item that burns for let's say 30 seconds, and it burns half way through, after I exit the world and re-log back in, the flaming animation from the furnace fuel progress bar is back in the starting position, and not in the middle as it was before.After I wait another 14 seconds, the flame starts to go down very fast and finally it stops when the item is fully burned.I have no idea how to fix this bug.

 

I repeat that I have done exactly everything as the furnace does things, but it seems to not work properly.

This bug is present in vanilla furnaces too last time I checked. If anyone knows a fix, I could use it too, but I've kind of given up on it myself.

Read my thoughts on my summer mod work and tell me what you think!

http://www.minecraftforge.net/forum/index.php/topic,8396.0.html

 

I absolutely love her when she smiles

Posted

This bug is present in vanilla furnaces too last time I checked. If anyone knows a fix, I could use it too, but I've kind of given up on it myself.

 

Well I kind of tested it with a normal furnace and couldn't find any problem with the animation, maybe the fuel I used didn't burn for long enough if you say that this happens with Vanilla too...

Posted

I meant the second bug. That's why I quoted you mentioning the second bug.

Put a piece of coal and 8 iron in a vanilla furnace and wait till 4 pieces have been smelted. The fire will have burned down halfway. Exit the world, then log back in, and you will notice the fire is full again, and will drop rapidly when it reaches the last item to be smelted.

Read my thoughts on my summer mod work and tell me what you think!

http://www.minecraftforge.net/forum/index.php/topic,8396.0.html

 

I absolutely love her when she smiles

Posted

I have a solution for the second bug, but I'm stuck on the first myself.

 

The bug is caused because the fuel value of the last item burnt isn't written to NBT, and is read by looking at the item in the slot when the tile entity is loaded. All's well and good if that item is the same as before, but if the stack ran out then it defaults to 200 to avoid zero division.

 

Adding a new tag in the writeToNBT() and readFromNBT() methods seemed to solve it:

 

public void writeToNBT( NBTTagCompound tagCompound )
{
	super.writeToNBT( tagCompound );

	tagCompound.setShort( "BurnTime", (short) furnaceBurnTime );
	tagCompound.setShort( "CookTime", (short) furnaceCookTime );
	tagCompound.setShort( "ItemBurnTime", (short) currentItemBurnTime );        // <- this

	// add inventory and shizzle
}

public void readFromNBT( NBTTagCompound tagCompound )
{
	super.readFromNBT( tagCompound );
   
	// read inventory and shizzle

	furnaceBurnTime = tagCompound.getShort( "BurnTime" );
	furnaceCookTime = tagCompound.getShort( "CookTime" );
	currentItemBurnTime = tagCompound.getShort( "ItemBurnTime" );        // <- and this
}

 

... or something along those lines.

Posted

What is the metadata of the block when it's in your hand?

given that this is how you call the front texture this should probably be thought about. (I'm guessing 0 and that it is rendering on the bottom of the item)

 

hint:

if you want to see the metadata in minecraft (sans NEI), just hold F3 and press H

Posted

What is the metadata of the block when it's in your hand?

given that this is how you call the front texture this should probably be thought about. (I'm guessing 0 and that it is rendering on the bottom of the item)

 

hint:

if you want to see the metadata in minecraft (sans NEI), just hold F3 and press H

 

Well the metada of the block is 0, so I will try to check if the metadata is 0 and render that texture, but the problem is how to stop this happening in the world also.I will try it and see if it works.

Posted

OK, so it seems that everything is fixed now.For the side, I added another check when the metadata is 0 and the side is 3, and that seems to work perfectly fine, in the inventory it looks like the furnace, and in the world everything works perfectly.

 

Also I added to the NBT data what Homletmoo said:

 

Adding a new tag in the writeToNBT() and readFromNBT() methods seemed to solve it:

 

public void writeToNBT( NBTTagCompound tagCompound )
{
	super.writeToNBT( tagCompound );

	tagCompound.setShort( "BurnTime", (short) furnaceBurnTime );
	tagCompound.setShort( "CookTime", (short) furnaceCookTime );
	tagCompound.setShort( "ItemBurnTime", (short) currentItemBurnTime );        // <- add this

	// add inventory and shizzle
}

public void readFromNBT( NBTTagCompound tagCompound )
{
	super.readFromNBT( tagCompound );
   
	// read inventory and shizzle

	furnaceBurnTime = tagCompound.getShort( "BurnTime" );
	furnaceCookTime = tagCompound.getShort( "CookTime" );

                currentItemBurnTime = getItemBurnTime(this.furnaceItemStacks[1]);     // <- if you have this delete it and

	currentItemBurnTime = tagCompound.getShort( "ItemBurnTime" );        // <- add this
}

 

Thanks for the help guys!

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • So me and a couple of friends are playing with a shitpost mod pack and one of the mods in the pack is corail tombstone and for some reason there is a problem with it, where on death to fire the player will get kicked out of the server and the tombstone will not spawn basically deleting an entire inventory, it doesn't matter what type of fire it is, whether it's from vanilla fire/lava, or from modded fire like ice&fire/lycanites and it's common enough to where everyone on the server has experienced at least once or twice and it doesn't give any crash log. a solution to this would be much appreciated thank you!
    • It is 1.12.2 - I have no idea if there is a 1.12 pack
    • Okay, but does the modpack works with 1.12 or just with 1.12.2, because I need the Forge client specifically for Minecraft 1.12, not 1.12.2
    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.