Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[Solved]Multi texture block bug in inventory

decebaldecebal

By decebaldecebal
in Modder Support

 Share

Recommended Posts

decebaldecebal Tree Puncher

decebaldecebal

Posted
Posted

Hello forge community, I have created a multi textured block that is based on the furnace code.It basically works the same as the furnace, but with different recipes.The problem I have is that the texture on the block works well when it is placed in the world, but when it is in my hand or inventory, the texture does not render correctly.Here is a screenshot that shows exactly what I mean:

nm4Z6l3.jpg

 

The code to my block class is located here:

http://pastebin.com/eeMPk18v

 

Any help with this would be greatly appreciated.

 

Also, I have found another small bug with this block.I have made some custom fuels that can run into this custom furnace, some of them which have a very long burn time.The bug I found is that if I have an item that burns for let's say 30 seconds, and it burns half way through, after I exit the world and re-log back in, the flaming animation from the furnace fuel progress bar is back in the starting position, and not in the middle as it was before.After I wait another 14 seconds, the flame starts to go down very fast and finally it stops when the item is fully burned.I have no idea how to fix this bug.

 

I repeat that I have done exactly everything as the furnace does things, but it seems to not work properly.

redria7 Creeper Killer

redria7

Posted
Posted

Also, I have found another small bug with this block.I have made some custom fuels that can run into this custom furnace, some of them which have a very long burn time.The bug I found is that if I have an item that burns for let's say 30 seconds, and it burns half way through, after I exit the world and re-log back in, the flaming animation from the furnace fuel progress bar is back in the starting position, and not in the middle as it was before.After I wait another 14 seconds, the flame starts to go down very fast and finally it stops when the item is fully burned.I have no idea how to fix this bug.

 

I repeat that I have done exactly everything as the furnace does things, but it seems to not work properly.

This bug is present in vanilla furnaces too last time I checked. If anyone knows a fix, I could use it too, but I've kind of given up on it myself.

Read my thoughts on my summer mod work and tell me what you think!

http://www.minecraftforge.net/forum/index.php/topic,8396.0.html

 

I absolutely love her when she smiles

decebaldecebal Tree Puncher

decebaldecebal

Posted
  • Author
Posted

This bug is present in vanilla furnaces too last time I checked. If anyone knows a fix, I could use it too, but I've kind of given up on it myself.

 

Well I kind of tested it with a normal furnace and couldn't find any problem with the animation, maybe the fuel I used didn't burn for long enough if you say that this happens with Vanilla too...

redria7 Creeper Killer

redria7

Posted
Posted

I meant the second bug. That's why I quoted you mentioning the second bug.

Put a piece of coal and 8 iron in a vanilla furnace and wait till 4 pieces have been smelted. The fire will have burned down halfway. Exit the world, then log back in, and you will notice the fire is full again, and will drop rapidly when it reaches the last item to be smelted.

Read my thoughts on my summer mod work and tell me what you think!

http://www.minecraftforge.net/forum/index.php/topic,8396.0.html

 

I absolutely love her when she smiles

Homletmoo Tree Puncher

Homletmoo

Posted
Posted

I have a solution for the second bug, but I'm stuck on the first myself.

 

The bug is caused because the fuel value of the last item burnt isn't written to NBT, and is read by looking at the item in the slot when the tile entity is loaded. All's well and good if that item is the same as before, but if the stack ran out then it defaults to 200 to avoid zero division.

 

Adding a new tag in the writeToNBT() and readFromNBT() methods seemed to solve it:

 

public void writeToNBT( NBTTagCompound tagCompound )
{
	super.writeToNBT( tagCompound );

	tagCompound.setShort( "BurnTime", (short) furnaceBurnTime );
	tagCompound.setShort( "CookTime", (short) furnaceCookTime );
	tagCompound.setShort( "ItemBurnTime", (short) currentItemBurnTime );        // <- this

	// add inventory and shizzle
}

public void readFromNBT( NBTTagCompound tagCompound )
{
	super.readFromNBT( tagCompound );
   
	// read inventory and shizzle

	furnaceBurnTime = tagCompound.getShort( "BurnTime" );
	furnaceCookTime = tagCompound.getShort( "CookTime" );
	currentItemBurnTime = tagCompound.getShort( "ItemBurnTime" );        // <- and this
}

 

... or something along those lines.

Yagoki Diamond Finder

Yagoki

Posted
Posted

What is the metadata of the block when it's in your hand?

given that this is how you call the front texture this should probably be thought about. (I'm guessing 0 and that it is rendering on the bottom of the item)

 

hint:

if you want to see the metadata in minecraft (sans NEI), just hold F3 and press H

github
decebaldecebal Tree Puncher

decebaldecebal

Posted
  • Author
Posted

What is the metadata of the block when it's in your hand?

given that this is how you call the front texture this should probably be thought about. (I'm guessing 0 and that it is rendering on the bottom of the item)

 

hint:

if you want to see the metadata in minecraft (sans NEI), just hold F3 and press H

 

Well the metada of the block is 0, so I will try to check if the metadata is 0 and render that texture, but the problem is how to stop this happening in the world also.I will try it and see if it works.

decebaldecebal Tree Puncher

decebaldecebal

Posted
  • Author
Posted

OK, so it seems that everything is fixed now.For the side, I added another check when the metadata is 0 and the side is 3, and that seems to work perfectly fine, in the inventory it looks like the furnace, and in the world everything works perfectly.

 

Also I added to the NBT data what Homletmoo said:

 

Adding a new tag in the writeToNBT() and readFromNBT() methods seemed to solve it:

 

public void writeToNBT( NBTTagCompound tagCompound )
{
	super.writeToNBT( tagCompound );

	tagCompound.setShort( "BurnTime", (short) furnaceBurnTime );
	tagCompound.setShort( "CookTime", (short) furnaceCookTime );
	tagCompound.setShort( "ItemBurnTime", (short) currentItemBurnTime );        // <- add this

	// add inventory and shizzle
}

public void readFromNBT( NBTTagCompound tagCompound )
{
	super.readFromNBT( tagCompound );
   
	// read inventory and shizzle

	furnaceBurnTime = tagCompound.getShort( "BurnTime" );
	furnaceCookTime = tagCompound.getShort( "CookTime" );

                currentItemBurnTime = getItemBurnTime(this.furnaceItemStacks[1]);     // <- if you have this delete it and

	currentItemBurnTime = tagCompound.getShort( "ItemBurnTime" );        // <- add this
}

 

Thanks for the help guys!

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • disaptmnt
      Forge Server Error - '[Forge Version Check/WARN][ne.mi.fm.VersionChecker/]: Failed to process update information'

      By disaptmnt · Posted

      Hello, I have this same problem. Did you manage to find a solution? Any help would be appreciated. Thanks.
    • Cledd
      Game freezes then crashes upon entering server after i used a far-away waystone. (BMC4)

      By Cledd · Posted

      log: https://mclo.gs/QJg3wYX as stated in the title, my game freezes upon loading into the server after i used a far-away waystone in it. The modpack i'm using is better minecraft V18. Issue only comes up in this specific server, singleplayer and other servers are A-okay. i've already experimented with removing possible culprits like modernfix and various others to no effect. i've also attempted a full reinstall of the modpack profile. Issue occurs shortly after the 'cancel' button dissapears on the 'loading world' section of the loading screen.   thanks in advance.
    • Ugdhar
      Help with Modpack

      By Ugdhar · Posted

      You would have better results asking a more specific question. What have you done? What exactly do you need help with? Please also read the FAQ regarding posting logs.
    • Blatopebas
      Model and textures rendered on entity and RenderLevelStageEvent not visible when using shaders

      By Blatopebas · Posted

      Hi, this is my second post with the same content as no one answered this and it's been a long time since I made the last post, I want to make a client-only mod, everything is ok, but when I use shaders, none of the textures rendered in RenderLevelStageEvent nor the crow entity model are rendered, I want them to be visible, because it's a horror themed mod I've already tried it with different shaders, but it didn't work with any of them and I really want to add support for shaders Here is how i render the crow model in the CrowEntityRenderer<CrowEntity>, by the time i use this method, i know is not the right method but i don't think this is the cause of the problem, the renderType i'm using is entityCutout @Override public void render(CrowEntity p_entity, float entityYaw, float partialTick, PoseStack poseStack, MultiBufferSource bufferSource, int packedLight) { super.render(p_entity, entityYaw, partialTick, poseStack, bufferSource, packedLight); ClientEventHandler.getClient().crow.renderToBuffer(poseStack, bufferSource.getBuffer(ClientEventHandler.getClient().crow .renderType(TEXTURE)), packedLight, OverlayTexture.NO_OVERLAY, Utils.rgb(255, 255, 255)); } Here renderLevelStage @Override public void renderWorld(RenderLevelStageEvent e) { horrorEvents.draw(e); } Here is how i render every event public void draw(RenderLevelStageEvent e) { for (HorrorEvent event : currentHorrorEvents) { event.tick(e.getPartialTick()); event.draw(e); } } Here is how i render the crow model on the event @Override public void draw(RenderLevelStageEvent e) { if(e.getStage() == RenderLevelStageEvent.Stage.AFTER_ENTITIES) { float arcProgress = getArcProgress(0.25f); int alpha = (int) Mth.lerp(arcProgress, 0, 255); int packedLight = LevelRenderer.getLightColor(Minecraft.getInstance().level, blockPos); VertexConsumer builder = ClientEventHandler.bufferSource.getBuffer(crow); Crow<CreepyBirdHorrorEvent> model = ClientEventHandler .getClient().crow; model.setupAnim(this); RenderHelper.renderModelInWorld(model, position, offset, e.getCamera(), e.getPoseStack(), builder, packedLight, OverlayTexture.NO_OVERLAY, alpha); builder = ClientEventHandler.bufferSource.getBuffer(eyes); RenderHelper.renderModelInWorld(model, position, offset, e.getCamera(), e.getPoseStack(), builder, 15728880, OverlayTexture.NO_OVERLAY, alpha); } } How i render the model public static void renderModelInWorld(Model model, Vector3f pos, Vector3f offset, Camera camera, PoseStack matrix, VertexConsumer builder, int light, int overlay, int alpha) { matrix.pushPose(); Vec3 cameraPos = camera.getPosition(); double finalX = pos.x - cameraPos.x + offset.x; double finalY = pos.y - cameraPos.y + offset.y; double finalZ = pos.z - cameraPos.z + offset.z; matrix.pushPose(); matrix.translate(finalX, finalY, finalZ); matrix.mulPose(Axis.XP.rotationDegrees(180f)); model.renderToBuffer(matrix, builder, light, overlay, Utils .rgba(255, 255, 255, alpha)); matrix.popPose(); matrix.popPose(); } Thanks in advance
    • TileEntity
      crashing on world creation

      By TileEntity · Posted

      Same issue - I have no idea

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept