How to make a value for an overrides predicate in a json file to change the model of an item?

[MaxAnimator]

Hello there,

so I got an item, which can be thrown. The issues is, it's facing the wrong way when doing the charge animation when right click is held. I checked how Mojang did with the trident, they're using an overrides predicate with a special value called "throwing", that updates from 0.0 to 1.0 when the item is being thrown.

How could I make my own value just like they did? I checked the wiki but the docs are out of date.

[MaxAnimator]

up

[Beethoven92]

You have to register a new property for your item, and make use of it in your item json (as you already saw in the trident json), you can find everything you need in orded to do that in the ItemModelsProperties class

[MaxAnimator]

Hello again,

thanks for the info!

I got a problem though...

It does that, with that:

public ModdedSpearItem(Properties properties)
	{
		super(properties);
		ItemModelsProperties.registerProperty(Registries.iron_spear.get(), new ResourceLocation("spear_throwing"), (itemstack, clientworld, livingentity) -> {
			return livingentity != null && livingentity.isHandActive() && livingentity.getActiveItemStack() == itemstack ? 1.0F : 0.0F;
		});
	}

and that's how my object is registered:

public static final RegistryObject<Item> iron_spear = ITEMS.register("iron_spear", () -> new ModdedSpearItem(new Item.Properties().group(Azure.TAB).maxStackSize(1)));

You got any idea of what I've done wrong?

[MaxAnimator]

public Azure() {
        FMLJavaModLoadingContext.get().getModEventBus().addListener(this::setup);
        FMLJavaModLoadingContext.get().getModEventBus().addListener(this::doClientStuff);
        FMLJavaModLoadingContext.get().getModEventBus().addListener(this::enqueueWork);
        
        Registries.init();

        MinecraftForge.EVENT_BUS.register(this);
    }

private void enqueueWork(final FMLClientSetupEvent event)
    {
    	ItemModelsProperties.registerProperty(Registries.iron_spear.get(), new ResourceLocation("spear_throwing"), (itemstack, clientworld, livingentity) -> {
			return livingentity != null && livingentity.isHandActive() && livingentity.getActiveItemStack() == itemstack ? 1.0F : 0.0F;
		});
    }

Am I doing something wrong? The game launches but seems to ignore it.

[Beethoven92]

You just created a new method called enqueueWork, what diesieben07 meant is to use FMLClientSetupEvent#enqueueWork, take a look inside the FMLClientSetupEvent class and its super classes

[MaxAnimator]

10 minutes ago, diesieben07 said:

You called your method enqueueWork... that's not going to do anything. You need to use enqueueWork on the event, because ItemModelsProperties is not threadsafe.

You also registered your property under the "minecraft" namespace, which is probably not what you intended (nor what you should do).

What do you mean "under the "minecraft" namespace"? And also how do I use the enqueueWork function?

Edited December 21, 2020 by MaxAnimator

[Danebi]

5 minutes ago, MaxAnimator said:

What do you mean "under the "minecraft" namespace"?

https://mcforge.readthedocs.io/en/latest/concepts/resources/#resourcelocation

6 minutes ago, MaxAnimator said:

And also how do I use the enqueueWork function?

By calling it?

[MaxAnimator]

1 minute ago, Danebi said:

https://mcforge.readthedocs.io/en/latest/concepts/resources/#resourcelocation

By calling it?

I don't understand what arguments it takes.

[MaxAnimator]

I don't know what a Runnable is. I'm still learning java...

[MaxAnimator]

Ok I just got it to work... but it still doesn't do anything.

private void doClientStuff(final FMLClientSetupEvent event) {
    	event.enqueueWork(new Runnable() {
			public void run() {
				ItemModelsProperties.registerProperty(Registries.iron_spear.get(), new ResourceLocation("azure:spear_throwing"), (itemstack, clientworld, livingentity) -> {
					return livingentity != null && livingentity.isHandActive() && livingentity.getActiveItemStack() == itemstack ? 1.0F : 0.0F;
				});
			}
		});
    }

 

[MaxAnimator]

public Azure() {
        FMLJavaModLoadingContext.get().getModEventBus().addListener(this::setup);
        FMLJavaModLoadingContext.get().getModEventBus().addListener(this::doClientStuff);
        
        Registries.init();

        MinecraftForge.EVENT_BUS.register(this);
    }

It's here so it should be called

[MaxAnimator]

It is called.

[MaxAnimator]

I have no idea, that's why I asked you...

[MaxAnimator]

33 minutes ago, diesieben07 said:

You said "it is not working".

Which behavior made you say that?

The game seems to ignore it. There's no modification made at all when in game; I checked my model and it does work; so it's coming from this piece of code:

private void doClientStuff(final FMLClientSetupEvent event) {
    	event.enqueueWork(new Runnable() {
			public void run() {
				ItemModelsProperties.registerProperty(Registries.iron_spear.get(), new ResourceLocation("azure:spear_throwing"), (itemstack, clientworld, livingentity) -> {
					return livingentity != null && livingentity.isHandActive() && livingentity.getActiveItemStack() == itemstack ? 1.0F : 0.0F;
				});
			}
		});
    }

 

[MaxAnimator]

Sure, here it is:

https://github.com/MaxAnimator/Azure

[MaxAnimator]

Thank you!!!! I'll check about data generators and how they work, thanks again!!