[1.16.3] Biome#getRegistryName always returns null

[Budschie]

So, I've recently been trying to create a new chunk generator for my mod.

Because I want individual chunk generators per biome, and because the biome class itself can't be extended anymore,

I decided to create a hash map with a resource location as an input and a custom class(with the chunk gen) as an output.

 

The thing is, everytime I want to access this hash map with the resource location of the biome, it returns null.

After a quick debugging sessions it turns out that the method Biome#getRegistryName always returns null, even on vanilla and hardcoded biomes.

 

How can I solve/avoid this problem?

 

Help would be appreciated.

-Budschie

Edited December 27, 2020 by Budschie

[kiou.23]

it'd be easier to help you if you were to provide your code

[Budschie]

So, here is my code:

 

Calling Biome#getRegistryName

Biome biome = worldGenRegion.getBiome(new BlockPos(posXStart + x, 0, posZStart + z));
BiomeGeneratorBase biomeGenerator = BiomeDataHandler.getBiomeData(biome.getRegistryName()).getBiomeGenerator();

 

Setup of the BiomeDataHandler:

BiomeDataHandler.addBiomeData(new ResourceLocation(References.MODID, "green_forest_biome"), new GreenForestBiomeData());
BiomeDataHandler.addBiomeData(new ResourceLocation(References.MODID, "deepnether"), new DeepnetherBiomeData());

 

Here is my GitHub-Repo: https://github.com/Budschie/Deepnether-Mod/tree/1.16.3

[Budschie]

Is there maybe something else that could identify a biome uniquely, besides from the registry name?

[Budschie]

bump

[ChampionAsh5357]

It's not guaranteed to return a proper value. You should pass the biome instance into the biome registry held within DynamicRegistries and do a reverse lookup instead to grab the associated resource location.