[SOLVED] [1.16.4] Ore Generation not Working

[Linky132]

Hi, after my last thread, someone on the Forge Discord server gave me some code to generate ores. However, this code doesn't appear to be generating my block anywhere, and I was wondering if anyone could tell me why.

 

Here is my code:

OreGen class:

package linky132.waywardcraft;

import net.minecraft.block.BlockState;
import net.minecraft.util.registry.Registry;
import net.minecraft.util.registry.WorldGenRegistries;
import net.minecraft.world.gen.GenerationStage;
import net.minecraft.world.gen.feature.ConfiguredFeature;
import net.minecraft.world.gen.feature.Feature;
import net.minecraft.world.gen.feature.OreFeatureConfig;
import net.minecraftforge.event.world.BiomeLoadingEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;

import java.util.ArrayList;

public class OreGen
{
    public static final ArrayList<ConfiguredFeature<?,?>> ORE_GENERATORS = new ArrayList<>();

    public static void register()
    {
        registerOreGenerator(RegistryHandler.SALT_BLOCK.get().getDefaultState(),16,200,"salt_block");
    }

    public static void registerOreGenerator(BlockState blockState, int patchSize, int maxHeight, String name)
    {
        Registry<ConfiguredFeature<?, ?>> registry = WorldGenRegistries.CONFIGURED_FEATURE;
        ConfiguredFeature<?,?> configuredFeature = Feature.ORE.withConfiguration(new OreFeatureConfig(OreFeatureConfig.FillerBlockType.BASE_STONE_OVERWORLD,blockState,patchSize)).range(maxHeight).square().func_242731_b(157);
        ORE_GENERATORS.add(configuredFeature);
        Registry.register(registry,WaywardCraft.MODID + name,configuredFeature);
    }

    @SubscribeEvent
    public void loadBiomes(BiomeLoadingEvent event)
    {
        for(ConfiguredFeature<?,?> feature : ORE_GENERATORS)
        {
            event.getGeneration().withFeature(GenerationStage.Decoration.UNDERGROUND_ORES,feature);
        }
    }
}

 

Main mod class:

package linky132.waywardcraft;

import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent;

@Mod(WaywardCraft.MODID)
public class WaywardCraft
{
    public static final String MODID = "waywardcraft";

    public WaywardCraft()
    {
        MinecraftForge.EVENT_BUS.register(this);

        RegistryHandler.init();

        MinecraftForge.EVENT_BUS.register(new OreGen());
    }
    void commonSetup(FMLCommonSetupEvent event)
    {
        event.enqueueWork(this::afterCommonSetup);
    }
    private void afterCommonSetup()
    {
        OreGen.register();
    }
}

 

Thank you.

Edited January 9, 2021 by Linky132

[Beethoven92]

Have you checked if this:

    @SubscribeEvent
    public void loadBiomes(BiomeLoadingEvent event)
    {
        for(ConfiguredFeature<?,?> feature : ORE_GENERATORS)
        {
            event.getGeneration().withFeature(GenerationStage.Decoration.UNDERGROUND_ORES,feature);
        }
    }

is actually fired or not?

[Linky132]

Thanks for replying. I just checked it by using a print method, and the funny thing is that the "loadBiomes" method is firing, but the contents of the for loop are never executed. Any idea why that could be?

Edited January 7, 2021 by Linky132

[Beethoven92]

Well, if the for loop is never executed, make sure that there is actually something inside the list you are looping through

[Linky132]

Huh, that's weird, apparently the list is empty. That doesn't make sense, though, since configuredFeature is being added to it, and looks to be valid. I can also confirm that it's not a problem with my block, as it also doesn't work with vanilla blocks. Any ideas?

[Beethoven92]

So, if the list is empty it means that maybe the features aren't actually added to that list...so the last thing to check is if the OreGen.register method is called

[Linky132]

Aha, so that's the problem! the afterCommonSetup method is never called, which is probably due to the commonSetup method not being called either. I assume I did something wrong with the event bus or the listener?

[Beethoven92]

FMLCommonSetupEvent is fired on the Mod bus, not the forge bus

[Linky132]

Okay, so using that information, I tried replacing the forge bus line with

FMLJavaModLoadingContext.get().getModEventBus().register(new OreGen());

but it resulted in an error while loading the mod, basically just saying:

java.lang.IllegalArgumentException: Method public void linky132.waywardcraft.OreGen.loadBiomes(net.minecraftforge.event.world.BiomeLoadingEvent) has @SubscribeEvent annotation, but takes an argument that is not a subtype of the base type interface net.minecraftforge.fml.event.lifecycle.IModBusEvent: class net.minecraftforge.event.world.BiomeLoadingEvent

 

[Beethoven92]

Did you change the bus on which loadBiomes is registered on? It was correct before. FML setup events fire on Mod bus, BiomeLoadingEvent fires on the forge bus

[Linky132]

Sorry, how exactly would I do that?

[Beethoven92]

You had this in your class constructor:

    public WaywardCraft()
    {
        MinecraftForge.EVENT_BUS.register(this);

        RegistryHandler.init();

        MinecraftForge.EVENT_BUS.register(new OreGen());
    }
    

With the third line you are registering the OreGen class to the Forge bus, this means that loadBiomes will correctly listen to the BiomeLoadingEvent (FORGE bus).

With the first line you are instead registering the main mod class (this) to the Forge bus, so any event handler in the main class will listen only to Forge bus events, but FMLCommonSetupEvent is fired on the MOD bus. So you need to register you main class to the MOD bus, which you can get from:

FMLJavaModLoadingContext.get().getModEventBus();

Instead of subscribing your whole class, you can also add listeners to the Mod bus with:

FMLJavaModLoadingContext.get().getModEventBus().addListener(your_listener_method)

 

[Linky132]

That fixed it!! I can finally move on from ore generation! 😂 Thank you so much for your help!!